lifaon74 / events-polyfill Goto Github PK

View Code? Open in Web Editor NEW

28.0 28.0 3.0 121 KB

Polyfill event : EventListener, EventTarget, CustomEvent, MouseEvent, KeyboardEvent

JavaScript 87.73% HTML 0.52% TypeScript 11.75%

events-polyfill's Introduction

Hey there

👨‍💻 About Me :

I am a Senior Front-end Developer from Switzerland.

🔭 I'm working as a front-end developper and love building web applications, as well as open source libraries.
🌱 I love creating and sharing custom libraries, and I beleave in free open source ecosystems build from thousands of developpers.
📫 How to reach me:

🔥 My biggest achievements so far:

🪄 @lirx/core: a reactive library to manage complex data flows with ease.

🛠️ Languages and Tools :

events-polyfill's People

Contributors

Stargazers

Watchers

Forkers

roundtablestudio raiskila talaysa

events-polyfill's Issues

Fails in Safari 11.1.2

Loading this polyfill in Safari is giving us an JS console error,

[Error] TypeError: Property description must be an object

Upgrade from 1.1.11 to 2.0.3 breaks angular app

When I load the polyfill in angular (v5.2) app, I get following errors on v2.0.3:

ERROR Error: Event listener type pointerdown on [object Object] is not supported by current environment
    at Object.EventListenerInterceptor.getSupportedEventType (index.js:326)
    at Object.add (index.js:338)
    at HTMLDivElement.target.addEventListener (index.js:179)
    at DomEventsPlugin.addEventListener (platform-browser.js:3328)
    at EventManager.addEventListener (platform-browser.js:2339)
    at EmulatedEncapsulationDomRenderer2.DefaultDomRenderer2.listen (platform-browser.js:2993)
    at BaseAnimationRenderer.listen (animations.js:646)
    at DebugRenderer2.listen (core.js:15433)
    at DownDirective.ngAfterViewInit (down.directive.ts:35)
    at callProviderLifecycles (core.js:12706)
    at callElementProvidersLifecycles (core.js:12673)
    at callLifecycleHooksChildrenFirst (core.js:12656)
    at checkAndUpdateView (core.js:13811)
    at callViewAction (core.js:14153)
    at execEmbeddedViewsAction (core.js:14111)
    at checkAndUpdateView (core.js:13803)
    at callViewAction (core.js:14153)
    at execEmbeddedViewsAction (core.js:14111)
    at checkAndUpdateView (core.js:13803)
    at callViewAction (core.js:14153)
    at execComponentViewsAction (core.js:14085)
    at checkAndUpdateView (core.js:13808)
    at callViewAction (core.js:14153)
    at execEmbeddedViewsAction (core.js:14111)
    at checkAndUpdateView (core.js:13803)
    at callViewAction (core.js:14153)
    at execComponentViewsAction (core.js:14085)
    at checkAndUpdateView (core.js:13808)
    at callViewAction (core.js:14153)
    at execComponentViewsAction (core.js:14085)
    at checkAndUpdateView (core.js:13808)
    at callViewAction (core.js:14153)
    at execEmbeddedViewsAction (core.js:14111)
    at checkAndUpdateView (core.js:13803)
    at callViewAction (core.js:14153)
    at execComponentViewsAction (core.js:14085)
    at checkAndUpdateView (core.js:13808)
    at callWithDebugContext (core.js:15056)
    at Object.debugCheckAndUpdateView [as checkAndUpdateView] (core.js:14593)
    at ViewRef_.detectChanges (core.js:11577)
    at eval (core.js:5907)
    at Array.forEach (<anonymous>)
    at ApplicationRef.tick (core.js:5907)
    at eval (core.js:5740)
    at ZoneDelegate.invoke (zone.js:388)
    at Object.onInvoke (core.js:4749)
    at ZoneDelegate.invoke (zone.js:387)
    at Zone.run (zone.js:138)
    at NgZone.run (core.js:4566)
    at Object.next (core.js:5740)
    at SafeSubscriber.schedulerFn [as _next] (core.js:4331)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:240)
    at SafeSubscriber.next (Subscriber.js:187)
    at Subscriber._next (Subscriber.js:128)
    at Subscriber.next (Subscriber.js:92)
    at EventEmitter.Subject.next (Subject.js:56)
    at EventEmitter.emit (core.js:4311)
    at checkStable (core.js:4714)
    at onLeave (core.js:4793)
    at Object.onInvokeTask (core.js:4743)
    at ZoneDelegate.invokeTask (zone.js:420)
    at Zone.runTask (zone.js:188)
    at ZoneTask.invokeTask [as invoke] (zone.js:496)
    at invokeTask (zone.js:1517)
    at XMLHttpRequest.globalZoneAwareCallback (zone.js:1543)

Expected behavior:
no runtime errors as on v1.1.11

Be careful to avoid a TypeError when detect options support

Check out this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Getter_only

Unable to get property 'transition' of undefined or null reference

Hi. After doing import 'events-polyfill', I get the following error in IE 11:

TypeError: Unable to get property 'transition' of undefined or null reference
   at EventListenerInterceptor.isSupportedTransitionEvent (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:1296:5)
   at EventListenerInterceptor.getSupportedEventType (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:1362:9)
   at add (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:1380:9)
   at target.prototype.addEventListener (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:1221:13)
   at ResizeObserverController.prototype.connect_ (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:78209:5)
   at ResizeObserverController.prototype.addObserver (http://localhost:3000/packages/modules.js?hash=6078294545688c872c4b6f56253c389881a374dc:78128:9)
   at ResizeObserverSPI.prototype.observe (http://localhost:3000/packages/modules.js?hash=6078294

fails to work with dynamically defined handleEvent function

Due to the line here

events-polyfill/index.js

Line 87 in bc989dc

 } else if((typeof listener === 'object') && (typeof listener.handleEvent === 'function')) { 

if the handleEvent function is added dynamically (something that i like to do, because this way nobody can rebind it out of its scope), it will not work

I think it's quite safe to drop the check for the function itself. If it's an object, it needs to have a handleEvent, as defined in the addEventListenerApi : it's a function, or an object

Throwing error will stop page executing

When using events-polyfill on clients page. He got in IE error

https://github.com/lifaon74/events-polyfill/blob/master/index.js#L415

              if(passive) {
                event.preventDefault = function() {
                  throw new Error('Unable to preventDefault inside passive event listener invocation.');
                };
              }

I know it's client's fault, but his web works without our script (which contains polyfill) :)

So any help how to not break his web and still use polyfill?

lifaon74 / events-polyfill Goto Github PK

events-polyfill's Introduction

Hey there

👨‍💻 About Me :

🔥 My biggest achievements so far:

🛠️ Languages and Tools :

events-polyfill's People

Contributors

Stargazers

Watchers

Forkers

events-polyfill's Issues

Fails in Safari 11.1.2

Upgrade from 1.1.11 to 2.0.3 breaks angular app

Be careful to avoid a TypeError when detect options support

Unable to get property 'transition' of undefined or null reference

fails to work with dynamically defined handleEvent function

Throwing error will stop page executing

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent