Giter VIP home page Giter VIP logo

Comments (5)

lightdash-bot avatar lightdash-bot commented on June 3, 2024

This issue was mentioned by a user in slack: https://lightdash-community.slack.com/archives/C03MG2VTR08/p1713401937122029?thread_ts=1713401937.122029&cid=C03MG2VTR08

from lightdash.

joaoviana avatar joaoviana commented on June 3, 2024

How to replicate this locally:

http://localhost:3000/projects/3675b69e-8324-4110-bdca-059031aa8da3/tables/tracks?create_saved_chart_version=%7B%22tableName%22%3A%22tracks%22%2C%22metricQuery%22%3A%7B%22exploreName%22%3A%22tracks%22%2C%22dimensions%22%3A%5B%22tracks_timestamp_month%22%5D%2C%22metrics%22%3A%5B%22tracks_event_count%22%5D%2C%22filters%22%3A%7B%22tableCalculations%22%3A%7B%22id%22%3A%2287b91103-5658-48d9-bd87-448a5a4ce5a6%22%2C%22and%22%3A%5B%7B%22id%22%3A%22dcfa9f95-c33d-4f86-94b2-7916a01f8d5b%22%2C%22target%22%3A%7B%22fieldId%22%3A%22test_1%22%7D%2C%22operator%22%3A%22greaterThan%22%2C%22values%22%3A%5B-1%5D%7D%5D%7D%7D%2C%22sorts%22%3A%5B%7B%22fieldId%22%3A%22tracks_event_count%22%2C%22descending%22%3Atrue%7D%5D%2C%22limit%22%3A500%2C%22tableCalculations%22%3A%5B%7B%22name%22%3A%22test_1%22%2C%22displayName%22%3A%22test%22%2C%22sql%22%3A%22%28%24%7Btracks.event_count%7D+-+4028%29+%2F+1000%22%2C%22format%22%3A%7B%22type%22%3A%22default%22%2C%22separator%22%3A%22default%22%2C%22currency%22%3A%22USD%22%7D%2C%22type%22%3A%22number%22%7D%5D%2C%22additionalMetrics%22%3A%5B%5D%7D%2C%22tableConfig%22%3A%7B%22columnOrder%22%3A%5B%22tracks_timestamp_month%22%2C%22tracks_event_count%22%2C%22test_1%22%5D%7D%2C%22chartConfig%22%3A%7B%22type%22%3A%22cartesian%22%2C%22config%22%3A%7B%22layout%22%3A%7B%22xField%22%3A%22test_1%22%2C%22yField%22%3A%5B%22tracks_event_count%22%5D%2C%22flipAxes%22%3Afalse%7D%2C%22eChartsConfig%22%3A%7B%22series%22%3A%5B%7B%22type%22%3A%22bar%22%2C%22yAxisIndex%22%3A0%2C%22encode%22%3A%7B%22xRef%22%3A%7B%22field%22%3A%22test_1%22%7D%2C%22yRef%22%3A%7B%22field%22%3A%22tracks_event_count%22%7D%7D%7D%5D%2C%22xAxis%22%3A%5B%7B%22min%22%3A%220%22%7D%2C%7B%7D%5D%7D%7D%7D%7D
image

TC sql:

(${tracks.event_count} - 4028) / 1000

from lightdash.

joaoviana avatar joaoviana commented on June 3, 2024

Related issue in apache/echarts: apache/echarts#18793

from lightdash.

joaoviana avatar joaoviana commented on June 3, 2024

This is reflected when the type of axis is value + there's a 0 value and when there's no custom x axis range set

NOTE:
if you set the min axis value to 0, then the overlap will stay
if you set the min axis value to -1, then the problem on the Y Axis will be fixed. but the overlapping could happen on the max of the x axis:
image
There should be a way for us to calculate the max of the rows returned, and set that as the default

My proposed solution is:

  • Let them enable a truncation offset it so it will apply an offset on the min of -0.5(default) and and on the max of +0.5(default)
  • This will find the min value of the data + max value of the data (from rows) and set it as the default value when setting manual x-axis range (will auto-populate the fields). This is expensive but since it's a niche problem then it will positively impact the chart output
  • This is the result when the x axis truncation + offsets are set:
image

from lightdash.

lightdash-bot avatar lightdash-bot commented on June 3, 2024

🎉 This issue has been resolved in version 0.1105.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from lightdash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.