Giter VIP home page Giter VIP logo

Comments (4)

orionlee avatar orionlee commented on August 25, 2024

One expedient way to fix it is to change the short cadence threshold from 300 seconds to 200 seconds. Would there be any unintended side effects?

elif exptime in ["short"]:
mask &= (products["exptime"] >= 60) & (products["exptime"] < 300)
elif exptime in ["long", "ffi"]:
mask &= products["exptime"] >= 300
return mask

from lightkurve.

Nschanche avatar Nschanche commented on August 25, 2024

Hi @orionlee , good point. I tend to think people who use the 'short cadence' flag do actually want the postage stamp products, not FFI data. I will think on how we want to handle this. Thanks for the suggestion!

from lightkurve.

orionlee avatar orionlee commented on August 25, 2024

BTW, the issue is also applicable to search_targetpixelfile(), because TESS-SPOC HLSP also releases TPFs, in addition to lightcurve files. For example,

> print(lk.search_targetpixelfile("TIC261136679", mission="TESS", sector=61, cadence="short"))

#     mission     year   author  exptime target_name distance  proposal_id 
                                     s                 arcsec               
--- -------------- ---- --------- ------- ----------- -------- -------------
  0 TESS Sector 61 2023      SPOC     120   261136679      0.0 G05144_G05155
  1 TESS Sector 61 2023 TESS-SPOC     200   261136679      0.0           N/A

from lightkurve.

Nschanche avatar Nschanche commented on August 25, 2024

I've put in PR #1410 that implements this fix (ie, short cadence is now <200 rather than < 300 so that FFI data is not returned.

from lightkurve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.