Giter VIP home page Giter VIP logo

lsx-banners's People

Contributors

dependabot-preview[bot] avatar dependabot[bot] avatar eleshar avatar fmdalpiaz avatar imgbotapp avatar jacquesvdhorst avatar joseabreu1985 avatar josephlightspeed avatar krugazul avatar mergify[bot] avatar nandotess avatar viscosho avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

garthglaum

lsx-banners's Issues

Trying to save an image banner here for the category archive, it's not working, all the functionality for banners on a category still need to be tested.

Describe the bug
Trying to save an image banner here for the category archive, it's not working. No image is being saved on this banner pages.

To Reproduce

  1. Go to edit a category
  2. Click on Banner
  3. Pick an image
  4. Save
  5. Notice how it does not save.

Expected behavior
The image should be saved and display as banner in the archive page.

Screenshots
screenshot

Reference
https://www.bugherd.com/projects/97685/tasks/212

Previous and Next event title disappearing

Describe the bug
If I turn on the option for Dynamic title on the Event Calendar option from the theme options, the Previous and Next event title on the body of each event on the single page of the event. If I disable this option, the meta works fine.

To Reproduce
Steps to reproduce the behaviour:

Go to Theme Options -> Tribe Event Options
Check the Dynamic Title Option
Save
See error on any single event page

Expected behaviour
This change should only affect the banner, not the list of events on the body.

Screenshots

With the option 'on'
Screen Shot 2020-01-16 at 8 53 24 AM

With the option 'off'
Screen Shot 2020-01-16 at 8 53 38 AM

Desktop (please complete the following information):
Happening in all browsers

Mobile (please complete the following information):
Happening in device

Meta Description disappearing

Describe the bug
If I turn on the option for Dynamic title on the Event Calendar option from the theme options, the meta information disappears on the body of each event on the archive page of the event (on list view, month view and calendar view). If I disable this option, the meta works fine.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to Theme Options -> Tribe Event Options
  2. Check the Dynamic Title Option
  3. Save
  4. See error on the Calendar Archive page

Expected behaviour
This change should only affect the banner, not the list of events on the body.

Screenshots

With the option 'on'
Screen Shot 2019-10-30 at 11 22 33 AM

With the option 'off'
Screen Shot 2019-10-30 at 11 24 13 AM

Desktop (please complete the following information):

  • sHappening in all browsers

Mobile (please complete the following information):

  • Happening in device

Multiple H1s when LSX is active.

When LSX Banners is active it replaces the archive-title with a banner which has the header in but doesn't remove it which causes 2 h1's being present on the site.
Capture

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.