Giter VIP home page Giter VIP logo

lightspeedwp / lsx-design Goto Github PK

View Code? Open in Web Editor NEW
17.0 3.0 0.0 20.55 MB

A WordPress Block theme designed to work seamlessly with WooCommerce, supported by a Figma Design System.

Home Page: https://lsx.design

License: GNU General Public License v3.0

CSS 26.31% JavaScript 0.20% PHP 43.36% HTML 24.09% SCSS 6.04%
lsx-design block-theme gutenberg wordpress woocommerce woocommerce-theme

lsx-design's People

Contributors

antonvandiermen avatar ashleyshaw avatar dependabot-preview[bot] avatar dependabot[bot] avatar eleshar avatar fmdalpiaz avatar garthglaum avatar imgbotapp avatar jacquesvdhorst avatar joseabreu1985 avatar josephlightspeed avatar justinabes007 avatar krugazul avatar mergify[bot] avatar nandotess avatar rafisegerman avatar renovate-bot avatar viscosho avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

lsx-design's Issues

WooCommerce Memberships - Compatibility

Description

We need to look at the various screens that the WC Memberships plugin creates, and make sure we have templates, patterns or styling to handle the layouts.

You can use the LightSpeed user to view the following screens. It has been setup with a Platinum Plan expiring in 2025.

Tasks

Screenshots

Membership plans

screencapture-demo-lsx-design-membership-plans-2023-08-02-08_48_04

Single Membership

screencapture-demo-lsx-design-product-platinum-membership-2023-08-02-08_52_45

My Account - My Memberships

screencapture-demo-lsx-design-my-account-members-area-2023-08-02-08_06_46

My Account - My Membership Content

screencapture-demo-lsx-design-my-account-members-area-2026-my-membership-content-2023-08-02-08_38_45

Restricted Post

screencapture-demo-lsx-design-memberships-restricted-post-2023-08-02-08_53_16

Menu Breaks on Tablet

Describe the bug
Menu displays broken on Tablet, responsiveness needs attention and styling fixes to work on Tablet and similar devices.

Expected behavior
The Menu design should not display behind the Logo and drop down items should display better inline.

Additional Context
This is due to the hard coded breakpoint in WordPress core, set to 600px. There have been a few queries about this already.

  • Add WordPress Issue link here.

image

Additional Block Styles for the Paragraph block

Currently it is manual process of adding properties
There is no standard way to easily apply a subheading style. When we manually set font sizes they no longer respond to the theme defaults.

Add 3 new block styles

  • Subheading H1 - Font size 48; Appearance Medium
  • Subheading H2 - Font size 30; Appearance Medium
  • Subheading H3 - Font size 24; Appearance Medium

Increase the padding between the menu items and the submenus

When you hover over a menu item, the submenu sits flush with the menu item above.

Solution
We need to increase the bottom and top padding on the LI element, and reduce the padding of the header. To allow the mouse to keep the submenu open when navigating to it.

Additional context
Screenshot 2023-06-26 at 16 41 47

LSX Design - Site Editor Bugs

Describe the bug
When using the Site Editor there are specific Blocks which have options to edit text size however these edits are not updating on the front end.

Details Block:
To Reproduce

  1. Open the Site Editor
  2. Select the Details Block
  3. Select the text, and change the text size

Expected behavior
The text size should change but doesn't, none of the options working.

Screenshots
Screenshot of Editor
Screenshot 2023-11-16 at 14 14 12

Screenshot of Front End CSS generated from Editor:
Screenshot 2023-11-16 at 14 14 58

Catalog Sorting:
To Reproduce

  1. Open the Site Editor
  2. Select the Catalog Sorting
  3. No dimension options to adjust spacing. Font can be adjusted, that is all.

Expected behavior
There should be options to include Padding at least.

Screenshots
Screenshot 2023-11-16 at 14 19 58

Woocommerce Breadcrumb
To Reproduce

  1. Open the Site Editor
  2. Select the Woocommerce Breadcrumb
  3. Adjusting the Spacing, Margin or padding doesn't apply any chanegs to font end only on Shop page. Terms page no adjustments work.

Expected behavior
The text size should change but doesn't, none of the options working.

Screenshots
Screenshot of Shop - Margin is removed.
Screenshot 2023-11-16 at 14 23 22

Screenshot of Category page, same block copied to template. Margin displays, seems like the Gutenburg plugin didnt load the styles from the shop.
Screenshot 2023-11-16 at 14 23 30

Additional context
Will continue to include more editor Bugs once they are found.

Accessibility improvements for links

Links are not accessible
Visual Accessibility improvements required on all link types. Majority of links dont have any hover stats, active states or focus states. These link types need improvements:

  • Footer links
  • Nav Menu links
  • Image links
  • Button links
  • Breadcrumbs

Expected behavior
Internal & External links should include a hover stats, active states or focus states to differentiate from the current link state. A colour change alone will not suffice, include underline for each state:

  • Hover states
  • Active states
  • Focus Status

Archives: The category is covering the post title on small screens

Describe the bug
When the browser window width is reduced, the category name, which is displayed to the right of the post title, comes closer and closer to the title. Eventually, the category covers part of the title.

To Reproduce
View an archive page and reduce the browser window width.

Expected behavior
All texts should be readable.

Screenshots

archive.mp4

Desktop (please complete the following information):

  • OS: macOs
  • Browser: Chrome

The Events Calendar - Compatibility

No Template Support for Events Calendar plugin

The Events Calendar currently does not have any block based or php templates for displaying all of the templates within the Events Calendar plugin, most significant is the single events template.

Single Event

Events Archive

Venues

Organisers:

The Events Calendar templates for LSX Design
The solution is to add the missing templates and CSS needed to display events content effectively.

Example Screenshots for Events Calendar Templates
Add any other context or screenshots about the feature request here.

Single Event
single-event

Events Archive Calendar View
events-archive-calendar

Events Archive List View
events-archive-list

Events Tag Archive
events-tag-archive

Events Category Archive
events-category-archive

Venue Archive
venue-archive

Organiser Archive
organizer-archive

The search results template is missing the "no results" block

Describe the bug
When there are no search results, the page displays the search form in the top part of the page but not a
message explaining that there were no results. The rest of the page is empty.
This is, of course, optional but common practice.

To add blocks that are only shown when there are no results, add the "no results" block inside the query loop, but outside the post template block. The block itself does not display anything; it only displays the blocks you place inside it.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a search that you know will have no results on your test site.
  2. View the empty page.

Expected behavior
A message explaining there were no results, and maybe some guidance on what to do next, for example,
list the most recent posts or most popular products.

Theme.json - Dark Theme

Describe the solution you'd like
We would like a "dark" version of the theme available.

Requirements

  • Review other themes style variations
  • Must use theme.json

Additional context
Links to resources
Links to Figma Files

PR - #33

Spacing improvements to Blog Archive & Single templates

Describe the issue
Spacing improvements to Blog Archive & Single templates.

To Reproduce
Steps to reproduce the spacing issues:

Designs

Recent Posts Widget - while in the footer, it displays no bullets

Describe the bug
When the WP Recent Posts block is added to the footer, or any other area, it does not show the bullets like a list item is supposed to.

Expected behaviour

  • Restore the bullets for the list items.
  • Add in Block Stylesheet for the CSS.

Additional Context
Have a look at the code screenshot below, it may be WordPress is removing the bullets. And we need to add them in.

Screenshots
Screenshot 2023-11-13 at 11 14 36

Screenshot 2023-11-13 at 11 16 17

LSX Design - Colour Palette & Button Improvements

Describe the bug
Currently LSX Design Colour Palette and Buttons require attention to improve Accessibility and standardise the Button Hovers, Active & Focus states to work better with the available Colour Palette. Plus improving options for Fonts Styles & Sub Headings

Expected behavior

  1. Adjust the Theme Colour Pallete to be more sustainable for future updates and client projects
  2. Improve Button Styling - Including Hover, Active & Focus states
  3. Better options for SubHeadings that align with Headings

Expected Outcomes

  1. Buttons: Better Colour associations using Colours from the same colour palette for Hover, Active, Focus states with hover animations
  2. Naming convention improvements: Adjusting the naming convention to work with Colour Palette and Custom colours created
  3. Heading & Subheadings: Improving the options to speed up Page edits when working with Headings and Subheadings to avoid additional config per Block required.

Designs on Figma:
https://www.figma.com/file/lDKd5sQc3nhX4ItgczYMJ5/LightSpeed-Website---2023?type=design&node-id=0-1&mode=design

Nit: hyphens (-) are converted to unicode characters

Describe the bug
In some of the templates and patterns, the hyphens in the block comment are replaced with Unicode.
so instead of wp--custom--spacing etc, it says var(\u002d\u002dwp\u002d\u002dcustom\u002d\u002dspacing\u002d\u002dlarge

To Reproduce
View the source of the header template parts and header patterns.

Expected behavior
The recommended format for the CSS variables in the block comments is "var:preset|spacing|70"
Using var(--wp--preset--spacing--70 also works.

Notes

  • Woo Header Dark
  • Woo Header Light
  • Review the Patterns

Search results are limited to one page

Describe the bug
The search template limits the results to one page:
<!-- wp:query {"queryId":0,"query":{"pages":1,"

The number of results that show match the setting in the WordPress Admin > Reading > Blog pages show at most.

  • If this is intentional, the query pagination block can be removed from the template because it will never be used.
  • Or, To display all results, paginated, set "pages": 1 to "pages": 0 in the comment for the query block.

To Reproduce
Steps to reproduce the behavior:

  1. On the font of the website, perform a search and view the search results page.

Expected behavior
To display all results

Switch WooCommerce Products Block and Product Archive Block Templates

WooCommerce Product Archives are using classic templates

Switch WooCommerce Products Block and Product Archive Block Templates

  • Start by opening the site editor, open each archive template and transform the classic template to the new block template.
  • Style the pages to look like the design

Screenshots

Image

Image

Image

Image

LSX Design - Add Sharing Pattern Template Part

Describe the bug
Attempted to create an LSX Sharing Pattern which could be used site wide. Encountered error when adding to theme as Pattern.
Adding as a Template Part did work better locally I got error from LSX Sharing

Error Code
TypeError: Cannot read properties of undefined (reading 'useBlockProps')
at save (http://demo.local/wp-content/plugins/lsx-sharing//build/blocks.js?ver=6.4.1:1:10784)
at zr (http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:4798)
at Ir (http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:5179)
at http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:34027
at Yn (http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:34143)
at http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:35228
at Zn (http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:35292)
at http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:35030
at Array.map ()
at Zn (http://demo.local/wp-includes/js/dist/blocks.min.js?ver=7204d43123223474471a:10:35022)

Expected behavior
Have a Social Share template part which could be which is pre-build and can be added to any template easily when needed.

Gravity Forms - Form Block Compatability

Description
There is no CSS for the Gravity Forms "form block" in the theme. Currently the button does not inherit the

Prep

  • Decide which colour variables the form will use from the theme.json
  • Add in Block CSS for the "Form Block".
  • Setup a full form with all the types of fields neccesary.

Styling

  • Buttons (next page, submit, upload image etc)
  • Field Labels
  • Field inputs
  • Field inputs when active
  • Field inputs with validation errors
  • Confirmation message once submitted
  • Mobile Layout

Current Form
Screenshot 2023-11-13 at 10 44 45

Additional context
The old LSX for reference - https://lsx-demo-staging.lightspeedwp.dev/contact/

Child theme - Remove theme attribute from Parent wp:template-part tags

Child theme missing Template parts - Header & Footer
Template part has been deleted or is unavailable error when enabling another theme.

This PR fixes an issue where the homepage returned the Template part has been deleted or is unavailable error when enabling another theme.

This issue was caused by the theme attribute being included in the wp:template-part tags for the header and footer of the home template.

A similar issue was detailed in WordPress/create-block-theme#242, which is where I identified the fix.

The implementation for the Yoast FAQ block is not accessible to keyboard users

Describe the bug
It is not possible to open and close the FAQ block with the keyboard only.

This is a problem for:

  • Sighted keyboard users
  • Screen reader users

The plus icon is not a focusable element.

To Reproduce
Steps to reproduce the behavior:

  1. Activate the theme and Yoast SEO
  2. Add a Yoast FAQ block to a post, add some content to the question and answers. Save.
  3. Visit the post on the front.
  4. Starting at the top of the page, use the tab key to move between the focusable elements. Navigate past the menu links and the
    link to the post category. The next focusable element is not the FAQ block, but the first link in the comments area.

Expected behavior
To be able to open and close the questions and answers

Screenshots

faq.2023-06-26.mp4

Desktop (please complete the following information):

  • OS: Mac
  • Browser Chrome version 114.0.5735.133

Add support for LSX Search to classic Woo shop and Woo category templates

Describe the solution you'd like
We would like to be able to use the LSX Search plugin in conjunction with the classic WooCommerce Shop and Archive Templates (Category, Tags, Attribute Archives)

We need to look at how the Woo templates are inserted, and if the LSX Search can be made compatible with those.

Additional context
https://demo.lsx.design/wp-admin/options-general.php?page=lsx-search-settings&cmb_tab=product_search
https://demo.lsx.design/wp-admin/options-general.php?page=facetwp
https://demo.lsx.design/shop/

Screenshot 2023-05-17 at 14 13 07

Woocommerce - Product Title Link Colour/Hover - not responding to colour changes.

Describe the bug
Woocommerce - Product Title Link Colour/Hover - not responding to colour changes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Site Editor'
  2. Select the Single Product template
  3. Scroll down to Related Products and select the Product Title '....'
  4. Change Link & Hover states
  5. In editor the Colours work but not in front end.
  6. Front end is using the defeault Theme.json link attributes.

Expected behavior
Link colours should inherit Editor Options

Video example of issue - https://www.loom.com/share/c973a92589a041b8939820ad1feda487?sid=9b3c0389-fe7e-4387-97a7-105cff657427

Looks like the Front end doesn't include any classes or options updated from the editor.

Screenshots
Screenshot of Editor
Screenshot 2023-11-27 at 08 57 29

Screenshot of Front end with incorrect colours
Screenshot 2023-11-27 at 08 57 38

Nit: Remove unused files and add credit for borrowed code

Describe the bug
There seem to be several block patterns that are included as files but not used.

Please also remember that GPL allows re-using code from other GPL products, but adding copyright information and license information for that product is required.
So if you borrow patterns and code from the "Frost" theme and Storefront, you can, but you need to add credits, for example in the readme file.

The installation instructions says to install Storefront

Describe the bug
In the readme, the installation instruction says that one should install Storefront, which of course, is a different theme:

== Installation ==

1. In your admin panel, go to *Appearance > Themes* and click the *'Add New'* button.
2. Type in Storefront in the search form and press the 'Enter' key on your keyboard.
3. Click on the *'Activate'* button to use your new theme right away.
5. Navigate to *Appearance > Site Editor* in your admin panel and customize to taste.

WP 6.4 - Lightbox is active on all images

Description
The new WP6.4 lightbox adds the tags to all images that output. So all images are combined into 1 gallery on a page.

To Reproduce
With the new WP 6.4 installed, load a few galleries onto a page, and click one of the images. You will see all of them are in 1 gallery.

Expected behaviour
We would like to specifically enable it for certain images, such as only the WP gallery on a page, and not have the featured image included in that.

Tasks

  • Add in a "close" button to the modal. (might be a setting)
  • Research how the rel tags are being added, and what filters are being used.
  • Restrict the lightbox to the WP gallery block.

Screenshots
Screenshot 2023-11-13 at 09 56 05

No Search Results - Prompt users on what to do next

Description
We need to offer the user a way to find what they are looking for, when their search returns no results.

Possible Solutions

-[ ] Change the text to something like "No results found, please modify your keywords and try again."
-[ ] Display a list of the most recent posts / post types.
-[ ] Display a list of the categories?

Additional context
https://demo.lsx.design/?s=asdfsss
Screenshot 2023-07-28 at 11 18 02

WooCommerce - Sensei LMS Compatability

Description
We need to make sure the theme displays the Sensei LMS frontend pages and blocks in a decent manner.
We need to go through each page and make sure the following align with the LSX Design scheme.

*Checklist

  • Spacing
  • Font Sizes
  • Font Families
  • Button colours
  • Font colours

Pages

Additional context

  • What patterns are we going to need?
  • Do we need to include any templates in the theme?
  • What happens when we switch to a dark mode?
  • Do we want to customize the "courses" interface at all?

Resources
Learn.WordPress.org Example:
NOTE: Login with the feedmymedia wordpress.org user
All courses - https://learn.wordpress.org/courses/
Single Course - https://learn.wordpress.org/course/open-source-basics-and-wordpress/
Single Lesson - https://learn.wordpress.org/lesson/open-source-principle-0-with-many-eyes-all-bugs-are-shallow-2/

*Screenshots
These are the pages that need most attention.
Courses Login Page
Screenshot 2023-09-07 at 15 11 30

Course List View - images are huge.
Screenshot 2023-09-07 at 15 16 57

Course Dashboard - Log in screen colours.
Screenshot 2023-09-07 at 15 19 59

My Courses Page - Various
Screenshot 2023-09-07 at 15 21 56

Header & Menu responsive bugs

  1. Header responsive improvements
  2. Logo size display with Site title
  3. SImple menu an not full page list
  4. review breakpoints for Tablet

Button SVG's

Describe the bug
Including SVG's into the theme is not possible with Wordpress Security policy.
I have identified a work around to use SVG Unicode, this does work for Flat SVG colours, however if SVG's colours need to be dynamic based on the theme.JSON values, these presets dont appear to adjust any colour settings and this would be needed for Child themes.

Ideally we would like to include SVG icon to work with the Buttons and each Colour Palette including Child themes for future projects.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://demo.lsx.design/button-block/
  2. View the current Primary or CTA button with SVG - which is currently white & white on hover.
  3. View the Secondary Button. The SVG Hover Text is different to the inactive state.

Expected behavior

  1. Ideally the SVG should change colour inline with the Text styling.
  2. This would be different for each button based on the Block style & Colour Palette.

Additional context
Example CSS for SVG code which includes Fill & Stroke

background-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='28' height='29' viewBox='0 0 28 29' fill='none'%3E%3Ccircle cx='14.5' cy='15' r='12' stroke='white' stroke-width='2'/%3E%3Cpath d='M13.4887 11.0045L16.3617 13.7766H9.41327C8.90717 13.7766 8.5 14.1863 8.5 14.6956V15.3082C8.5 15.8175 8.90717 16.2272 9.41327 16.2272H16.3617L13.4887 18.9994C13.1196 19.3555 13.112 19.9489 13.4735 20.3127L13.8921 20.7301C14.2498 21.09 14.8282 21.09 15.1821 20.7301L20.2317 15.6528C20.5894 15.2929 20.5894 14.7109 20.2317 14.3548L15.1821 9.26994C14.8244 8.91002 14.246 8.91002 13.8921 9.26994L13.4735 9.6873C13.112 10.0549 13.1196 10.6484 13.4887 11.0045Z' fill='white'/%3E%3C/svg%3E");

Ideally the Fill & Stroke should be replaced with a theme.JSON preset value: Example - var(--wp--preset--color--cta);

Assigning CSS for Fill & Stroke dont seem to adjust the SVG Unicode.

Patterns have colour &amp; spacing issues

Describe the bug
Version 1.0 of LSX Design theme has various issues with theme patterns, these issues needed to be addressed by improving designs so that a clear

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Site Editor
  2. Click on 'Patterns'
  3. Review each pattern carefully against the designs & address any spacing, colour or other discrepancies.

Tasks

  • Colour Issues
  • Spacing issues causing block errors
  • All patterns need to be compared to the designs
  • All page templates need to be compared to the designs
  • All template parts need to be compared to the designs

Designs
Patterns - https://www.figma.com/file/U3MB5DRLxHpQDoDs2Pi2jG/LSX-WordPress?type=design&node-id=1151-16&mode=design&t=PGkRDb5NlGP94mNq-0

Full Page Patterns - https://www.figma.com/file/U3MB5DRLxHpQDoDs2Pi2jG/LSX-WordPress?type=design&node-id=1151%3A17&mode=design&t=7yWXAmGZJXuF4WtX-1

WordPress Core table block not responsive

Is your feature request related to a problem? Please describe.
Using the WP Core table block works, however, it does not shrink nicely for mobile
https://fisa-2023.lightspeedwp.dev/resources/membership-terminated/

Describe the solution you'd like
Make the table block responsive
Try correct with theme.json otherwise with custom CSS for the table block

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Switch to WooCommerce Order Confirmation Block Template

WooCommerce Order Confirmation Template not blockified
Current the order confirmation template is using classic templates.

Transform the classic template to a block template

  • Visit the site editor and transform the classic template to a blockified template.
  • Add the block template to the theme.
  • Add in a style sheet for the order confirmation totals.
  • Style to the design

Reference this design
https://www.figma.com/file/X2XqREwNM6b3QW2G43rj11/LSX-WooCommerce?type=design&node-id=874%3A7095&mode=design&t=KGJ2QhxJ2jUz1GKg-1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.