lileio / pubsub Goto Github PK

Could you consider adding a working example using the Memory Provider? Preferably one with includes the subscriber and how to set up with components to work together.

Middleware would allow for the simple plugging of logging, tracing, prometheus etc, but also allow users to embed their own tools, like error reporting etc.

This should be easily configurable via options, to allow, info, debug, warn, error etc by default

Can't see in the handler/subscriber or is it only possible to unsubscribe with the Shutdown() ?

There is a new golang project that is very similar to Kafka.
It uses NATS and it's called liftbridge.

I was wondering about integrating it with this and your grpc generator.
But does the grpc generator allow to gen the pub sub middleware ?

I notice the subscribe client when being closed/shutdown, it will loop a map[string]subscription and wait to close each subscription. How about if we subscribe to the same topic a couple of times in one app which could be possibly done through different modules? Then we will override the subscription in the map with the same topic and we won't gracefully shutdown.

type struct subscriptionEntry {
topic string
subscription *stan.Subscription
}

A slice []subscriptionEntryt might be good enough instead of a map.

How to do unsubscribe? I know in most cases, we do not need to.

Is this library still maintained?

This would allow deep config per subscriber to able to control things like maxInProgress and other things.