lilyminium / dash-ngl Goto Github PK

For the sake of completeness a new issue:

Some of the newly added features are buggy:
If I e.g. use a .cif file and select Type: "cartoon" and then e.g. color scheme "volume"
The following error arises:

this.atomColor is not a function

Hey lilyminium,

I hope you are doing well?

you might remember our cross-talk in end of January?

Thanks to twitter my dash-ngl component got recognized by the guys from plotly
and since then there is a PR on-going which I had to abandon because I left the group to start my PhD in Barcelona 😎

So long story short:
If you have some time and still interested in the dash-bio library and playing with NGL I would
love to merge your component with mine?

Apparently they want to use it e.g. in Corona research so this could be our way to contribute to tackling that annoying virus !

Awesome to hear that you got this component working in your app! I'd love to see screenshots if you can share.

Also curious if you would like to wrap up this PR, or if you have any guidance for our team if we do.

I'm interested in making a Dash app that plots these pdb files and compares the 3 different molecule renderers in Dash Bio (dash-ngl, dash-speck, and dash-mol3D):

https://deepmind.com/research/open-source/computational-predictions-of-protein-structures-associated-with-COVID-19

Just scroll down in the PR till the very end to see in which issues you could help us.

But do not feel pressured if you do not have time or are not interested just close this issue ;D

Best,
Ivo

Hello lilyminium,

while searching for a better molecule viewer than molecule3dviewer (https://dash.plot.ly/dash-bio/molecule3dviewer) I stumbled over your repo.
But unfortunately the newest dash versions seems to have broken your component...

Invalid argument activeCoordinates[0] passed into NGLComponent with ID "viewport".
Expected array.
Was supplied type object.

Below are the used dash versions

dash                      1.8.0                    pypi_0    pypi
dash-bio                  0.4.6                    pypi_0    pypi
dash-bio-utils            0.0.4                    pypi_0    pypi
dash-core-components      1.7.0                    pypi_0    pypi
dash-daq                  0.2.2                      py_0    conda-forge
dash-html-components      1.0.2                    pypi_0    pypi
dash-renderer             1.2.3                    pypi_0    pypi
dash-table                4.6.0                    pypi_0    pypi

and here python:

Python 3.7.6 (default, Jan 8 2020, 19:59:22)
[GCC 7.3.0] :: Anaconda, Inc. on linux

In case you do not any longer maintain that project:
I would try to come up with my own dash-ngl component.
I hope you don't mind if I take parts of your code since it looks like a promising template to get started.

Best,
Ivo