limistah / react-here-map Goto Github PK

There is a warning in the library

 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.

Which I think is related with this line: https://github.com/limistah/react-here-map/blob/master/src/components/Platform/index.js#L16

Also there is an unneccesary console.log that I think it can be removed

Can you handle this please so we don't network error when we provide api key only?

Im trying to make use of Here Maps info bubble but don't see any support for it.

Example in vanilla js:

new H.ui.InfoBubble( coords, {
content: 'Test'
});

Hi! Great idea for Here Maps library in React. I love it!
I have a problem though.

Steps to reproduce:

1. create-react-app map-test
2. yarn add react-here-maps
3. Copy example from the readme
4. Add your own APP_ID and APP_KEY
5. yarn start

Outcome:

UNEXPECTED TOKEN
...\node_modules\react-here-map\src\components\HMap\index.js: Unexpected token (27:11)
25 | }
26 | createLoadingComponent() {
27 | return <div>Loading</div>;
|___________^
28 | }
29 | displayChildren() {
30 | const { children } = this.props;`

It is not very well visible here but html tags are being reported as unexpected tokens.

Expected outcome
App starts displaying map

I would really love to test and use this library. Could you help with this error?

The Route/index.js router calculation functions (calculateIsoline or calculateRoute) are commented out in master?

I am trying to change marker location. The expected behavior is to change the same marker position but in the example code, when lat and lon is changed, a new marker is created at that location on the map. How can I achieve that the current icon on the map is positioned according to the new coordinates?

         ` <HMapMarker
              coords={{ lat: lat, lng: lon }}
              options={{}}
              setViewBounds={false}
              icon={MarkerIcon("#28ef1c", true)} 
           />`

currently there is only mapOptions in the docs and there is no example to understand how to use mapEvents.

I am trying to render a custom icon HMapMarker but the icon prop seems to be ignored and defaults to the here maps marker icon

This is because options is not initialised with a default value like {}
You can see here https://github.com/limistah/react-here-map/blob/master/src/components/HMap/objects/Marker.js#L23

I'm trying to adjust the zoom level of the map so that all markers on the map are visible. Official sdk has methods for this, but it is not included in this library. See here Zoom To Set Of Markers
I can use HMapRectangle and setViewBounds for this, but I want the rectangle not to appear on the map. How can I do that?

I'm trying to map the screenX and screenY from my pointerDown event to lat and lon values but can't seem to access this function that's available in the original HERE API. It is used in this example: https://developer.here.com/documentation/examples/maps-js/infoBubbles/position-on-mouse-click

App code credentials will continue to be supported for a few products and current Developer Portal accounts where App code credentials have already been generated for an App. New accounts will only be able to use App Code credentials for some legacy products. App code credentials are the least secure of the authentication credential types and we recommend the use of the API Key or OAuth 2.0 Token credentials instead for improved security.

https://developer.here.com/documentation/authentication/dev_guide/topics/app-credentials.html

Will you update this library to work with the API Key?