Lost transitive dependencies during mavenCentral migration about test-butler HOT 5 CLOSED

Note: they still exist on debugAndroidTestRuntimeClasspath - Runtime classpath of compilation 'googleDebugAndroidTest' (target (androidJvm))., so I think most users are fine, unless they accessed code from -api which is essentially com.linkedin.android.testbutler.ButlerApi.Stub.Proxy. I think users will be fine, but maybe worth noting in changelog?

from test-butler.

Good catch. It may not have been intentional, but I think it's correct. Really I think the bug is we didn't realize these dependencies were leaking to the compile classpath before this change 😄

We were already declaring them as implementation dependencies, but I think our old publishing setup was incorrect and declaring it as an api dependency in the published artifact files. Now it's being correctly published as implementation (aka runtime) which explains what you're seeing.

from test-butler.

Agreed, sounds good.

Will you update these?

• https://github.com/linkedin/test-butler/releases/tag/2.2.1
• https://github.com/linkedin/test-butler/blob/main/CHANGELOG.md#version-220-2021-02-10

As it might be effectively a suprise breaking change if someone got junit transitively from butler and they update a minor/patch version.

Other than doc updates, happy to close.

from test-butler.

Done!

from test-butler.

Cheers! Thanks for the quick turnaround!

from test-butler.