Giter VIP home page Giter VIP logo

Comments (8)

RiteshMaheshwari avatar RiteshMaheshwari commented on July 19, 2024

We should get a static object first and then loop over it, instead of looping over the dict.

from mobster.

RiteshMaheshwari avatar RiteshMaheshwari commented on July 19, 2024

I just tested and this code change most likely fixes the issue:

diff --git a/src/linkedin/mobster/webkitcommunicator.py b/src/linkedin/mobster/webkitcommunicator.py
index b3abc40..543eb55 100644
--- a/src/linkedin/mobster/webkitcommunicator.py
+++ b/src/linkedin/mobster/webkitcommunicator.py
@@ -58,7 +58,8 @@ class RemoteWebKitCommunicator(WebSocketClient):
       id = response['id']
       self._response_callbacks[id](response)
     elif 'method' in response:
-      for callback in self._domain_callbacks[response['method'].split('.')[0]].itervalues():
+      callbacks = self._domain_callbacks[response['method'].split('.')[0]].values()
+      for callback in callbacks:
         callback(response)
     else:
       log.warn('Unrecognized message: {0}'.format(pformat(response)))

from mobster.

armanhb avatar armanhb commented on July 19, 2024

Is there any correlation between the webpage currently being navigated to and when this error occurs?

from mobster.

RiteshMaheshwari avatar RiteshMaheshwari commented on July 19, 2024

Haven't tested for other pages yet, only linkedin.

from mobster.

armanhb avatar armanhb commented on July 19, 2024

Oh I meant does the error normally occur on one particular page in the flow? I can see how this problem could occur, though I'm surprised it actually does.

If that code fixes the problem, please open a pull request (and feel free to merge it yourself).

from mobster.

RiteshMaheshwari avatar RiteshMaheshwari commented on July 19, 2024

Look at the other issue I opened (#19), that may solve this. Lets hold off until we have resolved that issue.

from mobster.

RiteshMaheshwari avatar RiteshMaheshwari commented on July 19, 2024

Confirming that fixing #19 does not fix this issue.

from mobster.

hariramachandra avatar hariramachandra commented on July 19, 2024

Ritesh can you please close this issue after you test it on your desktop

thanks
Hari

from mobster.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.