linux-system-roles / auto-maintenance Goto Github PK

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

This is an example of README of sap-hana-preconfigure, in which some roles are referred.

./README.md:- 'linux-system-roles.timesync'
./README.md:- 'linux-system-roles.sap-base-settings' (for RHEL 7.x until RHEL 7.5)
./README.md:- 'linux-system-roles.sap-preconfigure' (for RHEL 7.6 and later and RHEL 8.x)
./README.md:        - { role: linux-system-roles.sap-base-settings }
./README.md:        - { role: linux-system-roles.sap-hana-preconfigure }

The corresponding converted result:

./roles/sap-hana-preconfigure/README.md:- 'linux-system-roles.timesync'
./roles/sap-hana-preconfigure/README.md:- 'linux-system-roles.sap-base-settings' (for RHEL 7.x until RHEL 7.5)
./roles/sap-hana-preconfigure/README.md:- 'linux-system-roles.sap-preconfigure' (for RHEL 7.6 and later and RHEL 8.x)
./roles/sap-hana-preconfigure/README.md:        - { role: linux-system-roles.sap-base-settings }
./roles/sap-hana-preconfigure/README.md:        - { role: sap.rhel.sap-hana-preconfigure }

All the roles must be converted to the collection format, but it'd be hard to automate it. The FQCNs need to be provided since, e.g., in this example, linux-system-roles.timesync could be either fedora.linux_system_roles.timesync or redhat.rhel_system_roles.timesync, and the others would be sap.rhel.sap-{base-settings,preconfigure}.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

/packit propose-downstream

https://src.fedoraproject.org/rpms/linux-system-roles/c/a38c7ee816ae481403fe9d5aa84bb3515d0591a1?branch=rawhide

The changelog has 1.16.0-2 but the Release: field in the spec file is still Release: 1%{?dist}

According to

it is ok to mention changes to the CI or testing in the changelog. In my opinion, this is too much noise. The changelog should contain only user-facing changes and the other section seems to be the section to fit things such as

• updates to documentation
• updates to examples
• deprecations (for example related to conscious language)

I just run ./sync-template.sh -r kernel_settings -t {{token}} and I don't see anything in https://github.com/linux-system-roles/kernel_settings/pulls. By investigating the script's output, I found

{
  "message": "Problems parsing JSON",
  "documentation_url": "https://docs.github.com/rest/reference/pulls#create-a-pull-request"
}

This is related to curl command, which was run as

curl -u 'systemroller:{{token}}' -X POST -d '{"title":"Synchronize files from linux-system-roles/template",
"base":"master",
"head":"lsr-template-sync",
"body":"This PR propagates files from [linux-system-roles/template](https://github.com/linux-system-roles/template) which should be in sync across [linux-system-roles](https://github.com/linux-system-roles) repos. In case of changing affected files via pushing to this PR, please do not forget also to push the changes to [linux-system-roles/template](https://github.com/linux-system-roles/template) repo.

Revision: [`448ff39c16f171b7f09ff5a21e62340add304d55`](https://github.com/linux-system-roles/template/tree/448ff39c16f171b7f09ff5a21e62340add304d55)

CC: @i386x, @pcahyna, @richm"}' 'https://api.github.com/repos/linux-system-roles/kernel_settings/pulls'

curl command above exits with 0, so the script behaves like everything have been ok.

Observe that commit linux-system-roles/kernel_settings@54d04c1 has been pushed to lsr-template-sync branch successfully.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.

The test_copy_tree_with_replace unit test passes pre_params to the create_test_tree function, the pre_params has one dictionary with "key": "roles" that results in such a task file:

- name: Ensure that the role runs with default parameters
  hosts: all
  tasks:
    - name: default task
      roles:
        - fedora.system_roles.systemrole

This syntax does not exist in Ansible. The reesulting task file must be similar to the following:

- name: Ensure that the role runs with default parameters
  hosts: all
  roles:
    - fedora.system_roles.systemrole

There's a lot of bash code in this repo, and shellcheck is a fantastic linting tool. This repo could be configured to run shellcheck via Travis CI or the new GitHub Actions feature.

Packit failed on creating pull-requests in dist-git (https://src.fedoraproject.org/rpms/linux-system-roles.git):

You can retrigger the update by adding a comment (/packit propose-downstream) into this issue.