linux-system-roles / sap-hana-preconfigure Goto Github PK

This step is already part of role sap-preconfigure.

The code for regerating the grub2 config should be able to detect the boot mode.

It probably makes sense to add "LANG=C " in front of each command which is executed on remote hosts and from which the stdout output is evaluated.
Examples: tasks/RedHat/generic/:
configure-cpu-governor-for-performance.yml line 10
configure-epb.yml line 10

$ ansible --version
ansible 2.8.3

I think it needs to be include_tasks: tasks/RedHat/generic/regenerate-grub2-conf.yml; I'll pr it

Disabling THP is not limited to x86_64, according to SAP note 2777782.

The topic of this SAP note (GCC 6.x) is already covered completely by vars/RedHat_7.yml. And RHEL 8 comes with GCC 6 compatibility.

It just makes the role less complex. We might add this feature again at a later time.

This file is already copied by role sap-preconfigure.

The sap-hana tuned profile will be installed by this role in any case as it is part of the subscription. Using this variables, users can decide if the sap-hana tuned profile should be used or not.

repos are named like this:
rhui-rhel-7-server-rhui-eus-rpms
rhel-sap-for-rhel-7-server-eus-rhui-rpms
rhui-sap-hana-for-rhel-7-server-eus-rpms

When using this role on a system without firewalld installed, the systemctl module throws an error.
So either we add firewalld to the list of required packages or check that it is not installed

Make sure that the role works in playbooks that run with the --check (-c) option. This option set the variable check_only to true, so that modules will not execute their tasks, but only print what they would do.
Hence some shell snippets and other tasks that set prerequisites and variables need to run in check mode too.

really a minor issue.

... so that it does not show up as changed when running the playbook. See https://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html .

Although the roles will ensure there is always a backup when /etc/default/grub is modified, there might be cases where modifying GRUB_CMDLINE_LINUX and regenerating the grub config file should not be done.

The follwoing packages are required for ppcle on Power 9

yum install librtas src rsct.core.utils rsct.core rsct.basic rsct.opt.storagerm
devices.chrp.base.ServiceRM DynamicRM ncurses-libs readline sqlite
sg3_utils libgcc libstdc++ zlib iprutils lsvpd libvpd libservicelog
servicelog powerpc-utils ppc64-diag IBMinvscout

They are currently disabled in the role, as they were not available during test. They are now available via:
https://public.dhe.ibm.com/software/server/POWER/Linux/yum/OSS/RHEL/8/ppc64le/

valid for RHEL8.0 and 8.1

"update_only: true" is not a valid parameter to the "package" module in RedHat/installation.yml

Similar to linux-system-roles/sap-preconfigure#60 .

... and change code to not perform config steps when tuned-profiles-sap-hana is used (RHEL 7, SAP note 2292690).

Disabling THP is not limited to x86_64, according to SAP note 2292690.

It's just best practices.

See also linux-system-roles/network/tasks/main.yml and linux-system-roles/timesync/tasks/main.yml.

A variable will be defined three times. This looks like, if this is not the perfect way. I did not tested it with RHEL 7.3 an 7.2.

TASK [sap-hana-preconfigure : include os specific vars]

[WARNING]: While constructing a mapping from /tmp/dev/ansible/sap-hana-preconfigure/vars/RedHat_7.yml, line 5,
column 1, found a duplicate dict key (sap_hana_preconfigure_min_packages). Using last defined value only.
[WARNING]: While constructing a mapping from /tmp/dev/ansible/sap-hana-preconfigure/vars/RedHat_7.yml, line 5,
column 1, found a duplicate dict key (when). Using last defined value only.
ok: [40.114.142.135] => (item=/tmp/dev/ansible/sap-hana-preconfigure/vars/RedHat_7.yml)

Use /etc/init.d/boot.local for EPB, according to SAP note.

The test for updating is failing. rc is not defined:
See output:
TASK [sap-hana-preconfigure : restart machine if required] *********************

fatal: [dhcp168.coe.muc.redhat.com]: FAILED! => {"msg": "The conditional check 'sap_hana_preconfigure_reboot_after_update == true and sap_hana_preconfigure_register_reboot_required.rc == 1' failed. The error was: error while evaluating conditional (sap_hana_preconfigure_reboot_after_update == true and sap_hana_preconfigure_register_reboot_required.rc == 1): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/usr/share/ansible/roles/sap-hana-preconfigure/tasks/RedHat/installation.yml': line 85, column 9, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n # inspired by https://support.ansible.com/hc/en-us/articles/201958037-Reboot-a-server-and-wait-for-it-to-come-back\n - name: restart machine if required\n ^ here\n"}

...ignoring

TASK [sap-hana-preconfigure : waiting for server to come back] *****************

fatal: [dhcp168.coe.muc.redhat.com]: FAILED! => {"msg": "The conditional check 'sap_hana_preconfigure_reboot_after_update == true and sap_hana_preconfigure_register_reboot_required.rc == 1' failed. The error was: error while evaluating conditional (sap_hana_preconfigure_reboot_after_update == true and sap_hana_preconfigure_register_reboot_required.rc == 1): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/usr/share/ansible/roles/sap-hana-preconfigure/tasks/RedHat/installation.yml': line 92, column 9, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n - name: waiting for server to come back\n ^ here\n"}

PLAY RECAP *********************************************************************
dhcp168.coe.muc.redhat.com : ok=11 changed=1 unreachable=0 failed=1 skipped=2 rescued=0 ignored=1
422 Client Error: Unprocessable Entity

This is required for SAP HANA.

This will ensure fix for the TCPSACK fix will be installed when using RHEL 7.7 once it is certified for SAP HANA. See also SAP note 2812427 and https://access.redhat.com/solutions/4302501 .

As soon as you don't support ansible 2.6 anymore you can move to reboot module

would become:

- name: Reboot if required
  reboot:
    reboot_timeout: "{{ sap_hana_preconfigure_reboot_timeout }}"
  when: sap_hana_preconfigure_reboot_after_update == true and sap_hana_preconfigure_register_reboot_required.rc == 1

identical tasks, when used in SAP notes for different RHEL releases (example: 2292690 for RHEL 7 and 2777782 for RHEL 8), should be moved to a generic directory (e.g. tasks/RedHat/generic) and imported in the sapnotes/xxx/aaa.yml files.

Advantage: With each SAP notes paragraph in a separate file, it should be easier to compare the System Roles with the SAP notes, for example during bug fixing. The including file then just contains the import statements, reducing clutter.

This is already done in sap-preconfigure.

Checking for:
/rhel-{{ ansible_distribution_major_version }}-server-e[4u]s-rpms/ {a++}
/rhel-sap-hana-for-rhel-{{ ansible_distribution_major_version }}-server-e[4u]s-rpms/ {a++}
does not support ppc64le. Also it does not cover RHEL 8.

Integration of check if reboot is required (7.2) and check if reboot is required (7.3+) are not compatible with each other.

Here are two variables registred with one name. This will not work, because i got everytime the output (variable reboot_required) of the last task, and for a rhel 7.4 system this is a empty variable.
(Changed the register variable to reboot_required_72 before, but this is only much more complex.)

Also i commented the broken passage. Not tested with a rhel 7.2

Although GRUB_CMDLINE_LINUX_DEFAULT limits the scope of the grub modification to normal boot and GRUB_CMDLINE_LINUX is valid for normal and recovery boots, let's keep as closely as possible to the SAP notes.

the command needs-rebooting is not executed on RHEL 8, hence if you set the variable sap_hana_preconfigure_reboot_after_update == true
the playbook fails.
Required fix:

• add yum-utils to the list of required packages (not installed by default)
• change the when statement to ansible_distribution_major_version >=7 in task "check if reboot is required (7.3+)"

See also linux-system-roles/sap-preconfigure#62 .

https://github.com/linux-system-roles/sap-hana-preconfigure/blob/master/tasks/RedHat/generic/disable-thp.yml#L18
currently if you modify the grub config the system does not get rebooted. I suggest the reboot should be moved to the end of the role and to run meta: flush_handlers before reboot. This could also mean we'd need to move some of the checks to after the reboot, I only skimmed over them.

Hi,
I think we should add support for RHV/oVirt to this role. They should be configured according to the red hat guide: https://access.redhat.com/sites/default/files/attachments/sap_hana_on_rhv_kvm_4.2_resource_guide_1.pdf

If I am not mistaken the only thing missing is the custom tuned profile: sap-hana-kvm-guest (maybe it would be a better idea to get that profile into the tuned packages and just activate it here)

... to not use the role against a production SAP HANA system.