The maxDepth and minDepth attributes of includeall don't work as documented about liquibase HOT 4 OPEN

@MalloD12 could you take a look at this issue?

from liquibase.

Hi @jasonlyle88 ! if I'm right you contributed this code... could you add your view about it? Steve is the maintainer of the groovy extension and is updating it to use latest liquibase version and stumbled upon this issue.

from liquibase.

I'll find some time to take a look at this.

First thoughts being I know this is working to an extent... because I'm using it. However, that doesn't mean all implementations are working correctly.

Addressing the issues raised just based on memory and a cursory glance at related code:

1. I'll have to actually dig into this one.
2. This is very possible. This behavior was changed right after my wife had her baby and I didn't dig too much into it. It could be that one implementation works one way and another implementation works another.
3. The maxDepth does work, it is actually handled by the walkFileTree method that uses the fileVisitor that contains the code in question. For that reason, the fileVisitor doesn't need to handle the maxDepth. The maxDepth in this case is based off the basePath/startPath, making a plausible argument that issue 1 is truly and issue and needs to be addressed.

I'm actually using the last two weeks of my parental leave right now before my daughter turns 1 (have NO idea where the time has gone!) so I'm not sure if I'll get around to this right away.

from liquibase.

Thanks @jasonlyle88 ! I'll be on PTO until next week but did not want to let Steve waiting anymore.

from liquibase.