listen-moe / browser-extension Goto Github PK

Please describe the problem you are having in as much detail as possible:
Addon can't be controlled from a private browsing window.

Further details:
When clocking the addon icon from a private browsing window, it's completely broken and can't be controlled. It's stuck on "Loading..." and play button is set as if it were playing: user can't do anything.

• Browser version: Firefox Nightly
• Operating system: Archlinux
• Priority this should have – please be realistic and elaborate if possible: low. this is an annoying bug, but you still can use it.

Please describe the problem you are having in as much detail as possible:
On browser start, and while the "Autostart while browser start" is off, listen.moe addon is not playing (no sound), but displaying the pause icon, and sending notification of the sound currently playing and the following ones. To stop that, the cause button needs to be clicked not once, but twice. This happens on most of the starts.

Further details:

• Browser version: Firefox 84.0.2
• Operating system: Linux, mac
• Priority this should have – please be realistic and elaborate if possible:

Just a simple request - could you add an explicit LICENSE file of some kind, at all?

MIT, GPL, Creative Commons NonCommercial with Attribution if you want especially people linking back, but an explicit license would make this saner for anyone else to work on/contribute to.

Thanks!

(Could be helpful, if you're not already familiar with this stuff: http://choosealicense.com/)

It's a little annoying having it notify on every song during an event if it's not actually playing.

Would be cool if instead of setting up shortcuts (which might interfere with things, and you have to remember them) volume could be controlled by clicking the extension icon, hovering over volume slider, and scrolling up/down with a mouse.

Yes. You could just click it, but my OCD wants to do it in 5% increments, not just visually : D

A workaround I have been using is to click on the volume slider ball, and then click keyboard arrow.

Priority: low

Please describe the problem you are having in as much detail as possible:
My play/pause button on my keyboard controls the media controls for Windows 10. The "song name" shown is the chrome extension name.
Further details:

• Browser version: Microsoft Edge (Chromium) 80.0.361.109 (Official build) (64-bit)
• Operating system: Windows 10 64-bit 1909
• Priority this should have – please be realistic and elaborate if possible:
  Low- don't know if this is a bug specific to Edge Chromium.

Is it possiable to add play/pause hotkey?!

Discovered 04/12/2017, during normal usage conditions. Nothing special, but not working as usual

In few conditions, the buttons / volume bar / links become fully insensitive to clicks.

Conditions where it happens

• Have a triple monitor setup
• Windows 10 (fully updated)
• Chrome window opened on the right screen (you can have other Chrome windows, and inside them, extension will be working fine)

I'll try to investigate more with that issue, trying to find some circumstances pattern

It looks like the addon used to support Firefox previously but stopped to some times ago.
However, Firefox is now supporting Webextensions as their exclusive standard and provide a very close support, close to some small exceptions. Those should be documented on https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities

about:debugging in Firefox is only reporting a few bunch of errors/warnings:

Reading manifest: Error processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.
Reading manifest: Error processing version_name: An unexpected property was found in the WebExtension manifest.
Reading manifest: Error processing options_page: An unexpected property was found in the WebExtension manifest.

Regarding first line, background.persistent isn't currently supported by Firefox. It looks like setting this to false result in having events pages rather than background. Here this is a warning because Firefox does not support events one while it does for background.
Sources:

• https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/background
• https://bugzilla.mozilla.org/show_bug.cgi?id=1282971
• https://bugzilla.mozilla.org/show_bug.cgi?id=1253565#c0

Second line seems to refer to a manifest attribute not part of the spec as of now and also seems to be a warning: https://bugzilla.mozilla.org/show_bug.cgi?id=1380219

Last line is a bit more tricky.
Spec is still talking about options_page (https://browserext.github.io/browserext/).
However, Google deprecated this in favor of options_ui with Chrome 40 (https://developer.chrome.com/extensions/optionsV2) and Mozilla is also supporting this last one, but without the chrome_styleattribute.

I also submitted the .crx extension on www.extensiontest.com
Here's the result:

{
  "compat": [],
  "errors": [],
  "warnings": [
    {
      "message": "Unsafe assignment to innerHTML",
      "locations": [
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/sweetalert2.min.js",
          "line": 1
        },
        {
          "file": "js/jquery-3.1.0.min.js",
          "line": 2
        },
        {
          "file": "js/jquery-3.1.0.min.js",
          "line": 3
        },
        {
          "file": "js/jquery-3.1.0.min.js",
          "line": 3
        }
      ]
    }
  ]
}

The other file is minified and my knowledges in JavaScript probably are a bit low to take care about it.

Finally, it's worth noting Edge does also allow WebExtensions now, but with some spcificities either.

PS: I tested the addon through the about:debugging tool by loading it as temporary addon (I didn't packaged it). It seemed to work correctly. I didn't have the notifications, but this could be caused by the fact this mode doesn't ask for permissions. This can be the cause of this missing feature.
For what it's worth I tested on Firefox Nightly (59), but stable channel currently on 57 shouldn't have many differencies on what I listed.