Giter VIP home page Giter VIP logo

Comments (3)

guacs avatar guacs commented on June 23, 2024 1

since we would have to add another generic parameter to Request.

I'd like to push back a little bit on this. Request[UserT, AuthT, StateT] is already not great UX, IMO. Maybe, once middleware can participate in DI, the need to access these things via a Request object goes away??

Agreed. I really like the idea of being able to inject the session as part of DI. Then we should just hold back on this until v3.

from litestar.

peterschutt avatar peterschutt commented on June 23, 2024

since we would have to add another generic parameter to Request.

I'd like to push back a little bit on this. Request[UserT, AuthT, StateT] is already not great UX, IMO. Maybe, once middleware can participate in DI, the need to access these things via a Request object goes away??

from litestar.

provinzkraut avatar provinzkraut commented on June 23, 2024

Maybe, once middleware can participate in DI, the need to access these things via a Request object goes away??

Yes, that's more reasonable. Injecting sessions from e.g. a session-plugin that provides the necessary middlewares/DI providers seems more practical.

from litestar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.