liu071900 / ftp4go Goto Github PK

What steps will reproduce the problem?
1. call the ftp.Size() method on a file

What is the expected output?

An int

What do you see instead?

A panic (slice bounds out of range) at client.go:404

Please provide any additional information below.

Fix to line 404...

size, _ = strconv.Atoi(strings.TrimSpace(response.Message))

What steps will reproduce the problem?
1. Call ftp.Size("this_file_doesnt_exist")

What is the expected output?

An error message.

What do you see instead?

A panic in client.go:402

Please provide any additional information below.

Fixed with...

401:  response, err := ftp.SendAndRead(SIZE_FTP_CMD, filename)
402:  if err != nil {
403:     return
494:  }

What steps will reproduce the problem?
1. The sample on the project home page fails to compile

You can fix the sample by changing the line to have a ,""
empty string at the end:

        //connect
        _, err := ftpClient.Connect("127.0.0.1", ftp4go.DefaultFtpPort, "")

Hi,

When using the FTP.UploadFile method and given it a none existing localpath, 
you'll get a panic instead of an error "open ...: no such file or directory". 
It is trying to close the file pointer even when the file couldn't be opened in 
the first place.

Thank you for your time developing this package, you're AWESOME!

Djuke

Hello, i missed this method, and added it in my own copy of ftp4go :

// SetTimeout sets the timeout for command and data transfers, in milliseconds.
// (added by [email protected])
func (ftp *FTP) SetTimeout(msecs int64) {
    if msecs >= 0 {
        ftp.timeoutInMsec = msecs
        if ftp.conn != nil {
            ftp.conn.SetDeadline(getTimeoutInMsec(ftp.timeoutInMsec))
        }
    }
}

Having this in the official package seems like a good idea, all the more 
because the default of 1000 ms is really short!

Thanks for your efforts in developing this package, i have a need for it, and 
it seems to work fine :)
Do you plan on adding TLS support any time soon?


Erwin
[email protected]