liz-peng / p5.polar Goto Github PK

I am trying to create some squares and it is failing with a typeError:

polarSquares(8,4,160);

p5.Polar.min.js:2 Uncaught TypeError: this.square is not a function

It fails in PolarSquare:

I am not sure what the cause of this could be, I would appreciate some help about it

I love the p5.Polar library! I've been enjoying using it to make radially symmetric designs.

In my use, I added a function to allow for user-created shapes and designs in addition to the existing geometric ones (triangle, square, octagon, etc).

The function I added to my fork of this repo is here

Should I submit a PR for this, do you think? It's a slight departure from the existing design of the library, but it's something I could see people getting some benefit from as well, similar to the existing library's support for callbacks.

Hey Liz! the introduction of shiftRotate in 7fdf013 seems to break everything? It's being called without a reference to this but it's stored in the prototype so this is necessary. I guess just putting this in front of every call might fix things? I haven't looked all the way through the file and am unsure...