Hi,

here is a simple patch to do this:

--- a/implementation.js
+++ b/implementation.js
@@ -4,7 +4,7 @@

 var isES5 = typeof Object.defineProperty === 'function';

-var hasProto = [].__proto__ === Array.prototype; // eslint-disable-line no-proto
+var hasProto = Object.getPrototypeOf([]) === Array.prototype

 if (!isES5 || !hasProto) {
        throw new TypeError('util.promisify requires a true ES5 environment, that also supports `__proto__`');
@@ -75,7 +75,7 @@
                });
        };

-       promisified.__proto__ = orig.__proto__; // eslint-disable-line no-proto
+       Object.setPrototypeOf(promisified, orig.__proto__);

        Object.defineProperty(promisified, kCustomPromisifiedSymbol, {
                configurable: true,

Not just as the default function. So we could import it as the named function. Yes I saw the shim thing, but that's the different story.

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

This is basically copy-pasted from node core, so it probably works? It needs tests ASAP tho.

const util = require('util');
const exec = util.promisify(require('child_process').exec);

async function lsExample() {
  const { stdout, stderr } = await exec('ls');
  console.log('stdout:', stdout);
  console.log('stderr:', stderr);
}
lsExample();

It is my understanding that the above example does not work.

│   ├─┬ [email protected]
│   │ ├─┬ [email protected]
│   │ │ └── [email protected]
│   │ └─┬ [email protected]
│   │   ├── [email protected] deduped
│   │   └─┬ [email protected]
│   │     ├─┬ [email protected]
│   │     │ ├── [email protected] deduped
│   │     │ ├── [email protected]
│   │     │ └─┬ [email protected]
│   │     │   └── [email protected] deduped
│   │     ├── [email protected]
│   │     ├─┬ [email protected]
│   │     │ └── [email protected] deduped
│   │     ├── [email protected]
│   │     ├── [email protected]
│   │     ├─┬ [email protected]
│   │     │ └── [email protected] deduped
│   │     ├── [email protected]
│   │     ├── [email protected] deduped
│   │     ├─┬ [email protected]
│   │     │ ├── [email protected] deduped
│   │     │ └── [email protected] deduped
│   │     └─┬ [email protected]
│   │       ├── [email protected] deduped
│   │       └── [email protected] deduped

This seems massively overkill for util.promisify which already depends on ES5 and global.Promise ;

We should be able to remove all these dependencies and make this a lightweight module.

so that we can destructure the same as we would using "util":

const {promisify} = require('util');

const {promisify} = require('util.promisify');

Node 7.7.4
Windows 10

functions that returns true are rejected?

require('util.promisify/shim')();
const util = require('util');

const exists = util.promisify(fs.exists); 
async function test() {
    await exists("path_to_an_existing_file");
}
test();

(node:109376) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): true

Hey,

Thanks for the polyfill!

util.promisify doesn't only add the custom promisify argument - it also patches the standard library methods with a custom promisification property. This is useful for things like fs.exists.

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The dependency es-abstract was updated from 1.17.4 to 1.17.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

es-abstract is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Include the es6-shim in tests (after #1) so that 0.10/0.8 has a Promise to work with.

const promisify = require("util.promisify")
var sqlite3 = require("cross-sqlcipher")
var db = new sqlite3.Database("testdb")
const exec = promisify(db.exec)
var promise = exec("PRAGMA KEY=\"ABCDEFG\"")

(node:13872) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Illegal invocation

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency auto-changelog was updated from 1.16.2 to 1.16.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

auto-changelog is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Delete the first of the following two lines?

util.promisify = polyfill;
Object.defineProperty(util, 'promisify', { value: polyfill });