llemonduck / dps-calculator Goto Github PK

Using the vorkath preset using void range my dps is listed as 6.588 with or with the salve amulet.

I'm using a gif, as still images of the dps screen were identical.

equipment:

skills:

npc stats:

prayer:

Tried to equip every color chinchompa. but the "weapon mode" dropdown did not show anything, this means DPS cannot be calculated for chinchompas

Won't be included in initial release. May be added later.

This ticket serves as both a reminder and a notice to players wondering whether it will be added. Please do not reply to this thread asking for it to be added, but do add a 👍 react to it if you would like to see it.

Could you add the ability to simply write for example fury instead of amulet of fury? Same for other fields in enemies etc.

The below input results in incorrect output:

Input:

Output:

I have my setup with magic short bow(i) using broad arrows on a slayer task at 77 range and it says DPS is 6.499 and max hit is 29 but max hit should be 29 and DPS should be way less.

Title

there is no way to calculate the dps with the dharoks set effect

Both weapons have the following ability:

It deals 33% bonus damage against all kalphites and scabarites, and has a 1/51 chance of puncturing a hole in their exoskeleton, dealing triple damage. When the special effect occurs.

screenshot below of my stats right after using special - notice strength is only boosted by 15 instead of the suggested 25

Getting this error with the plugin. If I uninstall and reinstall I still get it.

2022-06-16 14:05:07 [pool-3-thread-1] WARN n.r.c.e.ExternalPluginManager - Unable to start or load external plugin "dps-calculator" java.lang.NoClassDefFoundError: com/google/inject/multibindings/Multibinder at com.duckblade.osrs.dpscalc.calc.DpsComputeModule.configure(DpsComputeModule.java:49) at com.google.inject.AbstractModule.configure(AbstractModule.java:62) at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340) at com.duckblade.osrs.dpscalc.plugin.DpsCalcPlugin.configure(DpsCalcPlugin.java:28) at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340) at net.runelite.client.plugins.PluginManager.lambda$instantiate$6(PluginManager.java:583) at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340) at com.google.inject.spi.Elements.getElements(Elements.java:110) at com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:138) at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:104) at com.google.inject.internal.InjectorImpl.createChildInjector(InjectorImpl.java:232) at com.google.inject.internal.InjectorImpl.createChildInjector(InjectorImpl.java:236) at net.runelite.client.plugins.PluginManager.instantiate(PluginManager.java:585) at net.runelite.client.plugins.PluginManager.loadPlugins(PluginManager.java:394) at net.runelite.client.externalplugins.ExternalPluginManager.refreshPlugins(ExternalPluginManager.java:319) at net.runelite.client.util.RunnableExceptionLogger.run(RunnableExceptionLogger.java:41) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: com.google.inject.multibindings.Multibinder at java.base/java.net.URLClassLoader.findClass(Unknown Source) at java.base/java.lang.ClassLoader.loadClass(Unknown Source) at java.base/java.lang.ClassLoader.loadClass(Unknown Source) ... 22 common frames omitted

.

Right now only autocasting is supported. Manual casting would increase the dps slightly and it would allow the selection of spells and magic weapons which can't be autocast (Ex: staff of fire and superior demonbane)

If you enter any ranged crossbow setup against a kurask, with amethyst broad bolts equipped, it will show a DPS of 0. Switching to normal broad bolts shows an expected DPS value.

As Title, Torva is missing from the equipment, unless I am blind. Please add, thank you.

The "load equipment from client" feature is super handy. What would be even more handy would be if I could check a box ("keep synced" or something), that would keep your gear in sync while equipping different sets of items.

I find myself comparing the max hit of different sets of gear quite frequently, and it's quite a few clicks to update my gear, go to the equipment tab, load new gear from the client, and then swap back to home to view the dps/max hit deltas.

The slayer staff is missing some spells, which can be autocast. Notably, all spells from the arceuus spellbook. Possible also spells from other spellbooks.

Need ability to select prayers for use and factor the boosts into the DPS equations.

Please fix. I pray both attack and str. Either with a change from simple to combo dropdown or just putting even more checkboxes below.

Also I had no idea prior to raising this issue what all the various prayers names are, I had to look it up specifically for this plugin.
Icons would be preferred. And/or better sorting and categorization (range/melee/magic, tier 1/2/3).

Is it possible to add in the calculation for the enemies hit rate through your armor? Would be nice to help decide your personal balance between damage and sustain

Seems the Amethyst Darts are missing when selecting which dart you have in the Toxic Blowpipe.

Could the "useful" boosts be added to the top of the preset combo box instead of sorting them here. Would make it a lot easier to quickly choose the ones you need, as it's fairly rare to need to check the dps with a normal attack potion.

Originally mentioned in #35, the ability to copy all data from one set to another would be really convenient. I primarily use this plugin to compare dps between weapons or various setups, it would be great if I could quickly copy from one set to another. This would allow me to only change the weapon and then compare each set with the other easily.

From the UI perspective, perhaps a button on the Home page that says "Copy to:" and a dropdown selector for "Set 1" "Set 2" etc

First of all, I wanted to say this is an awesome plugin and something I've been looking for for a while.

One of the biggest things missing in my opinion though is the ability to compare 2 different setups side-by-side. Personally, I think the best way to implement this would be to have another identical "Equipment" page and perhaps rename them to "Setup 1" and "Setup 2", then on the home page where it shows DPS it could show all the same information for both setups. Alternatively, you could keep it all on one equipment page with two separate tabs/sections. This makes it a lot easier to look at how much of a benefit specific changes to the gear will be without having to write the DPS down before messing with the equipment.

Quote from wiki: "Players wearing an Amulet of the damned and Ahrim's set will be able to autocast Ancient Magicks. In addition, players will hit with 30% increased damage if the spell is autocast. This effect occurs alongside the normal set effect."
I don't think the 30% increased damage is accounted for at the moment. (The wiki makes it sound like the 30% extra damage only applies when autocasting Ancient Magicks specifically, but it also works for other spellbooks, although its not calculated at all at the moment).

I'm also pretty sure that multiple sources of damage boosts are being calculated wrong at the moment (should be multiplicative).
I hope I can explain.

My setup: Full Ahrim's (5% from the staff), Amulet of the Damned (30% as stated in the quote), Mark of Darkness + Superior Demonbane (25% damage boost while under effect of Mark of Darkness).
I have been shooting black demon's for a while and my max hit was 39. Superior Demonbane's base max is 23.
So: 23 * 1.05 = 24.15 -- 24.15 * 1.30 = 31.395 -- 31.395 * 1.25 = 39.24375
If i calculate it by adding up the damage boosts I get 23 * 1.6 = 36.8 (but i have hit a 39)

The max hit shown by the plugin (taken in account that the 30% damage increased from Ahrim's + damned isn't calculated) is 29.
To get to 29 it adds up the damage boosts and multiplies it by the base max hit (23 * 1.3 = 29.9).
If its calculated multiplicative it is 23 * 1.05 = 24.15 -- 24.15 * 1.25 = 30.1875.

I'm just trying to help, I hope it does!
Very awesome plugin, thanks alot!

Would like options to search your bank and provide a listing of the best gear available.

Should include settings for limiting consumable use (potions or not/tbp ammo limits/weapon charge limits), minimum prayer bonus/time, etc.

It shows the hit chance as just over 50% in max gear, and in doing so also displays the wrong DPS. Downgrading from a twisted bow to a dragon hunter crossbow cranks the hit chance up to 70%, and DPS to even higher than that of a twisted bow, without even equipping anything in the shield slot.

It would be convenient for the plugin to be able to remember Set loadouts from previous instances. I usually have a few cookie cutter builds I then compare against either each other or slightly tweaked variants of themselves, depending on target. Having these preloaded on-hand would be convenient, as at the moment I find myself often inputting the same base loadout(s) over and over to compare as a basis. Thanks!

All the staves in The Gauntlet have a set max hit that's independent level and spell (was tested during Leagues).

Currently, the plugin requires a spell for these powered staves, instead of treating them like a trident.

Please refer to my comment below for more info about the general problem. This post was written before I found the attributes bug and details how I was alerted to it.

Original post:

A buddy of mine has confirmed that his max hit on revenant demons is 49 with the welfare gear listed below. The DPS calculator only lists a max hit of 41, which very likely also results in incorrect DPS. Below you can find Bitterkoekje's calculator with the exact same gear my friend used as set 1. The max hit of set 1 seems to be correct for Bitterkoekje's, but incorrect for the plugin. The same is probably the case for the DPS.

Bracelet of ethereum doesn't have any stats or damage enhancing effects, so no gloves.

Calculated DPS with salve (e) was lower according to the plugin IIRC, so I don't expect it to not apply the avarice boost (unless it also doesn't apply the salve boost). However, I haven't really looked into that.

Also tried some different welfare gear (MSB + rune arrows) and it seems like there's also a difference between Bitterkoekje's and the plugin. Please refer to set 2 and ignore set 1, since this is the same as the first one, but with slash instead of crush.

I haven't checked different revenants or gear setups than the one mentioned above.

https://github.com/runelite/runelite/wiki/Attack-Styles
No need to make us manually set it.

Should have some sort of buttons for common boosts, like super combat, ranging pot, etc. Can pre-fill Skills#Boosts by using the values in Skills#Player Stats as a base if needed.

Since either the latest version (2.1.1) or the one before (2.1.0) ranged strength isn't being set correctly. It looks like the ranged accuracy value is also set to the ranged strength value, instead of actually getting the proper ranged strength value.

.

Need a way to handle item variants, like Slayer Helm recolours and such. RuneLite's ItemComposition may be a viable solution, if it does not merge imbued/enhanced variants of items to the same ID.

Instead of having the 4 buttons on Home could you have them as dropdown panels so Home is modular and not a HUB? That way you can click Prayer for example, toggle piety on and off and see Average TTK change without having to go through the rigamarol of going back and forth.

Referencing #13, gear bonuses (maybe only some?) look like they should be added up before multiplication, rather that integer-multiplied independently.

This is unlikely to be impacting calculations significantly, but is worth looking into.

Nylocas from tob missing in enemy combat stats.

Dps calculation ignores the 15% damage boost, And likely the accuracy boost too. i'm sure you're aware most items that have special effects their calculations are not included, beyond that this is a really great addition.

I would like to add a new panel that can show the player's live DPS calculation, based on what they are attacking/wearing/praying. Should appear similarly in-game to the Max Hit Plugin, but with extended statistics.

Will likely require a good rework and cleaning up of the internal DPS calculation structures in order to implement cleanly.

Need calculation support for:

• Dharok's ignoring Damned (done in cacb19d)

The lower a player's remaining hitpoints are, the higher maximum hit the player can inflict with the set equipped. The full set, including Dharok's greataxe, must be equipped to yield the special effect.
When wearing the full Dharok's set, the following damage modifier is applied to a player's hit after the damage roll:

• Verac's (done in 64f3cd6)

Standard: Attacks have a 25% chance of having a guaranteed hit, ignoring accuracy. There is also a guaranteed bonus of one extra damage, making it impossible to hit 0 when the effect occurs.
Damned: When a full set of Verac's and the Amulet of the damned are equipped, the wearer receives an additional +7 Prayer bonus. Thus, it would make +28 Prayer bonus overall.

• Karil's with Damned (done in 64f3cd6)

Players wearing Karil's set and an Amulet of the damned will have a 25% chance of dealing two hitsplats. The second hitsplat will deal half the damage of the first hitsplat.

• Ahrim with Damned (done already)

Players wearing an Amulet of the damned and Ahrim's set will be able to autocast Ancient Magicks.

Barrows gear stats have picked up the values from the fully depleted variants (all 0s) instead of the correct stats.

Discovered as part of #8

All I can say is i'm hitting 50's and it's saying max hit 44

manually entered that i'm on task, manually toggled that and vampyre option, no difference

PS: thanks for the plugin

The smoke battlestaff provides a 10% increase in accuracy and damage when casting spells from the standard spellbook.

This buff is not included in the plugin's calculations. For example, the output of the plugin shows the same DPS for both the smoke battlestaff and the fire battlestaff, when smoke should have a higher attack roll + max hit.

I'll look into the code in sometime in the next few weeks and see what changes this might require.

Plugin description on the plugin hub was left as "An example greeter plugin"

Fixed in 2b5e2ee.

You have the super ranging potion but not the super magic potion

Can we get this working? I compared d'hide to void ranger set, no difference in damage.