lloydtorres / stately Goto Github PK

For example, if the currency name is "Quill", the name shows up as "Quillses".

This is because the string is being put through the pluralization process twice.

Dear Developer!

My name is Alejandro Mazuera-Rozo, I am a PhD Student at Universidad de los Andes, and at Università della Svizzera italiana. I am part of a research on the usage of network libraries within Android apps. As result of this we identified some code locations that might have network related problems.

In this case, we address the code locations that are related to a potential issue while scheduling reliable asynchronous tasks. As you might know, WorkManager is an API that makes it easy to schedule such tasks which are expected to run even if the app exits or the device restarts. The WorkManager API is a suitable and recommended replacement for all previous Android background scheduling APIs, including FirebaseJobDispatcher, GcmNetworkManager, and, in this particular scenario, Job Scheduler.

In order to address this issue we recommend you to visit:

1. https://developer.android.com/topic/libraries/architecture/workmanager
2. https://android-developers.googleblog.com/2019/11/unifying-background-task-scheduling-on.html

Potential Code Location missing WorkManager

If you have an Android version lower than Lollipop, dialogs are shown with the Holo theme, which contrasts with the app's Material Design. Fix this to make the app more consistent.

Dear Developer!

My name is Alejandro Mazuera-Rozo, I am a PhD Student at Universidad de los Andes, and at Università della Svizzera italiana. I am part of a research on the usage of network libraries within Android apps. As result of this we identified some code locations that might have network related problems.

In this case, we present the code locations that are related to a missing validation of the response code when performing network operations. When you make an HTTP request, your application should validate the response status code before manipulating it, otherwise it could cause misbehaviour within the app.

In order to address this issue we recommend you to visit:

1. https://developer.android.com/training/volley/requestqueue

Potential Code Location missing Response Code validation

1. When a new request is being added to the Volley queue:

2. There is no previous validation of statusCode when assigning response inside the onResponse() method
   

   stately/Stately/app/src/main/java/com/lloydtorres/stately/census/TrendsActivity.java

   Lines 227 to 236 in 1992d85

   	NSStringRequest stringRequest = new NSStringRequest(getApplicationContext(),
   	Request.Method.GET, targetURL,
   	new Response.Listener<String>() {
   	CensusHistory censusResponse = null;
   	@Override
   	public void onResponse(String response) {
   	Persister serializer = new Persister();
   	try {
   	censusResponse = serializer.read(CensusHistory.class, response);

As soon as the Crashlytics removal is merged, the last thing to get Stately onto F-Droid is to add the necessary images/metadata/screenshots.
See: https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#in-the-applications-source-repository
Those additions could be used by @lloydtorres to also publish on the Google play store.
There are two options, namely tripple-T and fastlane. I personally prefer fastlane.
Since I personally can't access my main dev machine, I can't provide the necessary patches in the next few days. @lloydtorres I couldn't find anything in the repo, do you have some kind of banner already?

A link like http://www.nationstates.net/nation=greater_tern posted by a user opens in the browser instead of within the app.

In Stately 1.1.0, BBCode styling can easily break if the hierarchy isn't correct (e.g. [b][u]whatever[/b][/u]). There is also no support for [color] and [spoiler], both of which can be used in the region factbook, RMB and/or WA (ref: The Complete List of NSCodes). Finally, raw links posted by a user cannot be interacted with. Fix this.

Dear Developer!

My name is Alejandro Mazuera-Rozo, I am a PhD Student at Universidad de los Andes, and at Università della Svizzera italiana. I am part of a research on the usage of network libraries within Android apps. As result of this we identified some code locations that might have network related problems.

In this case, we address the code locations that are related to a potential issue concerning a missing validation of the response content against expected values. It would be a good practice to validate whether external server’s responses are correct, use validation rules.

In order to address this issue we recommend you to visit:

1. https://developer.android.com/training/volley/requestqueue

Potential Code Location missing Response Content validation

1. When a new request is being added to the Volley queue:

2. There is no validation when assigning response inside the onResponse() method
   

   stately/Stately/app/src/main/java/com/lloydtorres/stately/census/TrendsActivity.java

   Lines 227 to 236 in 1992d85

   	NSStringRequest stringRequest = new NSStringRequest(getApplicationContext(),
   	Request.Method.GET, targetURL,
   	new Response.Listener<String>() {
   	CensusHistory censusResponse = null;
   	@Override
   	public void onResponse(String response) {
   	Persister serializer = new Persister();
   	try {
   	censusResponse = serializer.read(CensusHistory.class, response);

Stately doesn't seem to support Factbooks or Dispatches, making it nearly unusuable for roleplay in my region.

This review.

"I feel the login screen could be a bit more responsive though. Like, when I tap the first field (nation name), my keyboard covers up the field. I can by this so it isn't awful."

Test the login screen for smaller screens and improve it.

I recently changed my password. And it works fine on the website. But if i try to login with that same combination on the app it says "invalid nation name or password".

I tried to delete the app data and to reinstall the app but the problem persists. Does someone have an idea how to solve that problem?

Same behaviour with another nation i yesterday created which i never used with stately. Login on Nationstaates works but on stately not.

I'm using Keepass2Android could this be an problem?

Dear Developer!

My name is Camilo Escobar, I am a PhD Student at Universidad de los Andes, Colombia. I am part of a research on the usage of network libraries within android apps. As a result of this we identified that there is a missing validation of network connection within the project since some network operations are being performed in the application.

As you might know, a device may not be connected to a network. In order to get such information see https://developer.android.com/reference/android/net/ConnectivityManager. Therefore it is recommended for the app to identify whether the device has a network connection available before performing a network operation.

In order to address this issue we recommend you to visit:

1. https://developer.android.com/training/basics/network-ops/managing
2. https://developer.android.com/reference/android/net/ConnectivityManager.NetworkCallback

Note: public NetworkInfo getActiveNetworkInfo () returns details about the currently active default data network. When connected, this network is the default route for outgoing connections. You should always check NetworkInfo#isConnected() before initiating network traffic, it requires Manifest.permission.ACCESS_NETWORK_STATE. However, isConnected() was deprecated in API level 29, one should instead use the ConnectivityManager.NetworkCallback API to learn about connectivity changes, to be more specific the onAvailable() method.

On the Google Play Store, Stately is marked as R18+ for 'References to Sexual Violence, Online Interactivity, Users Interact'. I believe this was chosen incorrectly and should probably be fixed, because it blocks any minors from downloading the app.

Would it be possible to get this into F-Droid?