lmichaelis / computer-simulation Goto Github PK

I have some other suggestions I was thinking of looking at too:

Add decimal output

class _OUTInstruction(_Instruction):
    def process(self, computer):
        print('[OUT] %s - %03d' % (computer._a, int(computer._a, 2))) # include decimal in output
        computer._pc += 1

    def get_basename(self) -> str:
        return 'OUT'

Looks like negatives are not handled correctly. But maybe I am still having to learn more about binary.
This program should load 10 into A, subtract 20 from A and output -10 (11110110 in twos compliment)

➜  Computer-Simulation git:(temp) ✗ cat negative.prg
LDA 15
SUB 14
OUT 0
HLT 0

14: 20
15: 10

but when I compile and run this, I get:

➜  Computer-Simulation git:(temp) ✗ ./cpu.py negative.prg.bin
Loglevel: INFO
[OUT] 11111111 - 255

It works perfectly in cases where the result of the SUB call is > 0.

I will see if there is anything I can do to sort that out. It will mean learning how you structured your code a bit more. But it might be fun...