Giter VIP home page Giter VIP logo

blockchain-developer-bootcamp-final-project's People

Contributors

lnikolenko avatar

Stargazers

 avatar

Watchers

 avatar

blockchain-developer-bootcamp-final-project's Issues

Initial feedback

Well done on getting to the end of the course.

Some tips and considerations for the future:

  1. You could have included the circuit breaker design pattern in your design choices as you did implement it (nicely done)
  2. Remove the floating pragma ^ from the pragma statement to avoid potential compiler issues - fixing this is a good idea
  3. Unless I misread the contract, you are already sending the ETH to the country when the initial transaction is created, the contract isn't providing an escrow service. Consider keeping track of the transaction amount without sending it, and when you confirm it you then have a withdraw (pull vs. push pattern) for the end user to retrieve their funds.

I really liked the UI and the transaction views - a very nice touch.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.