Giter VIP home page Giter VIP logo

react-address-autocomplete's People

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

react-address-autocomplete's Issues

Selecting an address using a keyboard.

We recently conducted user testing on one of our websites and encountered an issue that appears to affect the accessibility of the select component. During form navigation, some test users utilized the 'tab' key to move from one element to another. However, when they attempted to select their address from the Lob autocomplete, they were unable to tab to the address option they wanted to use. Instead, they were redirected from our site to the Lob website. (See gif below)

After researching the code-base, I found intentional window location changes. Is there any way to prevent redirection? The redirect happens within the handleChange function which is used in the onChange event.

Based on the comments, it seems that the onChange event is intentionally defined after the user has supplied properties to avoid any unintended damage to the functionality. Is there a way to configure the component so that users can select their address using their keyboard?

Recording_2024-03-26_at_15 08 16

Typescript support?

Hi guys, is there any way to enable typescript support or do you guys think it is not a thing coming soon?

Screenshot 2023-09-27 at 15 14 04

and the good ol' npm i --save-dev @types/@lob/react-address-autocomplete nor npm i --save-dev @types/lob__react-address-autocomplete does work.

when international address is verified, the country code key in the form state variable is not set

See https://github.com/lob/react-address-autocomplete/blob/main/src/AddressForm/AddressFormInternational.js#L85

Steps to reproduce:

  1. Add AddressFormInternational component
  2. Completely fill out a valid non-US address, then make Address Line 1 something fake (eg: 123 fake st)
  3. Submit the form
  4. Receive error
  5. Update Address Line 1 with the valid value
  6. Submit the form
  7. Receive error:

Uncaught (in promise) Error: Expected countryCode to be of type string
at validateArguments (verify.js:36:1)
at verifyInternational (verify.js:89:1)
at handleSubmit (AddressFormInternational.js:78:1)

Any thoughts on a fix or workaround? Thanks

Input not updating selected value on mobile

When selecting an address in mobile browsers (and even in the mobile emulation on desktop browsers) the value is not updated with the selected one. Everything else seems to be working correctly. Adding blurInputOnSelect={false} to the Autocomplete component fixed the issue, but I'm not entirely sure why.

vh5vng0EZn

After adding blurInputOnSelect={false}:
iv4CdvYgjq

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.