Giter VIP home page Giter VIP logo

Comments (8)

andrerocker avatar andrerocker commented on September 26, 2024

we know that possibility to use request.host but this is not a good pratice, and can cause security issues.

from cassette.

ricardotealdi avatar ricardotealdi commented on September 26, 2024

We could add multiple hosts in the config.yml and then we could use the request.host as the service for validation, but verifying if the service is in the config.yml.

WDYT?

from cassette.

rhruiz avatar rhruiz commented on September 26, 2024

suggestions:

  • build a more specialized controller filter for this use case
  • provide a separate configuration entry for the "alternative" services so current configs don't break

from cassette.

andrerocker avatar andrerocker commented on September 26, 2024

@ricardotealdi This can be a cool approach, we can auto detect the service key value type, and assume a default beheviour.

from cassette.

fabioperrella avatar fabioperrella commented on September 26, 2024

+1

from cassette.

fagnerpereira avatar fagnerpereira commented on September 26, 2024

When there are multiple hosts actually the cache doesnt work, for example:
Im authenticating with first host and generate some ticket, if i try to authenticate again with the same ticket but another host the ticket will be valid cause its in the expire time.

from cassette.

ricardotealdi avatar ricardotealdi commented on September 26, 2024

@fagnerpereira Great point! There is a bug on the ticket caching. Even if we implement something to allow for multiple hosts, the ticket caching won't validate a different service/host.

from cassette.

andrerocker avatar andrerocker commented on September 26, 2024

The ticket just be valid with our service, the cache key will should be a hash of key+service :p

from cassette.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.