locaweb / cassette Goto Github PK

As @fabioperrella pointed out in a comment that Github destroyed, we need tests for the NullStore cache and for the cache selection when active support is not available

PLEASE

DoD

• Compatible with lastest ruby;
• Dependencies updated and still compatible with supported ruby versions;
• Don't break any test;
• CHANGELOG updated.

We need to restore the automated testing environment

We need to guarantee the code standard and quality in tests files!

For that mission we need to install, configure and fixes the offenses of rubocop-rspec:
https://github.com/rubocop/rubocop-rspec

Thanks!

DoD

• Rubocop-rspec installed and configured;
• No offenses being reported.

Motivation
It's need to make easier to contribute to heartcheck-elixir!

Dockerizing it is a good start, it'll give a consistent and isolated environment.

We want to replace travis CI by Github actions.

You can follow the example: locaweb/heartcheck#51

DoD

• Must pass all tests in forked repo;
• Must remove travis;
• Must run only supported ruby versions.

For an app that responds for multiple hosts (e.g.: myapp.com and api.myapp.com), the Cassette::Authentication::Filter doesn't allow us to configure more than one host for the service ticket validation.

The version 1.1.4 uses before_action instead of before_filter and this change breaks the compatibility with Rails 3. I think this information needs to be written in README or in the CHANGELOG to warning users that uses old Rails versions.

When I tried to set the cache store using the gem dalli or ActiveSupport::Cache::MemCacheStore.new , I've got the error below:

# with dalli:
NoMethodError:
  undefined method `delete_matched' for #<ActiveSupport::Cache::DalliStore:0x005563ce39f828>
  .rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/cassette-1.2.4/lib/cassette/client/cache.rb:38:in `clear_st_cache!'

# with MemCacheStore
NotImplementedError:
  ActiveSupport::Cache::MemCacheStore does not support delete_matched

So I think something must be done to support Memcache store or change the Readme to say it does not support Memcache store.

wdyt?

I verified that missing gems to insurance the code quality.

That's why I suggest that, please, install the Rubycritic gem in the project.

Observation: The configured minimum score must be the first score that the gem create.

Thanks. 😃