Hi. The createLoguxCreator code has an undocumented checkEvery parameter. It affects how often the history cleanup will be started.

It was omitted on purpose, or should I add it to the LoguxReduxConfig?

Is seems that there is a problem with replacing reducer when using redux-immutable. Consider example:

import createLoguxCreator from 'logux-redux/create-logux-creator';
import { combineReducers } from 'redux-immutable';
const reducer = combineReducers({});

const createStore = createLoguxCreator({
  subprotocol: '1.0.0',
  server: 'ws://127.0.0.1:1337',
  userId: 10
});

const store = createStore(reducer);

This fails with error that ...previous state received by the reducer is of unexpected type. Expected argument to be an instance of Immutable.Collection or Immutable.Record... pointing to https://github.com/logux/logux-redux/blob/master/create-logux-creator.js#L155

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @logux/[email protected] for the project I'm working on.

I'm trying to add support for dispatching thunks to our logux store on the client side. My approach has been to use redux-thunk-fsa so that all thunks have a type and the callback is passed as the payload. However in order for my components to access the results of the executed thunks requires returning the result of the dispatch operation.

Here is the diff that solved my problem:

diff --git a/node_modules/@logux/redux/create-store-creator/index.js b/node_modules/@logux/redux/create-store-creator/index.js
index 2d77ee5..b97b2cd 100644
--- a/node_modules/@logux/redux/create-store-creator/index.js
+++ b/node_modules/@logux/redux/create-store-creator/index.js
@@ -64,9 +64,10 @@ export function createStoreCreator(client, options = {}) {
 
       prevMeta = meta
       let prevState = store.getState()
-      originDispatch(action)
+      let result = originDispatch(action)
       emitter.emit('change', store.getState(), prevState, action, meta)
       saveHistory(meta)
+      return result
     }
 
     store.dispatch.local = (action, meta = {}) => {

This issue body was partially generated by patch-package.

In Redux we have one useful guarantee: dispatch applies changes to the store synchronously. It means that we can get a new version of the state immediately after dispatching an action. But with dispatch.local or dispatch.sync it's achievable only by awaiting the result of the functions which actually kills the optimistic approach of applying changes.
I'm wondering was it an intentional design decision and if yes then what are the implications of applying changes synchronously (like in simple dispatch implementation).

Redux Toolkit is the recommended way of using (or at least start using) Redux nowadays. Redux Toolkit has its own version of createStore function called configureStore. It's a problem because logux/redux's createStoreCreator know nothing about it and there is no way to set it explicitly.

Redux's connect implores that dispatch is of type Redux.Dispatch, hence we can't use LoguxDispatch and code like this will produce errors:

connect(null, dispatch => ({
  doSomething: () => dispatch.sync({ type: 'SOME_ACTION' }) // Property 'sync' does not exist on type 'Dispatch<Action<any>>'
}))(SomeComponent)

Extracting MapDispatchToProps into separate variable with parameter type of LoguxDispatch also breaks things:

const mapDispatchToProps = (dispatch: LoguxDispatch<Action>) => ({
  doSomething: () => dispatch.sync({ type: 'SOME_ACTION' })
})

connect(null, mapDispatchToProps)(SomeComponent) // No overload matches this call

At the time I have no ideas how to solve this problem except // @ts-ignore, which is obviously bad.

One possible (but not so good) solution that comes to my mind is to export connect from @logux/redux with modified typescript signatures.

How to reproduce:

• Install Redux DevTools for Chrome
• Open this code example
• In configure-store.js on line 22 replace compose with window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose
• Get TypeError a.subscribe is not a function

This example demonstrates that in some cases logux behaves differently in different browsers.

How to reproduce:
Clone this repo https://github.com/devgru/logux-firefox-behaviour
Install packages: yarn
Run logux server: node server.js
Run web-server: yarn start
Open http://localhost:3000 in a browser.

Page will display JSON state of redux store.

Expectations:

Page behave the same way in all modern browsers.

Result:

In Chrome we will see initial store state ({someState: 1}), in Firefox and Safari we get {}. Looks like reducer is called without action and with empty state ({}).

How to work the subscription channels? Now I call this:

store.dispatch.sync(
  { type: 'logux/subscribe', channel: 'user/:id' }
)

I need to create a reducer 'logux/subscribe'? What should he do?

Why enhancer is applied like this:

https://github.com/logux/redux/blob/master/create-logux-creator.js#L148

?

When we are undoing last action and there is snapshot in stateHistory for action just before undoed, replay will fail

Steps to reproduce:

1. Create store with saveStateEvery = 1
2. Dispatch 2 actions
3. Dispatch undo for last action

Expected: action undoed

Actualy: replay throws an error

I am trying to use it with redux-devtools-extension and i am getting the following error:
Uncaught TypeError: a.subscribe is not a function

I then tried adding redux's subsribe method here:
https://github.com/logux/logux-redux/blob/master/create-logux-creator.js#L127

var middlewared = enhancer(function () {
  return {
    getState: store.getState,
+   subscribe: store.subscribe,
    dispatch: dispatch
  }
})(reducer, preloadedState)

This solves the issue but nowredux-devtools-extension does not seam to find any store.
Also using the normal store.dispatch throws an error.
Has anybody managed to combine logux-redux with redux-devtools-extension?

It is currently impossible to authenticate client after it's start which can be feasible for applications with guest access.

For example a chat app where user can view chat rooms as a guest but needs to log in to be able to participate. Now the only way is to refresh the whole app to restart the client with new credentials.

The README says store.dispatch() is legacy api and advises in favor of store.dispatch.local()/crossTab()/sync(), but react-redux passes the store's dispatch method in connect(). Is there a way to use the new methods in react-redux?

Let's say I have a certain condition. During operation, this state is synchronized with the server. When you open a new tab, I want to get this condition. As the time to obtain this status?