loic74650 / poolmaster Goto Github PK

Hi,
I'm building my own script step by step, learning arduino by the way and C programming, using (all) parts of yours.
I noticed that the arduino queue you're using (https://github.com/sdesalas/Arduino-Queue.h) does not free memory when queue is emptying.
If I spam the queue to the max with MQTT commands, it will eat memory up to (max number of items queued) * (MQTTClient packet size, which is 128bits by default) (so with your settings 1k), and will never release these allocation when emptying.
I tried this arduino-queue (https://github.com/EinarArnason/ArduinoQueue) which behave differently and release the allocations. I get the same free RAM when the queue is empty that I had before spaming the queue.

It's a corner case, I doubt we would spam ourselves with MQTT commands...

Thanks for you good job with this script ! Really like it :)

Hi,
Thanks for a great project.
I am trying to build a chlorine controller with a Controllino Maxi with the Poolmaster SW.
At start the ORP and chlorine pump relays are all turned on and I have tracked down the problem to the definition of PUMP_ON macro in Pump.h. It is defined as active low which seems to be opposite to the way my Controllino hardware works. If the relay action is hardware dependent maybe it is good to have it as a parameter to the Pump class.

Are we sure if the system is re-booted during the Flirtation pump window/ hours the PID regulation is delayed and does not start immediately regulating based on water left in the tubes (and therefore not reflecting real water quality? Same question is valid when pump is manually stopped and started during filtration hours. (As a matter of safety).

So does PHRegulationCallback(Task* me) checks when Firltration pump was last started? I don't think so but your insight would be appreciated.

très bon projet que je souhaite mettre en place chez moi mais étant tout nouveau dans ce domaine, j'essaye depuis quelques jours de remplacer la Shield ethernet par une nodeMcu V3 a base d'ESP8266 (ESP-12E).
Si tu as une idée sur comment flasher l'ESP pour pouvoir l'utiliser comme un Shield.

I would need a simplified version for water monitoring.

It is possible to use it on

Arduino UNO R3 ATmega328P + WiFi ESP8266

R1: state of Relay1
R2: state of Relay1
R6: state of Relay1
R7: state of Relay1

R1: state of Relay1
R2: state of Relay2
R6: state of Relay6
R7: state of Relay7

//Orp setpoint (/!\ x100)

shoudl be

//Orp setpoint

as is not multiplied by 100

Line 1690 misses " ; "

storage.pHPumpFR = (float)command["pHPumpFR"];
PhPump.SetFlowRate((float)command["pHPumpFR"]);
saveConfig();
PublishSettings()

Do the peristolic pumps require a specific pressure, or are you injecting it on the suction side?

I'm looking to do the same thing, but my pump at a high speed will be around 20psi.

When updating Filtration Start/Stop hours, the page0.vaStaSto.txt should be set with the new string in order to force updating of the field on all pages.
add this line after line #154:
myNex.writeStr(F("page0.vaStaSto.txt"), temp);

{"pHPumpFR":1.5} -> call this command to set pH pump flow rate un L/s. In this example 1.5L/s
{"ChlPumpFR":3} -> call this command to set Chl pump flow rate un L/s. In this example 3L/s

needs to be L/h no?

Hi!
Really fascinated by your project! I have installed all libraries, using a Controllino Maxi board, however I receive the following error while compiling:

"Archiving built core (caching) in: C:\Users\jdienlin\AppData\Local\Temp\arduino_cache_542260\core\core_CONTROLLINO_Boards_avr_controllino_maxi_0c812875ac70eb4a9b385d8fb077f54c.a
C:\Users\jdienlin\Documents\Arduino\PoolMaster-master\PoolMaster-master\source\PoolMaster\PoolMaster.ino: In function 'simpLinReg':

PoolMaster:1876: error: unable to find a register to spill in class 'POINTER_REGS'

}

^

PoolMaster:1876: error: this is the insn:

(insn 52 51 54 3 (set (reg:SF 67 [ D.2628 ])

    (mem:SF (post_inc:HI (reg:HI 82 [ ivtmp.77 ])) [12 MEM[base: _52, offset: 0B]+0 S4 A8])) C:\Users\jdienlin\Documents\Arduino\PoolMaster-master\PoolMaster-master\source\PoolMaster\PoolMaster.ino:1863 100 {*movsf}

 (expr_list:REG_INC (reg:HI 82 [ ivtmp.77 ])

    (nil)))

"

Any ideas?

Thanks!
Jonathan

{"PSIHigh":1.0} -> set the water high-pressure threshold (1.0bar in this example). When water pressure is over that threshold, an error flag is set.

Could it be the PSIHigh sets the lower limit for the filtration pump to run in stead of the upper limit?

//If filtration pump has been running for over 7secs but pressure is still low, stop the filtration pump, something is wrong, set error flag
if(FiltrationPump.IsRunning() && ((millis() - FiltrationPump.LastStartTime)>7000) && (storage.PSIValue < storage.PSI_MedThreshold))
{
FiltrationPump.Stop();

Setting it at 1 bar in my cofig happily runs the pump generating a constant 5 bar.

I think the check is correct "if you see no pressure buildup there is a problem and stop the pomp" but the description is incorrect.