Giter VIP home page Giter VIP logo

spring-boot-examples's People

Contributors

bayvao avatar bayvaoverma avatar ccodemvc avatar hamzanassour avatar lokeshgupta1981 avatar m1irfan avatar prajamit avatar tgvlt avatar thakkarchandresh avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

chriskulesza amy-oji m1irfan vishwajeetgupta89 duskdrum harshalchav shreya-jain-db prajamit sazidshaikm uyfix devansh-sharma-coditas ritkrs constantinlu yugaljangare vishalraju suresh-gutha tsooding renovate-bot marwensaid akhileshcareer clauruizr dhirajnie hamzanassour asahoo3 kulkarniajit akrity8521 pavbatol saumil11-coder bsmuku sajidlatif akhadke ashokkr987 bxa805 edsonj85 varshadas thakkarchandresh davidcarlin alaahendi saurabhtanu bikeshtri tgvlt fengshch monipapa jiyis sunil965 marinoricardo ankitcharles gethubbyraj suyambuganesh82 jiangsd meet-alfie aguspriyatin80 kmrvass abhilashchauhan1994 yunpenglidatascience techspace-2020 bayvao pt-23 yaduvanshi6584 purnachand99 syskantechnosoft enextus jugocag omarjairbq vetrisoft itsmeibrahimm rehaabkassim1 wangpeng1 sanveera utkirbekqutfiddinov ravi383 diaabashtawi vboyana7235 mallikarjun170 taicristiano send2jitu dongnv-jv kalebhaskarasrinivas shclub sifanjm hcmm m9rcy pessoni issac-newton ssjvirtually dineshmoningi aouahmane allaboutevemirolive singhmonica1999 taggdev minhnhut0602 yashkanrish iamsathish hjunior premraj10 aju1999 hema391 harrycoder1991

spring-boot-examples's Issues

application.properties has extra properties but there is no explanation of the same

Also the properties file

https://github.com/lokeshgupta1981/Spring-Boot-Examples/blob/master/spring-boot-resilience4j/src/main/resources/application.properties

management.endpoints.web.exposure.include=*

#management.endpoint.health.show-details=always
#management.health.circuitbreakers.enabled=true
#management.health.ratelimiters.enabled=true

#resilience4j.circuitbreaker.configs.default.registerHealthIndicator=true
#resilience4j.ratelimiter.configs.instances.registerHealthIndicator=true

# 5 concurrent calls allowed
resilience4j.bulkhead.instances.courseBulkheadApi.maxConcurrentCalls=5
# Wait for 10ms before failing in case of limit breach
resilience4j.bulkhead.instances.courseBulkheadApi.maxWaitDuration=10ms

# Time window of 60 seconds
resilience4j.ratelimiter.instances.studentRateLimiterApi.limitRefreshPeriod=60s
# 5 calls allowed
resilience4j.ratelimiter.instances.studentRateLimiterApi.limitForPeriod=5 
# Fail immediately without any delay
resilience4j.ratelimiter.instances.studentRateLimiterApi.timeoutDuration=0s
resilience4j.ratelimiter.instances.studentRateLimiterApi.registerHealthIndicator=true
resilience4j.ratelimiter.instances.studentRateLimiterApi.eventConsumerBufferSize=10

has extra properties

#management.endpoint.health.show-details=always
#management.health.circuitbreakers.enabled=true
#management.health.ratelimiters.enabled=true

#resilience4j.circuitbreaker.configs.default.registerHealthIndicator=true
#resilience4j.ratelimiter.configs.instances.registerHealthIndicator=true

though they are commented, I was expecting circuitbreaker example code too here.. always good to explain in readme what all examples can be expected

#58

All examples need a way to run and test i.e. exact commands to be used

All examples are too simple to understand and self-explanatory.. however it is always good to have a readme with each example that says how to run and test the solution..

e.g. for resilence4j example, not sure how to test retry and bulkheads..

May be if you can write automated tests that make requests fail and the fallback response comes that would help much more too

rateLimiterApi name needs to be changed to studentRateLimiterApi

https://github.com/lokeshgupta1981/Spring-Boot-Examples/blob/master/spring-boot-resilience4j/src/main/resources/application.properties

has property studentRateLimiterApi

image

But the control method that is referring to is named as rateLimiterApi

https://github.com/lokeshgupta1981/Spring-Boot-Examples/blob/master/spring-boot-resilience4j/src/main/java/com/howtodoinjava/resilience4j/controller/StudentController.java

image

May be needs to change this name to studentRateLimiterApi

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.