Giter VIP home page Giter VIP logo

Comments (7)

mattkanwisher avatar mattkanwisher commented on July 17, 2024 1

@ZimM-LostPolygon will take a look at this, should have a new release this week

from unity-sdk.

coinsandsteeldev avatar coinsandsteeldev commented on July 17, 2024

I'm constrained by this issue a lot. And i think this is huge problem right now.

from unity-sdk.

coinsandsteeldev avatar coinsandsteeldev commented on July 17, 2024

It seems like we can emit anything we want in Go contract. And i think we need better approach to TransformChainEvent, i would make it injection, with some standard one by default. Right now if i want to have pure protobuf events i need to open source code of SDK and change it. So i would propose this simple change which will make life easier for future generations :)

from unity-sdk.

ZimM-LostPolygon avatar ZimM-LostPolygon commented on July 17, 2024

@coinsandsteeldev Not exactly sure I understand the issue. The first argument of ctx.Emit() or ctx.EmitTopics() goes into JsonRpcEvent.Data. And sure, you can put pretty much anything there. But you say that it replaces the complete RawChainEventArgs.Data?..

from unity-sdk.

coinsandsteeldev avatar coinsandsteeldev commented on July 17, 2024

@ZimM-LostPolygon No it doesn't. It fails to parse JsonRpcEvent at all.

from unity-sdk.

coinsandsteeldev avatar coinsandsteeldev commented on July 17, 2024

Of course if you follow JsonRpcEvent layout it will be ok, but i don't think it is a way to go. It is fixed easily, and it is done in my own version of your SDK.

from unity-sdk.

ZimM-LostPolygon avatar ZimM-LostPolygon commented on July 17, 2024

Yep, I can confirm there is an issue. Meanwhile, you probably should subclass Contract and override TransformChainEvent.

from unity-sdk.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.