Should wrap in UNITY_WEBGL conditional define

hello, when you add 5 level crypto zombies???

Currently, it is only possible to get new events that are triggered during a connection session. However, it is not possible to get logs of previous events.

Since we move from plugin-based contracts more towards EVM-based contracts, I think it makes sense to rename Contract into a more specific PluginContract, because otherwise it can be assumed that plugin-based contracts are some kind of "recommended default".

There was ios secure enclave and Android keystore system available in mobile that could securely store cryptographic key. Does the loom sdk use these ?

This is Contract.cs method which is used to pre-process event before emitting it to listeners.

protected override ChainEventArgs TransformChainEvent(RawChainEventArgs e) {
    string jsonRpcEventString = Encoding.UTF8.GetString(e.Data);
    JsonRpcEvent jsonRpcEvent = JsonConvert.DeserializeObject<JsonRpcEvent>(jsonRpcEventString);
    byte[] eventData = Encoding.UTF8.GetBytes(jsonRpcEvent.Data);

    return new ChainEventArgs(
         e.ContractAddress,
         e.CallerAddress,
         e.BlockHeight,
         eventData,
         jsonRpcEvent.Method
    );
}

When i emit event in Go either using ctx.Emit() or ctx.EmitTopics() i have same result:

jsonRpcEventString has serialized json from Emit for instance

type AccountCreatedEvt struct {
	Test  string
	Test2 int
}

Will result as {"Test": "test", "Test2": 1488}. So the next line fails to deserialize
JsonRpcEvent jsonRpcEvent = JsonConvert.DeserializeObject<JsonRpcEvent>(jsonRpcEventString);

Resulting in converting null to byte[]

I wonder whether it is problem of Loom Node emitting event in the wrong format or something else.

For EVM contracts, Unity SDK currently uses Org.BouncyCastle.Math.BigInteger instead of System.Numerics.BigInteger, since due to a Unity bug, System.Numerics is not referenced in generated C# projects. This is a major inconvenience, since Nethereum had to be modified to use Org.BouncyCastle.Math.BigInteger, and, to be honest, Org.BouncyCastle.Math.BigInteger is much worse compared to the native .NET System.Numerics.BigInteger in terms of interface and convenience.

However, I accidentally found out that Unity has a callback that is called after C# project are generated. This allows to add System.Numerics reference by trivially modifying the projects:
https://gist.github.com/ZimM-LostPolygon/13c4a196f241072939d477998278948c

If we add this to the SDK, we won't have to maintain a fork of Nethereum that uses Org.BouncyCastle.Math.BigInteger, and everyone will be able to use System.Numerics.BigInteger, which is much nicer. The downside, obviously, is that the any existing C# code that uses Org.BouncyCastle.Math.BigInteger will break. This is unfortunate, but I believe using the native System.Numerics.BigInteger type is beneficial enough to justify that.

@enlight What do you think?

User reported:

plus WSRPCClient.cs has EnsureConnectionAsync() and it can be called several times, for example i want to make several requests in parallel

and if socket is still not connected it will re-create WebSocket in js

Currently, samples just include a copy of the SDK, which works, but is messy. People seem to just download the sample and rip the SDK out of it, even if it is outdated already.

We need to have a way to easily keep the SDK up-to-date in samples. Proposal: remove the SDK from samples, and instead have a script that will bootstrap the SDK - download the latest package from GitHub releases (or any other place we can host it) and import it into the sample project.

The downside is that the sample code might be using some APIs that are not present in the latest SDK anymore, but I think it's fair to say this is not going to happen often, and we have to keep the samples working with the latest SDK, otherwise there's little use for them in terms of learning how to use the SDK.

Here is the current version of the bootstrapper:
https://raw.githubusercontent.com/loomnetwork/unity3d-sdk/sample-bootstrapper/UnityProject/Assets/LoomSDKBootstrapper/Editor/LoomSdkBootstrapper.cs

It downloads the latest .unitypackage from GitHub releases of this repo (we don't have any ATM) and imports it into the project. Since the bootstrapper should be distributed as a .dll, rather than source code, Unity will load even if the compilation of sample fails, which it will, since there is initially no SDK in the samples. The .dll can be grabbed from \UnityProject\Library\ScriptAssemblies\LoomSDKBootstrapper.dll.

It would be very helpful to be able to query the logs of past events.
Possibly duplicated issue with #12

Would love something like this:

var event = contract.GetEvent("EventName");

 // Make some filters
var grabAll = await multiplyEvent.CreateFilterAsync();
var filter = await multiplyEvent.CreateFilterAsync(indexedEventFieldValue);

// Get the logs
var allLogs = await multiplyEvent.GetFilterChanges<EventType>(grabAll);
var logs = await multiplyEvent.GetFilterChanges<EventType>(filter);`

Which is exactly as it is in here:
https://nethereum.readthedocs.io/en/latest/contracts/calling-transactions-events/
Under the 'Events, filters and topics' section.

It would be great if we could at least grab the logs without filtering.

Thanks!