Giter VIP home page Giter VIP logo

Comments (2)

loopasam avatar loopasam commented on August 29, 2024

The quotation mark ' has to be explicitly present in the label in order to be handled by the current version of Brain. If no quotation marks are saved in the original ontology, then the label won't be usable in the query.

E.g: The class PATO:0001300 has as rdfs:label optical quality, without quotation marks in the original OWL file (http://purl.obolibrary.org/obo/pato.owl). Therefore no recognised.

The current implementation is arguably a good solution. Things to consider before making changes:

  1. As far as I know, there is no strong specification for rdfs:labels, you can have as many as you like, with the same name, etc... which makes them really ambiguous when formulating queries. Therefore label-based methods should be just considered as features to facilitate the interaction with the ontology - nothing else shamefully. Even if in practice, they are the best interface with the user.

  2. Protege adds extra ' to glue the text and disambiguate some. I don't really like adding extra information that doesn't exist in the ontology, as it can make things pretty tricky to debug and understand. If multiple labels are present or the same value used for multiple entities, it becomes impossible in Protege to know what is what too.

Morality: Labels are there to simplify, but no one should unfortunately rely on them, according to the specs (or my understanding of it). At the time being, if you want to refer to entities using labels in Brain, the label value should explicitly contain '.

from brain.

dosumis avatar dosumis commented on August 29, 2024

I agree that one shouldn't rely on labels in production code and that referring to entities by their labels is unsafe for ontologies without a unique name constraint or with multiple labels per term.

However, a large number of OBO ontologies follow both these constraints and querying on IDs is very inconvenient for scripts taking using input of queries. So, it would be great if you could allow querying on labels for ontologies that passed both of these constraint tests.

Understandable if this is too specialised a request for Brain though.

from brain.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.