Giter VIP home page Giter VIP logo

Comments (2)

jmalangoni avatar jmalangoni commented on June 29, 2024

iirc if nbRetries = 0 the value reverts to some default. so nbRetries actually represents "number of retries - 1"? If so, maybe this just needs to be documented better... EDIT: this is the case for NbRep in LinkADRReq MAC command, NOT for LoRaMacSendConfirmedFrame.

Looks to me now that AckTimeoutRetries and AckTimeoutRetriesCounter could use zero as a base with a few additional changes, but at this point it could break compatibility for anyone using the new API and the value of McpsConfirm.NbRetries. Again, maybe this just needs to be documented better?

from loramac-node.

djaeckle avatar djaeckle commented on June 29, 2024

Hi,

thanks for the report. Please intrepret the attribute "nbRetries" as the "number of trials". We will update the name of the attribute "nbRetries" and also the related documentation in the next release.

from loramac-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.