lostinbrittany / ace-widget Goto Github PK

Hi,
This is Rohan. I had some doubt , I embedded ace-widget tag in polymer webpage. I am getting this text "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" in the editor.
Could you please let me know the source of error. Please find attachment.
Thanks,
Rohan.

Hello,
I've run into a small issue with focus.

Editor gets focused everytime value attribute is changed from outside. I don't feel like this is a correct behavior. Imagine you want to use ace-widget only as a viewer. Anytime you edit value from some external textarea (or whatever), focus gets stolen by the ace-widget.

The ShadowDOM hack on ace-widget-shadow-dom.html seems to be broken in Firefox...

I get a JS error when theme is not set explicitly.

The theme needs the entire path (eg 'ace/theme/eclipse'), not just 'eclipse' as the current theme property default.

I recommend changing the default to 'ace/theme/eclipse', and make sure documentation is clear that a theme must be specified as per the underlying ace editor object.

Demo page should work with polyserve and have relative references used for other bower-installed components.

See https://www.youtube.com/watch?v=p7Q1mQtFGM8 for an understanding of the recommended practices.

Just happened to notice this while working on a different issue. The call at

Hi Horacio

Hope all's been well since the conference.

The element currently outputs a lot of debug info. It'd be nice to have a flag to control this behaviour.

Mode property (highlighting language) cannot be changed dynamically after the element is attached. The changes are not reflected to the editor object, modeChanged() method is not called.

There is no observer tied to the mode property.

The new tools from the Polymer team, like Polymer CLI use the true shadow-dom instead of shady-dom, by means of the setup of Polymer options:

  <script>
    // setup Polymer options
    window.Polymer = {lazyRegister: true, dom: 'shadow'};

    // load webcomponents polyfills
    (function() {
      if ('registerElement' in document
          && 'import' in document.createElement('link')
          && 'content' in document.createElement('template')) {
        // browser has web components
      } else {
        // polyfill web components
        var e = document.createElement('script');
        e.src = '/bower_components/webcomponentsjs/webcomponents-lite.min.js';
        document.head.appendChild(e);
      }
    })();
  </script>

ace-widget doesn't work when dom: 'shadow', I don't know still why...

I am getting this value in the editor:
ההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

I have the following code in JS:

var editor = ace.edit("editor");
editor.session.setMode("ace/mode/json")
        editor.setOptions({
            mode: "json",
            wrap: true,
        });

If I remove these lines, nothing is added in the editor. How can I solve this issue?

This causes a problem when ace-widget-shadow-dom.html loads after "use strict" has been seen.

I want to use the ace-widget component in another polymer 3 component.

Is a version for polymer 3 planned for ace-widget or already in progress?

The xyzChanged methods don't seem to be called because there are no observers defined for the properties (for example, valueChanged is never called so setting ace.value = 'xyz' does not update the editor).

There is a runtime error with Polymer 2 in ace-widget-shadow-dom

Polymer.StyleProperties does not exist.

Editor fails to show :(

You cannot easily get rid of the default grey border or style the inner editor in any way.

There should be a mixin that would allow user customize the appearance.

e.g.:

#editor {
  border: 1px solid #e3e3e3;
  border-radius: 4px;
  @apply(--ace-widget-editor);
}

https://github.com/LostInBrittany/ace-widget/#events

Per the README, an editor-ready is triggered when the Ace instance is created. However, it doesn't appear to be firing.

On further inspection, editor-content is the only event that appears to be fired from https://github.com/LostInBrittany/ace-widget/blob/master/ace-widget.html