Giter VIP home page Giter VIP logo

Comments (2)

louthy avatar louthy commented on June 15, 2024 2

ToHashMap already exists, but it takes a IEnumerable<(K, V)>. What that means is you merely have to map to a pair to get the same behaviour. This maintains a separation of concerns: 1. the mapping, and 2. the conversion of the type.

(Obviously your implementation highlights that, I'm just explaining for those reading along).

What's better...

This?

    people.Map(p => (p.Id, p.Name)).ToHashMap()

Or, this?

    people.ToHashMap(p => p.Id, p => p.Name)

Some of this will be pure personal preference, but I would posit that the first is more declarative. The second one may just edge it on convenience, but isn't so declarative.

from language-ext.

guythetechie avatar guythetechie commented on June 15, 2024

Thanks for the perspective. To be clear, I wasn't suggesting replacing the current method signature; just adding a new extension.

That said, it's trivial to implement for those who need it (which might be a minority). And I can certainly appreciate keeping method signatures simple, especially if additional overloads would only serve a small subset of users.

Thanks again for the library. It's one of my favorite in .NET land.

from language-ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.