Why both AsEnumerable and AsEnumerableOne? about language-ext HOT 3 CLOSED

The intended use is so decision logic (has value, doesn't have value) can be used in a LINQ join for example. AsEnumerable could be useful in a lazy stream situation, where it's essentially a switch enabling or disabling the stream. AsEnumerableOne is essentially a direct conversion of the Option monad into an IEnumerable monad. So it's purely a type conversion really.

I agree that both are not needed, AsEnumerable().Take(1) = AsEnumberableOne(). It's purely for convenience.

Happy to take further feedback on this.

from language-ext.

Ok, that's more or less what I thought.

Regarding further feedback, as you said AsEnumerableOne is the direct type conversion into the IEnumerable monad, so consider renaming this AsEnumerable. What you're currently calling AsEnumerable is actually a type conversion + repeating that value forever, so consider renaming this one to have the additional suffix: AsEnumerableRepeated, if not removing it entirely.

I don't do enough functional programming to have a sense for how often the lazy stream switch situation comes up, but it sounds like something I've seen done with IObservable (System.Reactive.Linq). There is already a conversion from IEnumerable to IObservable (AsObservable), and there is already a Repeat method which makes it infinite, so the convenience seems minimal vs. just composing two existing functions.

Weighing the convenience vs. how frequent this situation comes up vs. the added confusion of having two conversions into the IEnumerable monad, etc seems warranted.

from language-ext.

Thanks for the feedback @brandf - I think you're right, and have made the necessary modifications.

from language-ext.