rsmods's People
Forkers
deadcombo poizenjam aidanaedy renatoluz katdevsgames th0rstenf alo81 kozaka-tv marant69 getupkidak cha0sbuster thesg tnt-coders paulocorazza zanzo420 zrocksmith braianwhite kiname bytedecoder dragunovam satellitnorden gabrielibus tekkid2009 tjwrona andercard0 lbulej m653l andressvergara siarkowy mfacenet howard-chan connor-harkness zyendomani obfuscatedgeneratedrsmods's Issues
GUI - Bug - Reset To Default BAD Tab Index
When the program first starts, the tab index of the reset to default button is set first and is highlighted. This makes it so if someone accidentally presses ENTER / RETURN they will delete all their settings.
GUI - FR - Custom Tuning Start @ 37500
If you do it otherwise, you get results like this https://media.discordapp.net/attachments/711633334983196756/738596937695100938/unknown.png
and
https://media.discordapp.net/attachments/711633334983196756/738597541553111070/unknown.png
Maybe automated to do the last number +1 starting at 37500, and hide that from the user?
DLL - FR - Fix Disco Mode
The reason disco mode was scrapped like 30 minutes before launch is because you can't turn it off after you already turn it on. I wonder if you do pDevice->GetRenderState(D3DRS_ALPHABLENDENABLE, (DWORD*)initialAlphaValue)
and pDevice->GetRenderState(D3DRS_SEPARATEALPHABLENDENABLE, (DWORD*)initialSeperateValue)
once, before we do any modifications, if you could do a revert function by just doing pDevice->SetRenderState(D3DRS_ALPHABLENDENABLE, (DWORD*)initialAlphaValue)
and pDevice->SetRenderState(D3DRS_SEPARATEALPHABLENDENABLE, (DWORD*)initialSeperateValue)
FR - remove uplay form main game menu, replace with EXIT
Replace the Uplay main menu option with the grey X in the upper right, to properly quit the game
DLL - Bug - Bass headstock
FR - Custom tuning fix via dll
Inject our own tuningdatabase.json to the game, or append entries to the games one, first might be easier.
The psarc based mod also edits the maingame.csv file to add tuning definitions, but that is "only really" needed to have the font used be correct, could we add the definitions "on the fly" from the definitions used in the tuningdb.json?
Json only mod will show up in game, more or less correctly, for English users, maingame mod is needed for non-english users to have a useful tuning name. (much, much lower priority)
DLL - Bug - 2 Spammed in console
Every 2 or so seconds 2 is placed in the console.
Error: "You are pretty stupid"
Does not mention anywhere in the documentation that you can not use a pirated version. Please mention it in the documentation vs wasting peoples time and calling them stupid. You may be the stupid one?
Best Wishes
DLL - QoL - Check Menu Status
The way we check the current menu against a group of string arrays is bulky and can be moved to a function with 2 inputs, string for the thing we are looking for (currentMenu), and the string array to search (songModes). Should just be a bool function containing the same code we used before and returning it, just to make calling it easier and making the code easier to read.
DLL - Bug - No Loft + Tuner Not Black
Picture when the tuner should be black
DLL - Bug - Pressing "Generate Texture" in ImGUI skips forward a section in the song.
DLL / GUI - FR - Guitar Speak Tuning
Add an option that allows the player to use Guitar Speak in the tuning menus BUT don't make it default, and tell users that it may make tuning harder.
GUI - QOL - Optimize Code
When creating the GUI, I was just starting to learn how to code C# and C++, so with the knowledge I've learned, I want to rewrite the backend to be more developer friendly (remove unnecessary repeated code, single line brackets, etc).
FR - Enable the Players guitar sounds in Microphone Mode
Apparently, the MM doesn't disable tone simulation exactly, it is just turned right down in the bus - if we can turn that back up - then MM can be the "interface" or "direct connect" mode it always should have been.
GUI - Rewrite Backend With Dictionaries
Already started in the commit: d05d165
Will be working on it tomorrow to try and get this done with for the (potential) launch.
DLL - Bug - Rainbow String doesn't work anymore.
DLL - FR - Guitar Speak Extra Keys
[ ]
tilde key
/
Not sure any others would be genuinely useful, but those are ones I can see myself using
DLL - Bug - Crash On Alt+Tab (Possibly due to DX9Text)
The game will white screen and crash when alt tabbing back into the game. I believe this is due to the DX9Text rework. I have yet to debug the DLL to see if that is the case.
DLL - Bug - Windowed Mode No Frames
In full screen, I get 165 FPS constantly. If I press F11 to change into windowed mode, my game drops to 6 fps and stays there,
FR - Skip intros / fast load via dll
Fast load / skip intros without replacing a psarc file.
Can we (selectively) inject our own pre-modified inrosequence.gfx file instead maybe?
Fix note accent colors
Oh, I remembered one.
Fix accents by whatever means possible.
GUI - Bug - Twitch Reward Settings Not Saving
If I select 3 versions of the Rainbow Strings reward, 2 bits and 1 channel point, and enable them all only the last one I click gets saved. This works the opposite way too, so if I disable all the mods only the last one is removed.
Relaunching the GUI is a great way to test to see if the saves worked.
DLL - FR? - Reverse Engineer AlphaGame
This includes rewriting all the lua code from AlphaGame, and documenting the conversion between BehaviorAPI (Gamebryo with the documentation) and C++. This may take a while, and doesn't need to be done right away. This is meant to make our conversions more accurate by using code that RS has, and modifying it for our uses.
DLL - Bug - Mysterious Crash Bug
A number of people have reported Rocksmith opening, shooting a white screen, then crashing.
The exact explanation of what happens is this:
- White Rocksmith Screen Shows Up
- Cursor Gets The Spinning Blue Loading Icon
- Rocksmith Crashes
I have been told people have fixed it by going through their settings one by one and finding what is wrong. Sometimes it's some mods don't work, other times it's nothing wrong.
#rocksmithBeingRocksmith
DLL - QoL - Song Volume On Screen
If "Change Song Volume" is checked, draw some text saying what level the volume is at 0-100.
This also includes making a global draw text function as we will need to use it for more than one thing AND see if volume can be cranked to 11 (above 100 in our case) for the songs that are super quiet.
DLL - FR - More Tones In Tone Slots
I've seen a couple references to keybindings in the cache psarc, and was wondering... Could we hijack player 2's keybindings for Tone 2,3,4 when multiplayer is disabled and give Player 1 access to 3 more preset tones. I feel like the only hurdle we would need to do is how the user sets those tones outside of multiplayer.
GUI - Bug - Songlist 1 Blank By Default
Creating a brand new INI causes Songlist 1 to be a blank string.
[SongListTitles]
SongListTitle_1 =
SongListTitle_2 = Define Song List 2 Here
SongListTitle_3 = Define Song List 3 Here
SongListTitle_4 = Define Song List 4 Here
SongListTitle_5 = Define Song List 5 Here
SongListTitle_6 = Define Song List 6 Here
DLL - FR / Bug - Fix UpdateSettings
Right before release we disabled the ability for your settings to be updated LIVE, making it so you don't need to restart the game every time you want to change a keybind or something like that. The reason it was removed is because it would crash the game after updating a couple times.
But now that we have access to a debugger, or rather, we found a way to debug the DLL while running a non-modded copy of Rocksmith we can see what exactly breaks.
PS. If outside of a debug build, we can remove the Sleep()'s as they were added to keep the FPS as high as possible, when we thought that it was a mod causing the huge FPS drops.
TL;DR: I need to test the UpdateSettings() with the Debugger I got working.
Just to clarify, I mean the sleeps currently between DLLMain.cpp:654-661 as seen here
GUI - Bug - Reset To Default Doesn't Reset To Default
Title.
If you reset to default, it refreshes the form and shows the RemoveLyrics is shown. This is the bug I found in #32
When checking the INI, it doesn't seem to actually be deleting the file and recreating it, in fact it just hides the settings until the next launch where it'll show the settings that were shown pre-reset.
DLL - FR - Enable Pause menu tuner in song
Pause menu tuner optionally shown while in LAS - useful for knowing how far you're bending etc or seeing accuracy on the fly.
Having it always shown in the main menus would also be kind of nice.
Test to see if this posts in discord
I hate not knowing what to fix :(
FastLoad - Bug - Fast Load Doesn't Work On NVMe SSD (PC Specs In Thread)
Whenever I click Add Custom Tunings
or Add Exit Game option
at the Set and Forget Mods
tab, I can't load the game.
I have my rocksmith installed on an M.2 NVMe SSD with 2.4GB Read and 1.1GB Write, yet I still can't use the Fast Load
option, I just get stuck on the loading screen where the guitar pick is just looping its animation.
So I restored the cache and I just wanted to enable the custom tunings
and the exit game
options however, clicking any of these buttons glitches out my rocksmith with the exact same issue, where I have to sit on the loading screen forever with the pick.
After clicking one of these options I never see the loading intros, so I am guessing that they enable the Fast Load
option somehow...
Also If I can get any help on why the Fast Load option doesn't work on my SSD that would be great.
DLL - FR - Clean Up Settings Import Names
Change the Internal Setting names to the one that are actually imported from the GUI.
DLL - FR - enable disconnected mode for both players.
Useful for recording multi-path scroll throughs.
Super low priority, but if a possible method is stumbled upon, I'd like this.
DLL - FR - Faster / Slower Songs
Take apart the Riff Repeater speed value and see if we can hijack it on the fly. This could be used to have slower songs while not wanting to enter RR (maybe for some streamers who want to nail the solo in LAS but don't want to keep replaying it), and speed it up (maybe past 100 like how Clone Hero does it. Ex: Acai playing Knights of Cydonia at 300% speed)
Consider using a help dialog instead of tooltips
I find it really hard to read super long tooltips that don't want to stay visible until I'm done reading them.
I think having a help button that displays a dialog box with explanations for all options to be cleaner and easier to read.
GUI - FR - Warning message on Cache backup reset
Title explains itself.
Just needs a MessageBox with a warning sign, OK & Cancel buttons.
OK -> Reset Cache back to the initial value
Cancel -> Exit Sequence
GUI - Bug - "Open" file prompt
The open file prompt that shows up when the user launches the GUI from the One-Click-Installer. It would be fine if it worked as intended, but it won't accept any input from a Rocksmith folder, as if they're blacklisted. Results end up seeking "InputFolder/dlc" which doesn't exist in most cases. Might just be a fault else statement
GUI - FR - ZZ's Colors as "Default" ER colors
string0_CB = 00c68e
string1_CB = ff4f5a
string2_CB = e2c102
string3_CB = 1dacf9
string4_CB = ff9216
string5_CB = 3fcc0c
GUI - Bug - Remove Lyrics Is True On New INI
Title...
I assume I'm reading the checkbox value wrong on launch.
Selecting any mod causes Unhanded exception
Almost all options give this. Fresh install, ran the game and even re installed CDLC.
Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.WindowsAPICodePack.Shell
Assembly Version: 1.1.0.0
Win32 Version: 1.1.0.0
CodeBase: file:///F:/Steam/steamapps/common/Rocksmith2014/RSMods/Microsoft.WindowsAPICodePack.Shell.DLL
----------------------------------------
Microsoft.WindowsAPICodePack
Assembly Version: 1.1.2.0
Win32 Version: 1.1.2.0
CodeBase: file:///F:/Steam/steamapps/common/Rocksmith2014/RSMods/Microsoft.WindowsAPICodePack.DLL
----------------------------------------
RocksmithToolkitLib
Assembly Version: 2.9.2.0
Win32 Version: 2.9.2.0
CodeBase: file:///F:/Steam/steamapps/common/Rocksmith2014/RSMods/RocksmithToolkitLib.DLL
----------------------------------------
Newtonsoft.Json
Assembly Version: 10.0.0.0
Win32 Version: 10.0.3.21018
CodeBase: file:///F:/Steam/steamapps/common/Rocksmith2014/RSMods/Newtonsoft.Json.DLL
----------------------------------------
System.Numerics
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Numerics/v4.0_4.0.0.0__b77a5c561934e089/System.Numerics.dll
----------------------------------------
System.Runtime.Serialization
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Serialization/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Serialization.dll
----------------------------------------
System.Data
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/System.Data/v4.0_4.0.0.0__b77a5c561934e089/System.Data.dll
----------------------------------------
Accessibility
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
SevenZipSharp
Assembly Version: 0.64.3890.29348
Win32 Version: 0.64.3890.29348
CodeBase: file:///F:/Steam/steamapps/common/Rocksmith2014/RSMods/SevenZipSharp.DLL
----------------------------------------
System.Xml.Linq
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
Microsoft.CSharp
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll
----------------------------------------
************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.
For example:
<configuration>
<system.windows.forms jitDebugging="true" />
</configuration> ```
DLL - FR - more than 4 / 5 tones available to a song
Tones A-E shouldn't be a hard limit.
No others are addressed in the code, but can we bodge in F-Z somehow?
DLL - FR - special effects (Rainbow Strings) enabled by a stream notification
Optionally activated, Rainbow Strings - or other "parkinsons" modes, activated for X seconds when there is a new subscriber notification, or something like that.
DLL - FR - NSP modified "on the fly" based on sniffer input or newly enumerated song?
Could a NSP list be amended while playing? Silly thought, sniffer / mods dl new song - auto enumerate makes it show in game, NSP list is amended and the streamer just flows from a song to song, with minimal.down time between each one?
Bass A220 ER Mode broken
It works for bass but it triggers on E standard guitar :(
DLL - FR - Speed up the results screen in Guitarcade
I enjoy a few of the guitarcade games since I'm somewhat new to guitar, but it takes so long for the results screen to show me a score I don't care at all about if I lose a game and it just hangs there for a few seconds.
Is there anyway to shorten that animation, or just skip the results screen entirely? It would be very nice to just jump right back into the next round of whatever game I'm doing awful at instead of having to wait 10-15seconds between rounds.
Probably a niche feature since I don't think most people even go into that menu, but it would be an amazing QoL change.
DLL - FR - reset tone system via trigger (or autodetect?)
Basically a way to reset the tone system, so if anyone is "tone bugged" they don't need to restart the game.
See Zags Notepad for a "Trust_Antisocial_broke_p.psarc" that can be used to test tone breaking, the lead path will intentionally tone bug out instantly.
DLL - Bug - Some mods are unreliable
Some mods load some times, and sometimes they don't. Reason: UNKNOWN
DLL - FR - Use Guitar to control menus.
UKLooney did a shit load of work on this ages ago, got it nicely functional (pre-remastered) - could we include this?
uklooney - links and source for his "guitar to rs menus" mods
https://www.dropbox.com/sh/5eohki6t8gp9cmd/AABaJ_PchZjzTgMJbTdlSZ0wa?dl=0
GUI - Bug - Resource Folder Unknown
I added some tunings, clicked the Add Custom Tunings button, Clicked the Add Main Menu Quit / DC Mode button, then clicked delete temp folder, and delete unpacked cache. I closed the app and tried to restart it, but I get the following message.
System.IO.DirectoryNotFoundException: 'Could not find a part of the path 'C:\Program Files (x86)\Steam\steamapps\common\Rocksmith2014\RSMods\CustomMods\tuning.database.json'.'
This occurs on line 26 of GenUtil.cs. What I assume happened is the functions outputDir doesn't contain the Resources folder anymore. Should be a quick fix.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.