luca-montaigut / colorstrap Goto Github PK

I think it could be useful to tests some key aspects of the app.
Like the CSS generation, if it's formatted properly, if the color theme is saved, etc.

• It would become mandatory as the app grows, to keep track of breaking changes and to avoid them :)

Hi,

In the app/controllers/colorstraps_controller.rb there is no strong parameters.
We should add some to prevent unwanted data and/or SQL injections =)

Hi,

Currently there isn't any validation at the model level, which is quite dangerous considering the fact that we want to only save valid color schemes (With valid color codes ^^)

I think it would be wise to add some sort of validations :)

Hi,

At the moment default colors are hard-written in the colorstrap form.
Can't we figure a way to put these values somewhere else ?

Hi,

Currently when we generate a CSS file (min.css aswell as overlay.css) we get a trailing %> at the end.
It should be removed ^^