Giter VIP home page Giter VIP logo

fabric-seasons-extras's People

Contributors

lucaargolo avatar

Watchers

avatar

Forkers

nillo-code

fabric-seasons-extras's Issues

[Crash] 16 is not an allowed value for PROGRESS

image

When disabling minecrafts daylight cycle it is possible for the ticks till next season to be 0. If a calendar has been placed/is placed at this time the client will crash due to an IllegalArgumentException due to how PROGRESS is calculated

java.lang.IllegalArgumentException: Cannot set property class_2758{name=progress, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]} to 16 on Block{seasonsextras:season_calendar}, it is not an allowed value
    at net.minecraft.class_2688.method_11657(class_2688.java:125)
    at io.github.lucaargolo.seasonsextras.block.SeasonCalendarBlock.method_9605(SeasonCalendarBlock.java:60)
    at net.minecraft.class_1747.method_7707(class_1747.java:119)
    at net.minecraft.class_1747.method_7712(class_1747.java:71)
    at net.minecraft.class_1747.method_7884(class_1747.java:50)
    at net.minecraft.class_1799.method_7981(class_1799.java:264)
    at net.minecraft.class_636.method_41934(class_636.java:363)
    at net.minecraft.class_636.method_41933(class_636.java:328)
    at net.minecraft.class_636.method_41931(class_636.java:278)
    at net.minecraft.class_636.method_2896(class_636.java:327)
    at net.minecraft.class_310.method_1583(class_310.java:1748)
    at net.minecraft.class_310.method_1508(class_310.java:2002)
    at net.minecraft.class_310.method_1574(class_310.java:1829)
    at net.minecraft.class_310.method_1523(class_310.java:1135)
    at net.minecraft.class_310.method_1514(class_310.java:768)
    at net.minecraft.client.main.Main.method_44604(Main.java:244)
    at net.minecraft.client.main.Main.main(Main.java:51)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

fabric-seasons-extras/src/main/java/io/github/lucaargolo/seasonsextras/block/SeasonCalendarBlock.java

Lines 53 to 60 in b063f67

public BlockState getPlacementState(ItemPlacementContext ctx) {
World world = ctx.getWorld();
long timeToNextSeason = (FabricSeasons.CONFIG.getSeasonLength() - (world.getTimeOfDay() - ((world.getTimeOfDay()/FabricSeasons.CONFIG.getSeasonLength())*FabricSeasons.CONFIG.getSeasonLength()) )) % FabricSeasons.CONFIG.getSeasonLength();
double progressLeft = timeToNextSeason / (double) FabricSeasons.CONFIG.getSeasonLength();
int currentProgress = (int) (16.0 - (progressLeft*16.0));
Season currentSeason = FabricSeasons.getCurrentSeason(world);
Direction facing = ctx.getSide().getAxis() != Direction.Axis.Y ? ctx.getSide().getOpposite() : ctx.getPlayerFacing();
return this.getDefaultState().with(SEASON, currentSeason).with(PROGRESS, currentProgress).with(FACING, facing);

Cursed floating mangled tree generates near spawn

I'm assembling a modpack on 1.19.4 with Fabric Seasons 2.0.1 and EXTRAS 1.1-BETA, and everytime i create a new world (on large biomes type), a very bizarre floating mess of trees and leaves of multiple types generates near spawn:

2023-04-25_13 59 32
2023-04-24_22 45 48
2023-04-24_22 45 34

I thought it could be a particular mod i have in my modpack that add cursedness on the game, but when i mentioned this issue on Fabricord someone mentioned having the same issue but on 1.19.2, comparing both modpacks we realized Fabric Seasons was present on both.

So, i tested removing temporally both seasons and extras and created a spitting copy of a previous world where the floating thing generated, and it's gone. So i think that is being added by seasons.

Invalid Player Data issue

I am having trouble using this mod in conjunction with the main mod or any configuration of my other mods and getting booted from a freshly generated single player game with the message "Invalid Player Data", the Fabric Seasons mod itself works great. I have my logs saved from the moment it causes the error and was wondering if you could shed light on it? The error goes away if I remove this mod from my list.

[22:46:36] [Server thread/ERROR]: Couldn't place player in world
io.netty.handler.codec.EncoderException: String too big (was 25991069 characters, max 32767)
	at net.minecraft.class_2540.method_10788(class_2540.java:617) ~[client-intermediary.jar:?]
	at net.minecraft.class_2540.method_10814(class_2540.java:612) ~[client-intermediary.jar:?]
	at io.github.lucaargolo.seasonsextras.FabricSeasonsExtras.lambda$sendMultiblocks$27(FabricSeasonsExtras.java:255) ~[fabric-seasons-extras-1.1-BETA+1.19.jar:?]
	at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?]
	at io.github.lucaargolo.seasonsextras.FabricSeasonsExtras.sendMultiblocks(FabricSeasonsExtras.java:253) ~[fabric-seasons-extras-1.1-BETA+1.19.jar:?]
	at io.github.lucaargolo.seasonsextras.FabricSeasonsExtras.sendValidBiomes(FabricSeasonsExtras.java:176) ~[fabric-seasons-extras-1.1-BETA+1.19.jar:?]
	at io.github.lucaargolo.seasonsextras.FabricSeasonsExtras.lambda$onInitialize$4(FabricSeasonsExtras.java:131) ~[fabric-seasons-extras-1.1-BETA+1.19.jar:?]
	at net.fabricmc.fabric.api.networking.v1.ServerPlayConnectionEvents.lambda$static$2(ServerPlayConnectionEvents.java:48) ~[fabric-networking-api-v1-1.2.11+10eb22f490-f06f04cf50fd31dd.jar:?]
	at net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.onClientReady(ServerPlayNetworkAddon.java:65) ~[fabric-networking-api-v1-1.2.11+10eb22f490-f06f04cf50fd31dd.jar:?]
	at net.minecraft.class_3324.handler$def000$fabric-networking-api-v1$handlePlayerConnection(class_3324.java:7513) ~[client-intermediary.jar:?]
	at net.minecraft.class_3324.method_14570(class_3324.java:200) ~[client-intermediary.jar:?]
	at net.minecraft.class_3248.method_33800(class_3248.java:151) ~[client-intermediary.jar:?]
	at net.minecraft.class_3248.method_14384(class_3248.java:138) ~[client-intermediary.jar:?]
	at net.minecraft.class_3248.redirect$deg000$fabric-networking-api-v1$handlePlayerJoin(class_3248.java:563) ~[client-intermediary.jar:?]
	at net.minecraft.class_3248.method_18784(class_3248.java:73) ~[client-intermediary.jar:?]
	at net.minecraft.class_2535.method_10754(class_2535.java:248) ~[client-intermediary.jar:?]
	at net.minecraft.class_3242.method_14357(class_3242.java:183) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:886) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:819) ~[client-intermediary.jar:?]
	at net.minecraft.class_1132.method_3748(class_1132.java:98) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:665) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[client-intermediary.jar:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]
[22:46:36] [Server thread/INFO]: KingBendrick lost connection: Invalid player data
[22:46:36] [Server thread/INFO]: KingBendrick left the game

Thanks and great job on the mod, I love the concept for an animal crossing type setup I'm working on!

This mod appeared in my game

I just updated Fabric Seasons to 2.0, and when I entered my world I got a notification about this add-on. I suppose that's not intended since it looks like I can't download it on modrinth or curseforge yet

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.