Giter VIP home page Giter VIP logo

sketch-styles-generator's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sketch-styles-generator's Issues

Support Sketch 45 plugin update system

Hi there!

This is a quick note to remind you that Sketch 45 will include a plugin update system.

It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.

For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/

Thanks in advance!

Generated style not shown in another file via library styles

This is how a generated style appears in its original file:
(no update button, weird isn't it?)

before

When that file is a library, we can look for that generated style, but we can't find it:

before2

Atfer click in create button — A workaround I found...

This is how it looks like in its original file now:
(the update button is there)

after

And finally, it becomes visible in the library's panel:

after2

Thank you for the plugin, it is awesome!

Use artboard name to generate styles

With libraries, my text layer name is a generic name like "Text" for the override. It would be great to able to use the artboard name instead of the layer name to generate styles (or at least the option to choose which one to pull the name from). Thanks!

Sketch 50: Command doesn't do anything when layers are selected

Looks like something broke with the latest release 😭

When I try to run the "Generate Shared Styles" command nothing happens with a layer selected. Doesn't seem to work for both text and graphic layers.

If no layer is selected I do get the "No layer(s) selected!" message.

Screen recording

Once Detached—Unable to Create Styles

Summary

I believe once you detach a text style from a layer, the plugin is unable to create new text styles for the any new or existing layers which have no text style applied. As in, the file is no longer able to "Create" new styles. You are however, able to update layers with existing styles.

Example:

  1. I opened an existing file to expand the text styles available.
  2. I duplicated a list of layers with type styles applied to them. Adjusted the type, then detached the layer style.
  3. I tried to use the plugin to create new styles, but the plugin appeared to do nothing. (no feedback other than the menu flashing) Fig. 1 below*

2019-04-10 17 29 29

Figure 1: Selecting text laters and attempting to create from both the menu and the hotkey yielded no results.

Troubleshooting/Pinning down the issue:

  1. I copied the text from this file some with styles applied, the rest with the text styles detached (e.g. H1 and H2 are text styles, H3–H6 are just text layers and named in order to be generated into styles properly.)
  2. Used the plugin. No issues. The layers with text styles applied that I copied in that had just "updated" or "didn't update since there was no change", while it created the other 64 instances. (Worked normally).

Quick Fix / Alternate Path

I found by copying the detached style layers (properly named), and pasting them in a new file—I was able to generate the styles there. Following that I then copy/pasted them back into the origin file and the styles transferred. So this may mean I have a Sketch or file corruption issue in some way, but I'm not certain.

Hope this info is helpful.

Link layers to styles if style already exist

Scenario:

Style already exists in shared styles.

I select a layer with the same name as the already available style.

Result: nothing happens
Expected result: I would expect that the layer would be linked to the shared style.

My proposal for udpate:

// update shared styles, and sync instances
const update = (sharedStyles, sharedStyle, layer) => {
  if (layer.hasOwnProperty('sharedStyle')) {
    layer.sharedStyle.style = layer.style;
  }else{
    layer.sharedStyleId = sharedStyle.id;
  }

Updating styles is broken

I'm using Sketch version: 53.2

I noticed that when I regenerate styles that already exist (to update them) that instead of replacing the original styles it duplicates the whole set.

I checked they have exactly the same names

This isn't an issue if you regenerate styles shortly after the original styles have been created. it seems to happen later. For example if you update them the day after you first created them.

Thank you for your help in this.
Keep up the amazing work!

Plugin does not update

image
Might be that the manifest did not get an update on version number? It keeps saying there is an update, or it is not downloading the update.

Can't generate styles

I've opened a new document, created a few text styles with left, center and right alignment, then named them using the 'Rename it' plugin. I then selected all of the layers and applied the "generate shared styles" and nothing happens.

I've tried multiple times, using new documents, restarting the machine, and deleting and re-installing the plugin.

Artboards generate empty styles

When I select an artboard and run styles generator, it creates an empty style named after the artboard. Would it be more sensible to skip artboards when generating styles, since artboards can't have layer styles applied to them?

Use folders to organize styles

I started using this plugin, and I realized something that would make it even better.
If a folder/group is selected, the plugin would use those folders/groups as a hierarchy when creating the text styles.

So instead of having to do this:
screen shot 1

You could do this:
screen shot 2

Making it much easier to organize and view styles.

I will attempt to make this change myself, but I haven't tabbed in Sketch plugins yet.
I just thought, this would be a cool feature for future versions.

Doesn't work with Sketch 49

Hi there,
Thanks for amazing plugin! It saved so much time for us!

Not sure if you have plans to support this awesome plug in... But it would be great if you could take a look.

Thanks!

Plugin Not Working

Installed first time and the Styles are not getting generated. Tried all the options even installed multiple times. Installed directly as well as through Sketch Runner. Still not working.

Can you help me get it running?

Details:
SketchApp Ver (50.2)
Styles Generator Plugin 1.4.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.