Comments (2)
ahbarnett
commented on July 29, 2024
I guess our jl tests didn't cover that case (we need an equiv of "dumb inputs" which I wrote on the C++ unit tests...)
Thanks & if you can do a PR for this and the other, excellent - Cheers, ALex
from finufft.jl.
ludvigak
commented on July 29, 2024
Hah, we actually have a test in test_error_handler.jl that tries to make sure this error is thrown, but it seems it passed anyway in the PR because the test never entered the catch block.
But I guess this makes sense. I was trying to make sure the user is strictly reminded if using an unreasonable tolerance, but unlike the C++ code it's not ignorable here, so maybe it's a too harsh.
from finufft.jl.
Related Issues (20)
- Build on MacOS Catalina HOT 8
- Provide binary dependency with JLL package HOT 1
- ComplexF32 data support HOT 2
- Problem in macOS Catalina when Julia updated HOT 1
- TagBot trigger issue HOT 10
- Thread-safety
- on recovering FFTW result? HOT 1
- finufft_setpts should be finufft_setpts! HOT 1
- finufft_destroy crashes Julia HOT 1
- FINUFFT.jl fails to run (yet) on Julia 1.7.1 / macOS arm64 HOT 10
- Implement AbstractNFFTs HOT 4
- Multiple plans simultaneously HOT 17
- In-place versions nufftndm! require dtype argument for single-precision transforms HOT 2
- Redundant argument checking for out-of-place nufftndm calls
- Tests crash process for Julia 1.8.5 HOT 4
- Interface to GPU code cufinufft
- Having trouble understanding what nufft type 1 is doing HOT 4
- nufft1d2 not working HOT 1
- Possible sub-optimal flags in cmake HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finufft.jl.