lukasjuhrich / grading Goto Github PK

Automatically staging / tagging / committing would be very helpful.

However, to actively add git to the workflow, security mechanisms such as checking the directory is clean (nothing staged already) etc. have to be added!

If something like „noreply“ is in the From: header, take the value of Reply-To:.

Instead of capturing the date and returning the _mail namedtuple, directly parsing the mail would be easier, since that will be done in every following procedure (such as list_mails, iter_attachments) anyway.

The current implementation is hacky and ugly.

Automatically sending mails would be convenient.

If wanted, select the mail-id of the extraction as the In-Reply-To-Header.

click appears to be a great python library for building CLIs. I should use it.

See e.g. This SO answer.

Running grade.py person add is easier to use.

let the user give a default extension if wanted (e.g. .py).

I do not think it is good to call exit(1) in arbitrarily deep functions. Exits should be handled by some global instance, not by isolated functions. Those should perhaps raise a RuntimeError or similar, which is then catched and formatted nicely.

A person being added later doesn't get „bootstrapped“ if a round is already opened.

When extracting attachments, it would be easy to guess the correct person from the From: header.

A safety requirement could be to require the second-least distant string to have at least 5% greater distance than the closest one. Thi is helpful if e.g. there are two persons of a similar name (e.g. Christoch Schmidt vs. Christof Schmidt)

Intelligently recognize and extract archives.

Premium: If there are files plus an archive (and the archive doesn't have a top-level-folder), use a subfolder.