lukasmartinelli / mapbox-gl-inspect Goto Github PK

Would like to also show the id field, because it becomes more important for feature states.

I don't know it is a problem or not ...

Mapbox QA tiles is very special, because minzoom: 12 and maxzoom: 12
see more:

• https://www.mapbox.com/blog/osm-qa-tiles/
• http://osmlab.github.io/osm-qa-tiles/

so I downloaded and tested via tileserver-gl ( which is containing the mapbox-gl-inspect )

my simple test script :

mkdir qatiles
cd ./qatiles
wget https://s3.amazonaws.com/mapbox/osm-qa-tiles/latest.country/iceland.mbtiles.gz
gunzip iceland.mbtiles.gz
docker run -it --rm -v $(pwd):/data -p 8080:80 klokantech/tileserver-gl

The over zooming is fine:

but no warning when z < minzoom: 12 ,

so my theoretical questions:

• it is possible to show minzoom: maxzoom: info
• detect if z < minzoom:

Bonus: A picture of a cute animal: idea

foto : Jan Truter on Flickr https://flic.kr/p/iBaEkQ

When I change mapbox-gl version from v1.9 to v2.6, I got this error in MapboxInspect.js:

  <link href="https://api.mapbox.com/mapbox-gl-js/v2.6.0/mapbox-gl.css" rel="stylesheet">
  <script src="https://api.mapbox.com/mapbox-gl-js/v2.6.0/mapbox-gl.js"></script>
  <!-- <link href="https://api.mapbox.com/mapbox-gl-js/v1.9.0/mapbox-gl.css" rel="stylesheet"> -->
  <!-- <script src="https://api.mapbox.com/mapbox-gl-js/v1.9.0/mapbox-gl.js"></script> -->

MapboxInspect.js:135 Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at MapboxInspect._onSourceChange (MapboxInspect.js:135)
    at Map.fire (evented.js:129)
    at Map.<anonymous> (map.js:548)
    at Map.fire (evented.js:129)
    at je.fire (evented.js:144)
    at vector.fire (evented.js:144)
    at je.update (style.js:553)
    at Map._render (map.js:2865)
    at map.js:3217

http://mapbox-gl-inspect.lukasmartinelli.ch/#3/51.03/-74.50 is giving a 401.

Hi lukasmartinelli,

I am trying to make a version of mapbox-gl-inspect that works with the new maplibre-gl-js fork.

For my first attempt I took the already built mapbox-gl-inspect.min.js and did a string replace on all mapbox text (except classes). This was successful and that version is here https://raw.githubusercontent.com/acalcutt/maplibre-gl-inspect/master/dist/maplibre-gl-inspect.min.js

However, I noticed the version I had modified was a bit out of date so I wanted to make a newer version. I made this fork here ( https://raw.githubusercontent.com/acalcutt/maplibre-gl-inspect/ ). It is mostly working except I can't seem to get the popup to work.

I see the following error, which seems to be trying to append html into the popup, which seems to be null...I'm guessing this is because the popup does not exists.

Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
    at o.setDOMContent (popup.js:426)
    at u._onMousemove (maplibre-gl-inspect.min.js:177)
    at r.Ct.fire (evented.js:119)
    at Fo.mousemove (map_event.js:118)
    at gr.handleEvent (handler_manager.js:325)

However as far as i can tell I have changed what would be needed to make a popup in maplibere ( window.maplibregl.Popup ).

I'm not seeing any errors and I was wondering if you have any ideas why the popup piece is not working (everything else seemed to be working as far as I can tell)

This is the version I compiled from the source at https://raw.githubusercontent.com/acalcutt/maplibre-gl-inspect that is not working
maplibre-gl-inspect_broken.zip

Wondering if you might have any tips for what the issue may be... its mostly working so maybe I changed something obvious.

Edit: the one I modified by hand can be seen working here ( https://wifidb.net/wifidb/opt/map.php?func=wifidbmap&labeled=0&sig_label=none ).

While using the plugin after adding it to a layer of point geometry type, we observed that the user would click on a point, but the hover would not appear. The plugin checks the type of the object it attempts to add to as a parent. If it's of type 'string', then it adds the hover as HTML. Otherwise as a DOM content (near line 216 of MaboxInspect.js).

Only after allowing for a type of 'undefined' could the popup actually be added to the data structure by invoking this._popup.setHTML(). So the new proposed code would be

if (type === 'string' || type === 'undefined') { this._popup.setHTML(this.options.renderPopup(features)); } else { this._popup.setDOMContent(this.options.renderPopup(features)); }

The inspect/map icons appear in Safari but do not work in Chrome:

Safari

Chrome

In Chrome 79.0.3945.130 64-bit:

But it works in Edge.

Hello,
The latest version of mapbox-gl-inspect on npm is 1.3.1 from 3 years ago: https://www.npmjs.com/package/mapbox-gl-inspect

Would you please publish a new version containing the latest changes from the master branch?

This will bring in the fix for the control icon image: dab82f2

Thank you