(01) ticket - (03) validation about build-your-own-jira-with-rust HOT 11 CLOSED

Yep CLion's still the daddy for now. But the gap is closing fast.

Grep for: "This isn't our JIRA works"

from build-your-own-jira-with-rust.

TicketDraft shouldn't really have a Status on it as it really is a status? I.e. everything starts as a Status::ToDo

from build-your-own-jira-with-rust.

Also please use #[allow(unused_doc_comments)] as latest nightly grumbles about things like:

/// Field syntax: you use a dot to access the field of a struct.
assert_eq!(ticket_one.description, "A heart-breaking description");

(two slashes works fine)

from build-your-own-jira-with-rust.

Go to definition of Ticket using rust analyser looks at lots of tickets - doesn't make it clear that recap::Ticket is the one you want. This is a failing of RA, but might trip some people up as there's a lot of Ticket definitions at that point.

from build-your-own-jira-with-rust.

Ok, I think I fixed it 👍
Don't really know how to address the code navigation issue unfortunately 😞

from build-your-own-jira-with-rust.

FYIW, I found the Jetbrains plugin to be able to resolve the types fairly well

from build-your-own-jira-with-rust.

for 2_05 I think we could fill in the impls of TicketDraft and Ticket for them - they're tired by now and there's no doubt what goes in them really.

from build-your-own-jira-with-rust.

I think it would be awesome if we could give them this:

impl TicketPatch {
        fn apply(self, ticket: &mut Ticket) {
            if let Some(title) = self.title {
                ticket.title = title;
            }
            if let Some(description) = self.description {
                ticket.description = description;
            }
            if let Some(status) = self.status {
                ticket.status = status;
            }
        }
    }

and somehow point out that the method totally consumes the patch (i.e. it's taking ownership of self).

from build-your-own-jira-with-rust.

for 2_05 I think we could fill in the impls of TicketDraft and Ticket for them - they're tired by now and there's no doubt what goes in them really.

It's mostly for muscle memory, I think it's useful to just type it out for yourself a couple of times.

from build-your-own-jira-with-rust.

for consistency it might be better to use todo!() everywhere rather than a mix of __ and todo!()

from build-your-own-jira-with-rust.

todo!() unfortunately can only be used in function bodies, not for type signature and other wildly illegal omissions 😁

from build-your-own-jira-with-rust.