Minute feedback about build-your-own-jira-with-rust HOT 3 CLOSED

And another thing, I think one should have these..

    impl FromStr for TicketTitle {
        type Err = ValidationError;

        fn from_str(s: &str) -> Result<Self, Self::Err> {
            Self::new(s.into())
        }
    }

and similarly

    impl FromStr for TicketDescription {
        type Err = ValidationError;

        fn from_str(s: &str) -> Result<Self, Self::Err> {
            Self::new(s.into())
        }
    }

Because at first read, it seems more reasonable to have

        Edit {
            #[structopt(long)]
            ticket_id: TicketId,
            /// Status of the new ticket.
            #[structopt(long)]
            status: Option<Status>,
            #[structopt(long)]
            title: Option<TicketTitle>,
            #[structopt(long)]
            description: Option<TicketDescription>,
        },

handle_command is private, but should be public to be able to be used from main.rs.

from build-your-own-jira-with-rust.

Also, isn't

    impl std::fmt::Display for ValidationError {
        fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
            write!(f, "{}", self.0)
        }
    }

is supposed to be something like:

    impl std::fmt::Display for ValidationError {
        fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
            write!(f, "{}", self.0)?;
            Ok(())
        }
    }

Maybe write! has changed, since clippy isn't saying anything.

I don't see why it is necessary to use the ? operator - write! should be returning a std::fmt::Result, hence we can return it directly. What am I missing here?

from build-your-own-jira-with-rust.

from build-your-own-jira-with-rust.