Giter VIP home page Giter VIP logo

glided-rose's Introduction

Glided rose Refactor + UI

1. Refactor

I've refactored the existing model by not reading existing code but adding unit tests, as existing code was barely readable. I've written Unit tests for all the business cases which led me to way simpler implementation of Glided Rose class. After writing unit tests I've refactored the code by creating domain methods for updating sell in and quality properties in readable maneur.

2 UI

Not much time left to acomplish this task that is why I've decided to make it as simple as possible but still with proper practices. But definietly have the list of TODO's for the future which you can find below

2.1 TODOS UI

  1. Fix state management by using API that handles domain glided rose model
  2. Accessibility
  3. Virtualize list of items so the list is dynamically removed from DOM, it makes the app smoother
  4. Consider SSR/SSG
  5. Display more details about Glided Rose Item but it is up to domain
  6. Add more functionalities e.g adding items to cart, but it is not handled by the domain for now
  7. Animations in Framer Motion when the quality/sell-in changes
  8. Handle domain states/different items by UI representation. E.g Quality is red when it is below 0, Sell in gets orange if it reaches end for normal items or so
  9. Write some tests of user flow

How to start

yarn dev

glided-rose's People

Contributors

luksari avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.