The confirmation dialogs in Lumi don't use the proper H5P styles:

It's also not centered vertically.

Describe the bug
The 'About Lumi' menu item doesn't open the about dialog in Windows. The reason is that the 'about' role is only supported in MacOS.

We have to manually create a new windows with the dialog.

Environment (please complete the following information):

• OS: Win 10

Thanks for creating a very useful application.

JFYI the deb package is available in ppa: https://launchpad.net/~jigish-gohil/+archive/ubuntu/education

This is not really an issue, this is just for information.

Describe the bug
For some unknown reason closing tabs can take a very long time, if other tabs have been opened as well.

Environment (please complete the following information):
v0.0.7

Currently tabs can simply be closed by pressing the X next to it. If the user closes a tab by accident and has edited something in there, the change will be lost.

We should add a dialog asking the user whether he wants to save, discard or cancel.

Describe the bug
The editor doesn't appear if the last closed tab was in "view" mode.

Environment (please complete the following information):

• v0.0.7

To Reproduce
Steps to reproduce the behavior:

1. Start app
2. Open an existing H5P
3. Switch to edit mode and back to view
4. Close the tab
5. Create a new H5P

Using H5P-content still requires a server component. H5P Standalone provides the missing libraries to make H5P self-contained and run without an explicit server. It would be convenient if Lumi provided an export option for this. Technically this would only mean adding certain static files, see our H5P-Creator). But maybe such a feature would interfere with Lumi.run (no offence intended)?

Describe the bug
The editor is only partially displayed (see screenshot).

Environment (please complete the following information):
v0.0.7

To Reproduce
Steps to reproduce the behavior:

1. Open a file from the disk
2. Click on "edit"

Screenshots

Describe the bug
Default keyboard accelerators are not working (cmd+a,cmd+c,cmd+v), so if you want to select or copy text it won't work.

Environment (please complete the following information):

• 0.1.0

Expected behavior
Text should be selectable by cmd+a and copied with cmd+c & cmd+v.

Additional context
This is most likely due to undefined electron accelerators.
Possible solution: https://medium.com/fantageek/supporting-copy-and-paste-in-electron-30bff250e564

I don't understand how to start the development server to debug the application.

I've done this:

npm install
npm run build
npm start

The browser opens and loads http://localhost:3000. However, I then get the following errors:

Proxy error: Could not proxy request /static/js/bundle.js from localhost:3000 to http://localhost:3001/.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED).

Proxy error: Could not proxy request /static/js/0.chunk.js from localhost:3000 to http://localhost:3001/.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED).

Proxy error: Could not proxy request /static/js/main.chunk.js from localhost:3000 to http://localhost:3001/.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED).

How do I start the second (backend?) server on 3001?

There currently is no file association for h5p files in Windows. This would be very neat.

This would require the installer to install for 'all users' and not only for the current user. It might be best to leave the choice up to the user, as we avoid the problem of requiring admin privileges.

Users should be able to opt-out of error- and usage-tracking to be in line with GDPR.

Describe the bug
If you switch from "edit" to "view" when opening the sample Branching Scenario at https://h5p.org/branching-scenario#example=440740 you get h5p-update-error in the UI. Saving also doesn't work.

Environment (please complete the following information):

• Lumi 0.2.0

Describe the bug
In the editor of course presntation the tooltips are clipped in the overflow menu. I don't think this is an error in Joubel's client but has something to do with the custom renderer.

Environment (please complete the following information):

• Lumi v0.07

Screenshots

Is your feature request related to a problem? Please describe.
Lumi does not display mathematical expressions in LaTeX.

Describe the solution you'd like
Lumi should be able to display mathematical expressions.

According to https://h5p.org/mathematical-expressions we have to install the following library:
https://h5p.org/sites/default/files/h5p-math-display-1.0.5.h5p

I think @sr258 also had the idea of a library-management-section where the user can manage all libraries. That would be an ideal use case or we include that library right from the beginning.

yarn install
yarn install v1.21.1
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
warning @commitlint/cli > babel-polyfill > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning @commitlint/cli > babel-polyfill > babel-runtime > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning @material-ui/core > [email protected]: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
warning @types/[email protected]: This is a stub types definition for electron (https://github.com/electron/electron). electron provides its own type definitions, so you don't need @types/electron installed!
warning @types/[email protected]: This is a stub types definition for Moment (https://github.com/moment/moment). Moment provides its own type definitions, so you don't need @types/moment installed!
warning @types/[email protected]: This is a stub types definition. query-string provides its own type definitions, so you do not need this installed.
warning babel-jest > @jest/transform > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve > [email protected]: https://github.com/lydell/resolve-url#deprecated
warning babel-jest > @jest/transform > jest-haste-map > sane > micromatch > snapdragon > source-map-resolve > [email protected]: Please see https://github.com/lydell/urix#deprecated
warning jest > jest-cli > jest-config > jest-environment-jsdom > jsdom > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning jest-environment-jsdom-fourteen > jsdom > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning resolve-url-loader > rework > css > [email protected]: Please see https://github.com/lydell/urix#deprecated
warning semantic-release > @semantic-release/npm > npm > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning semantic-release > @semantic-release/npm > npm > node-gyp > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning spectron > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning spectron > [email protected]: outdated version, please use @next
warning spectron > webdriverio > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning spectron > electron-chromedriver > electron-download > nugget > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
[2/4] Fetching packages...
error @semantic-release/[email protected]: The engine "node" is incompatible with this module. Expected version ">=10.18". Got "10.15.2"
error Found incompatible module.
info Visit 

also fails with npm

Not all dependencies in package.json are updated by Renovate. Several are currently outdated, even though they are not major releases. @JPSchellenberg , I can update them manually, but I'd like to check with you whether they are pinned on purpose.

I also have had trouble running npm ci: Weirdly, there is always some file missing in node_modules after it. I want to regenerate package-lock.json for this purpose. Any concerns?

Describe the bug
If the screen width is very high, the player uses the space. This leads to problems in some content types that don't really expect a width that high. This for example is true in Drag & Drop (see video below), but also in other content types. Portrait images that are enlarged by clicking on them become really big.

This is a problem that also occurs in the PHP implementation, if the screen width is high. Still, I think we should give it some thought, whether we can improve the situation somehow.

Please include AppImage file in the release and get it listed on https://appimage.github.io/

Once AppImage is available in released files, see: https://github.com/AppImage/appimage.github.io#how-to-submit-appimages-to-the-catalog

Create a pull request with one file, like this example: https://github.com/AppImage/appimage.github.io/blob/master/data/AKASHA

This will make Lumi available to all Linux distributions easily.

Thanks

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Describe the bug
The title is not saved after changing/exporting the file.

Environment (please complete the following information):

• all

To Reproduce
Steps to reproduce the behavior:

1. Create a new H5P
2. Change its title
3. Save it

Expected behavior
The title in the Tab should be updated.

Describe the bug
If you click on the full screen button in the editor of content types that support it (e.g. Course Presentation), you don't get a fullscreen view but the editing area is actually smaller than before.

Environment (please complete the following information):

• Lumi v0.0.7

"Missing translation of library core" flashes when opening editor. The reason is that the order of the JS includes is not correct. This might be fixed by a newer version of the h5p-nodejs-library.

Describe the bug
The LeftDrawer is placed above the crash-report-dialog, so a part of the dialog is cut off.

Environment (please complete the following information):

• all

To Reproduce
Steps to reproduce the behavior:

1. Open the LeftDrawer
2. Click on the bug-report button

Expected behavior
LeftDrawer should be closed when opening the crash-report-dialog.

Screenshots

I have learned about a person who had problems installing and using Lumi on Windows. Firstly, Chrome showed the hint that the installer was a suspicious file, which understandably irritated the person:

After installation, the saved H5P file was reproducibly incomplete. As far as I can tell, the H5P libraries in particular are missing. I attached one of the files saved with Lumi (renamed from h5p to zip to bypass the attachment restriction):

arithmeticquiz.zip

So it contains only two files:

h5p.json
content/content.json

Unfortunately I have no further information on the case, so I'm not sure if this is even suitable for further investigations. But at least it is documented as far as possible. Do you have an idea what this might be caused by?

Uploaded images are not displayed in the editor, but they later work when displaying the content. The URLs that are requested are like
http://localhost:59955/api/v1/h5p/contentundefined/images/stgpgqxv-Mg4YtHc4.png#tmp

They return a 404 response.

To improve the integration of H5P content on your own website, it is important to have a consistent style with the rest of the content on the page.

H5P offers the possibility to use a custom CSS. It would be great if Lumi would accept a css file that would allow previewing the created content as it will appear on the website.

You can see an example in the screenshot below, where I adapted the font in the H5P content to be consistent with the table on the page.

Describe the bug
Switching really fast between tabs makes the editor unresponsive (it doesn't load at all / it takes a very long time to load). I think this is because cancelling the loading process isn't a good idea.

Environment (please complete the following information):

• v0.0.7
• a rather slow Surface 3 (disk access is particularly slow)

Steps to reproduce:

• load any file in a tab
• create a new h5p
• switch back and forth between the two tabs

Describe the bug
If you open the Hub list, you get the warning "Content type list outdated". Either the app can't reach the Hub (wrong endpoint? Not registered?) or the update is never called.

Environment (please complete the following information):

• Lumi v0.0.7

Expected behavior
The error message doesn't appear.

Screenshots

I understand the reasoning why Husky forces npm ci after every branch change, but I think this goes a bit too far currently:

Changing branches takes a long time now, as npm ci downloads a massive amount of data and creates thousands of files. Several of the dependencies can't be cached (Chrome download, H5P core data) and it takes several minutes to change a branch (and is sometimes not successful). My main development machine is really potent and things are still slow. I also have trouble pushing branches to GitHub (seems to take forever).

How about changing it to npm install?

Describe the bug
If you click on an external link, electron opens that page and it is not possible to navigate back.

Environment (please complete the following information):

• all

To Reproduce
Steps to reproduce the behavior:

1. Click on crash-report-button
2. Click on the Sentry-logo

Expected behavior
The app should not go to the external homepage.

Screenshots

When trying to open a larger file (here: ~70MB), the error attached message file appears. Where is the upper limit and how can I increase it? If you embed a video, this limit is quickly reached.

If Lumi is installed on macOS (10.15.4) via the zip file from the releases page, Lumi cannot be started afterwards. At first glance this seems to be due to broken symlinks. In the Apple Disk Image the symlinks are intact and the installation works over there. I stumbled over it because the website doesn't always link the latest release, so I had loaded the broken zip file by mistake.

Describe the bug
The Linux version is behind the macOS and Windows version. This is due to the fact that for a release semantic-release is run on the CI-Server for Windows and macOS. During the process, semantic-release checks the latest version, increments the number and writes it to the package.json and pushes it back to github. Then another Ubuntu-Environment is started where the Linux version is built. semantic-release is run here too, but the branch is out-dated because semantic-release pushed the updated package.json to github, therefore no release is created and the package.json for Linux is not updated.

Environment (please complete the following information):

• CI

Possible solution

We could try to make package.json an artifact that is carried over to the ubuntu-environment. That way the version should already be updated.

Describe the bug
If you open the player with content and later resize the window, the content width is not recalculated.

What I'd expect
The content is resized.

Screenshot

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Cannot push to the Git repository.

semantic-release cannot push the version tag to the branch master on the remote Git repository with URL https://github.com/Lumieducation/Lumi.git.

This can be caused by:

• a misconfiguration of the repositoryUrl option
• the repository being unavailable
• or missing push permission for the user configured via the Git credentials on your CI environment

Good luck with your project ✨

Your semantic-release bot 📦🚀

Describe the bug
Clicking on "edit" lots of times breaks viewer

Environment (please complete the following information):

• v0.0.7

To Reproduce
Steps to reproduce the behavior:

1. Open app
2. Load file
3. Click on edit
4. Click on edit 20x very fast
5. Click on view --> nothing happens

There is a superfluous border around the editor.

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

The alignment of icons in buttons is incorrect:

Lumi needs a privacy policy to be listed in the Microsoft Store.

This error pops up several times, always when loading a file:

An added (optional) image to a Dialog card is displayed only in the editor, but not in view mode. In the source code of the content.json you can see that the width and height information for the image is missing. If I add them manually in code, the image will be displayed.

Environment

• macOS 10.15.4
• Lumi 0.27

Broken:

  "dialogs": [{
    "tips": {},
    "image": {
      "path": "images/planung-9DG-IFl5p.jpg",
      "mime": "image/jpeg",

Fixed:

  "dialogs": [{
    "tips": {},
    "image": {
      "path": "images/planung-9DG-IFl5p.jpg",
      "mime": "image/jpeg",
      "width": 1920,
      "height": 1280,

A feature-request from twitter is to hide the edit-button so students can focus on doing h5p-content.