Hello. I have a serverless app written in Typescript and compiled using serverless-bundle.

Seems there's a compatibility issue between lumigo and serverless-bundle. When trying to deploy:

• first, lumigo wraps my typescript files, turning them into js files

> sls deploy --stage $SLS_ENV

Deploying enkicamp-hydra to stage staging (*********)
serverless-lumigo: there are 86 function(s) to wrap...
serverless-lumigo: {"name":"enkicamp-hydra-staging-healthcheck","description":"endpoint to serve as an API healthcheck","handler":"functions/common/api/healthcheck/index.handler","events":[{"http":{"method":"get","path":"/healthcheck","cors":true}}],"localName":"healthcheck"}
...
serverless-lumigo: installing @lumigo/tracer@latest...
serverless-lumigo: 
up to date, audited 2510 packages in 7s

234 packages are looking for funding
 run `npm fund` for details

27 vulnerabilities (13 low, 4 moderate, 9 high, 1 critical)

To address issues that do not require attention, run:
 npm audit fix

To address all issues possible (including breaking changes), run:
 npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

serverless-lumigo: wrapping [functions/common/api/healthcheck/index.handler]...
serverless-lumigo: writing wrapper function to [/home/circleci/hydra/_lumigo/healthcheck.js]...

• second, serverless-bundle runs, trying to compile the typescript

Bundling with Webpack...
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.9.5

Please only submit bug reports when using the officially supported version.
webpack compiled with 1 error
ERROR in /home/circleci/hydra/_lumigo/healthcheck.js
  2:16  error  Require statement not part of import statement  @typescript-eslint/no-var-requires
  5:17  error  Require statement not part of import statement  @typescript-eslint/no-var-requires

✖ 2 problems (2 errors, 0 warnings)

This looks wrong to me. Shouldn't serverless-bundle first bundle compile all ts files, then lumigo wrap them?

Hello, for some reason I'm getting this error in my lambdas:

UserLambdaValidationException: PostConfirmation failed with error Error: Cannot find module '@lumigo/tracer'
    Require stack:
    - /var/task/_lumigo/confirmUserSignup.js
    - /var/runtime/UserFunction.js
    - /var/runtime/Runtime.js
    - /var/runtime/index.js.

My serverless.yml

custom
   lumigo:
      token: ${ssm:/${self:custom.stage}/lumigo-token~true}
      skipInstallNodeTracer: true
      nodePackageManager: yarn

package.json

"devDependencies": {
    "serverless-lumigo": "^1.13.3",
...
},
"dependencies": {
    "@lumigo/tracer": "^1.71.4",
...
}

I wonder if this issue was caused by the fact that I initially integrated lumigo manually, and now I'm integrating it via the the serverless.yml file.

I tried to removed my current project on Lumigo to integrate it via serverless-lumigo but I can't find an option to delete it.

Do you have any idea what's happening?

Hi!

First of all I really like what you're doing! I might be overlooking something but I would like to understand how it works.

I've created the LumigoIntegrationV6 Cloudformation stack in AWS. When using the auto tracer functionality it will automatically connect the lumigo-python-tracer Layer to my Lambda function (I'm using Python).
Using this method, no extra token is required. I assume this uses CF stack (maybe the ExternalId parameter?) to communicate with Lumigo.

When using this plugin, I have to add a token which feels a bit unnecessary. Maybe the LumigoIntegration stack can create a pre-filled, encrypted SSM parameter for the token which then can be used automatically by this plugin?

See this thread floydspace/serverless-esbuild#340

Sorry, wrong repository 😅

I found that if i install with serverless-bundle plugin, which included webpack will throw an error No matching handler found for 'lumigo-auto-instrument' when sls deploy. Are there any work around? thanks

I recently updated my serverless framework version from 2.10 to 2.68.

Now it gives me the following configuration warning on the function scope configuration property of the lumigo plugin:
Serverless: at 'functions.myFunctionName': unrecognized property 'lumigo'
For a function defined like this:

functions:
  myFunctionName:
    handler: functions/my-function.handler
    lumigo:
      enabled: false

Should I be worried about this?
If so, how can I resolve it?

It seems to come from

async createWrappedPythonFunction(func, token, options, isZip) {
  this.verboseLog(`wrapping [${func.handler}]...`);
  
  const localName = func.localName;
  
  // e.g. functions/hello.world.handler -> hello.world.handler
  const handler = path.basename(func.handler);
  ...

as no handler is defined in the function, path.basename can't work properly, while it's a valid serverless configuration according to https://www.serverless.com/blog/container-support-for-lambda

Hi, I want to set up some manual tracing.
I followed the guide.
The lumigo_tracer package is listed in requerments.txt and is installed via pip install -r requirements.txt.
Still deploying with serverless framework does throw this TypeError that sais that Lumigo-Python-Package is not installed.
Are there any additional tweaks to be made?

❯ sls deploy
Serverless: serverless-lumigo: there are 27 function(s) to wrap...
Serverless: serverless-lumigo: checking if lumigo_tracer is installed...

  Type Error ---------------------------------------------

  TypeError: plugins.includes is not a function
      at LumigoPlugin.ensureLumigoPythonIsInstalled (/Users/xxx/sls_plugins/node_modules/serverless-lumigo/src/index.js:329:38)
      at LumigoPlugin.wrapFunctions (/Users/xxx/sls_plugins/node_modules/serverless-lumigo/src/index.js:199:17)
      at LumigoPlugin.afterPackageInitialize (/Users/xxx/sls_plugins/node_modules/serverless-lumigo/src/index.js:71:14)
      at /usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:498:55
      at tryCatcher (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/util.js:16:23)
      at Object.gotValue (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/reduce.js:168:18)
      at Object.gotAccum (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/reduce.js:155:25)
      at Object.tryCatcher (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:547:31)
      at Promise._settlePromise (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:604:18)
      at Promise._settlePromise0 (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:649:10)
      at Promise._settlePromises (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:729:18)
      at _drainQueueStep (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:93:12)
      at _drainQueue (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:86:9)
      at Async._drainQueues (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:102:5)
      at Immediate.Async.drainQueues (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:15:14)
      at processImmediate (internal/timers.js:461:21)

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              14.16.1
     Framework Version:         1.83.0
     Plugin Version:            3.8.4
     SDK Version:               2.3.2
     Components Version:        2.34.9

Webpack + Eslint compilation shows the error below, because the _lumigo folder wrappers have traling spaces at the end of the files.

Can't use plugin unless I disable eslint error.

error:

  8:1  error  Trailing spaces not allowed  no-trailing-spaces

example:

Since it seems – by quickly looking at the source code – that the plugins can use Layers to instrument the code, the README should indicate if the plugins automatically handle cases where we cannot use a layer.

For example, if:

• A docker is being used, because the dependencies are > 250 MB.
• The max number of layers is already used.

PNPM is an alternate package manager to yarn and npm, the most notable of which are generally faster performance and package isolation.

This goes beyond the plugin itself, but it would be great if Lumigo officially supported nodejs14.x runtime

e.g. given this serverless.yml

functions:
  handler1:
    handler: functions/handler1/index.hello

  handler2:
    handler: functions/handler2/index.hello

because both have a file called index.js the plugin generates only one wrapped function _lumigo/index.js

Since Lambdas now support ES6 modules, it would be nice if this plugin could support that as well. See PR #95.

Attempting to deploy function will not trigger the plugin.

This causes all sorts of mayhem.

For instance:

1. Service deployed using sls deploy
2. Without changing the deployed function code, deploy function sls deploy -f fooBar
3. Code won't change as Serverless will let us know Serverless: Code not changed. Skipping function deployment.
4. The handler however will get updated, and will now longer point to _lumigo/fooBar.js but rather mypath/foo-bar.js, and executing the function will fail to execute in runtime because the code does not exist there.

Attaching to the function:deploy lifecycle hook should do the trick.

Opened #24 to resolve this one

e.g. given the following serverless.yml

package:
  individually: true
  exclude:
    - "**/*"
  include:
    - functions/**/*

functions:
  handler1:
    handler: functions/handler1/index.hello
    package:
      include:
        - functions/handler1/index.js
        - node_modules/**/*

the wrapped function _lumigo/handler1.js would not be in the packaged zip file

Request to add a global flag to enable / disable Lumigo, so that in temporary / development environments it can be dynamically disabled based on deployment stage.

Example:

custom:
  lumigo:
    token: <YOUR TOKEN GOES HERE>
    skipInstallNodeTracer: true # defaults to false
    enabled: false

I had an error in my serverless.yml which was to not reference the method, but only the file.

Correct:

functions:
  loadMarketOrders:
    handler: src/jobs/load_market_orders.handle

Wrong:

functions:
  loadMarketOrders:
    handler: src/jobs/load_market_orders

With the lumigo plugin active, I got an error message that seemed to swallow the error and redirected me to the file's line nr. 3 which was an import statement.

START RequestId: e396709d-efac-405a-9bd2-3ec8904da918 Version: $LATEST
[ERROR] Runtime.UserCodeSyntaxError: Syntax error in module '_lumigo/loadMarketOrders': invalid syntax (loadMarketOrders.py, line 3)
Traceback (most recent call last):
  File "/var/task/_lumigo/loadMarketOrders.py" Line 3
    from  import load_market_orders as userHandler
END RequestId: e396709d-efac-405a-9bd2-3ec8904da918
REPORT RequestId: e396709d-efac-405a-9bd2-3ec8904da918	Duration: 1.97 ms	Billed Duration: 100 ms	Memory Size: 1024 MB	Max Memory Used: 56 MB	Init Duration: 114.16 ms

When I removed the lumigo plugin, the error was a bit more understandable.

START RequestId: 49e38e36-9344-4750-89c9-0ef55f8f9bfd Version: $LATEST
[ERROR] Runtime.MalformedHandlerName: Bad handler 'src/jobs/load_market_orders': not enough values to unpack (expected 2, got 1)
END RequestId: 49e38e36-9344-4750-89c9-0ef55f8f9bfd
REPORT RequestId: 49e38e36-9344-4750-89c9-0ef55f8f9bfd	Duration: 1.51 ms	Billed Duration: 100 ms	Memory Size: 1024 MB	Max Memory Used: 56 MB	Init Duration: 116.08 ms

Suggestion: If possible, don't swallow but print the lower level's error messages.

Notes:

• serverless 1.51.0
• python 3.7
• serverless plugins: serverless-python-requirements and serverless-lumigo

I've followed the instructions on the plugin page and am getting an error that there's no such module as _lumigo.

I tried installing a few previous versions and it doesn't look like the lumigo python-tracer package (distributed as lumigo-tracer) has ever shipped this name, so I suspect the problem isn't that the import name has changed, but that the import command is meant to be doing something else.

{                                                                                                                       
    "errorMessage": "Unable to import module '_lumigo/pypi_release_check': No module named '_lumigo'",                  
    "errorType": "Runtime.ImportModuleError",                                                                           
    "requestId": "4d7f20d8-970a-433f-9317-6f504438b5a4",                                                                
    "stackTrace": []                                                                                                    
} 

I suspect the problem may be due to my project structure: I have a serverless.yml and below it I have directories containing Python packages (subservices) deployed in a single service as one stack.

My guess is that this has resulted in the tracer trying to import them from the wrong location.

I haven't read the source closely enough to be sure but if it's looking in the service directory and then assuming to find the service there, i.e. assuming that the handler must be at the top level. In my case the handler is down a level (there's a dotname that goes subpackage.module.funcdef rather than module.funcdef).

I copied the serverless config down a level and adjusted, and packaged there, and can see that when I enable the sls lumigo plugin I get the following code:

import importlib
from lumigo_tracer import lumigo_tracer
userHandler = getattr(importlib.import_module("release_check"), "check_handler")

@lumigo_tracer(token='t_XXXXXXXXXXX')
def check_handler(event, context):
  return userHandler(event, context)

I suspect this would work if the _lumigo directory created in the packaged zip were dropped down a level so that it ends up being within the bounds of where the individual subpackages can "see" (when the Python runtime is invoked on a subpackage it necessarily limits the parent folder which is "visible" to import from, and I think that's what you're relying on here to make the wrapper work).

Annoying because I can see the handler wrapper is right there, hopefully it will be a simple fix ! :-)

For clarity my "subservice" tree below my src directory containing serverless.yml is:

pypi_watcher/
├── functions.yml
├── __init__.py
├── pypi_watcher
│   ├── __init__.py
│   ├── lookout
│   │   ├── data_model.py
│   │   ├── __init__.py
│   │   ├── main.py
│   │   └── utils
│   │       ├── __init__.py
│   │       └── rss_reader.py
│   └── release_check.py
├── README.md
├── requirements.txt
└── stepfunctions.yml

and I'm using the functions.yml to define functions for the service above it:

service: ss-python-services

plugins:
  - serverless-python-requirements
  - serverless-lumigo
package:
  individually: true
  # Negated ** include optimises packaging time: further `include`s at function level
  include:
    - "!./**"
  exclude:
    - "**"

custom:
  lumigo:
    token: ${ssm:SS-LUMIGO-TRACING-TOKEN}
    skipReqCheck: true
  pythonRequirements:
    dockerizePip: non-linux
    noDeploy:
      - boto3 # boto3==1.26.90
      - botocore # botocore==1.29.90
      - pytest # pytest==7.1.2
      - pydantic # in layers only
      # https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

provider:
  name: aws
  runtime: python3.10
  versionFunctions: false
  deploymentBucket: ss-serverless-deployments
  stage: ${opt:stage, 'dev'}
  region: eu-west-1
  timeout: 300
  environment:
    STAGE: ${self:provider.stage}
  iamRoleStatements:
    - Effect: "Allow"
      Action: "secretsmanager:GetSecretValue"
      Resource: "arn:aws:secretsmanager:*"

functions:
  - ${file(../src/pypi_watcher/functions.yml)}

where the functions.yml file contains:

pypi_release_check:
  handler: pypi_watcher.release_check.check_handler
  module: pypi_watcher
  package:
    include:
      - pypi_watcher/pypi_watcher/**
  timeout: 300
  layers:
    - arn:aws:lambda:eu-west-1:017000801446:layer:AWSLambdaPowertoolsPythonV2:36

• Note that I un/commented out the package: include/exclude statements here to see if they were involved, this is used to achieve individual package separation in this project layout. I commented it out just to be able to see what was going on. It doesn't affect the result.

When I put the following serverless.yml file in the pypi_watcher directory I could see a _lumigo directory in the packaged zip (specifically the function zip pypi_release_check.zip):

service: pypi-watcher-monoservice

plugins:
  - serverless-python-requirements
  - serverless-lumigo
package:
  individually: true

custom:
  lumigo:
    token: ${ssm:SS-LUMIGO-TRACING-TOKEN}
    skipReqCheck: true
  pythonRequirements:
    dockerizePip: non-linux
    noDeploy:
      - boto3 # boto3==1.26.90
      - botocore # botocore==1.29.90
      - pytest # pytest==7.1.2
      - pydantic # in layers only
      # https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

provider:
  name: aws
  runtime: python3.10
  versionFunctions: false
  deploymentBucket: ss-serverless-deployments
  stage: ${opt:stage, 'dev'}
  region: eu-west-1
  timeout: 300
  environment:
    STAGE: ${self:provider.stage}
  iamRoleStatements:
    # pypi_watcher
    - Effect: "Allow"
      Action: "secretsmanager:GetSecretValue"
      Resource: "arn:aws:secretsmanager:*"

functions:
  pypi_release_check:
    handler: release_check.check_handler
    module: pypi_watcher
    timeout: 300
    layers:
      - arn:aws:lambda:eu-west-1:017000801446:layer:AWSLambdaPowertoolsPythonV2:36

Hi,

I just installed the tracer and I noticed that, when adding the zipping option to the 'serverless-python-requirements' plugin my lambdas are raising an ImportError Exception:

{
  "errorMessage": "Unable to import module '_lumigo/DetectDominantLanguageCode': No module named 'lumigo_tracer'",
  "errorType": "Runtime.ImportModuleError"
}

Best,
Javier