lunatk / baemin-order-survey Goto Github PK
View Code? Open in Web Editor NEW배달의민족 단체 주문 메뉴 접수 및 취합 웹앱
Home Page: https://lunatk.github.io/baemin-order-survey
배달의민족 단체 주문 메뉴 접수 및 취합 웹앱
Home Page: https://lunatk.github.io/baemin-order-survey
Describe the bug
주문 페이지에서 세로 컨텐츠가 양이 없으면 Cart 컴포넌트가 하단에 붙어있지 않고 위로 올라가버림.
To Reproduce
기준 커밋 : 28923ee
Steps to reproduce the behavior:
Expected behavior
컨텐츠 양에 상관없이 Cart 컴포넌트는 항상 하단에 sticky 하게 붙어있어야함
Screenshots
Describe the bug
To Reproduce
PUBLIC_URL="/baemin-order-survey" REACT_APP_USE_MOCK=1 npm run build
으로 빌드Expected behavior
Cause of the Bug
window.location
을 직접 수정하는 형태로 구현Possible Solutions
Is your feature request related to a problem? Please describe.
메뉴를 선택하지 않아도 메뉴 리스트에서도 이미지 미리보기 기능 추가
Describe the solution you'd like
Describe alternatives you've considered
import 시 깊은 directory에서 ../
이 반복적으로 사용
// src/lib/api/api.ts
import { IOrderSummary } from '../../store/types';
import { FirestoreDocRef, IEventInfo, IShopInfo } from '../../types/common';
webpack alias를 통해 src/
를 @
로 root dir로 정의
// src/lib/api/api.ts
import { IOrderSummary } from '@/store/types';
import { FirestoreDocRef, IEventInfo, IShopInfo } from '@/types/common';
참고 : http://guswnsxodlf.github.io/path-alias-in-webpack-and-jest
Motivation
Redux store를 Storybook에서 mocking할 필요가 있다.
Storybook의 Decorator를 통해 해결할 수 있는것으로 보임.
참고
https://www.digitalocean.com/community/tutorials/react-storybook-with-redux
Originally posted by @LunaTK in #6 (comment)
Describe the bug
lib/api/index.ts
에서 REACT_APP_USE_MOCK 여부에 따라 mocking 된 API를 exportTo Reproduce
ANALYZE=1 npm run build
실행시 build된 번들 분석 사이트 표시Expected behavior
REACT_APP_USE_MOCK=1
플래그가 설정된 경우에만 해당 내용이 빌드결과물에 포함되어야함.Screenshots
Desktop (please complete the following information):
Additional context
Describe the bug
To Reproduce
기준 커밋 : 0a7e34b
접수 현황
버튼을 통해 주문 요약 페이지로 이동 후 뒤로가기Expected behavior
Screenshots
Describe the bug
Expected behavior
Additional context
Add any other context about the problem here.
Is your feature request related to a problem? Please describe.
src/pages
는 그 자체가 페이지이자 컴포넌트로 설계되어있어, 데이터 fetch와 컴포넌트 렌더링이 동시에 진행Describe the solution you'd like
Describe alternatives you've considered
Additional context
Is your feature request related to a problem? Please describe.
현재 타입 선언에 혼동을 주는 부분과 명확하지 않은 부분이 존재.
IOrder
vs IOrderSummary
는 역할이 비슷해보임.IOrder
는 types/common.ts
에 있어야 할 것으로 보임Describe the solution you'd like
types/baemin.ts
)Describe alternatives you've considered
Additional context
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.