luno / luno-go Goto Github PK

Hi,

I see the Luno API documentation changelog shows:

"2015-07-29: Added Perm_R_Beneficiaries and Perm_W_Beneficiaries permissions. You will have to generate a new API key if you require these permissions."

These permissions seem to be created for viewing, creating, and deleting beneficiaries

"Perm_R_Beneficiaries = 32768 (View beneficiaries)
Perm_W_Beneficiaries = 65536 (Create and delete beneficiaries)"

I don't see any APIs to actually do this though? Do they exist? And if so, does this library support them?

Thanks,

The godoc contains HTML in it.
When viewed in pkg.go.dev, as many devs do, these are not rendered as HTML, e.g. https://pkg.go.dev/github.com/luno/luno-go#Client.PostMarketOrder shows;

We can edit the godoc to use actual links: https://tip.golang.org/doc/comment#links

The same is true within structs too, is this necessary?

No you have to start service on your server
By installing
npm install -g blockchain-wallet-service

Originally posted by @waqas61 in blockchain/service-my-wallet-v3#489 (comment)

Originally posted by @edfiqri in blockchain/service-my-wallet-v3#508

I tried downloading the package using go get github.com/luno/luno-go

However, VS Code can't seem to detect / import it.

could not import github.com/luno/luno-go (cannot find package "github.com/luno/luno-go" in any of
C:\Program Files\Go\src\github.com\luno\luno-go (from $GOROOT)
C\src\github.com\luno\luno-go (from $GOPATH)
\Users\xxx\go\src\github.com\luno\luno-go (from $GOPATH))

Error loading workspace: You are outside of a module and outside of $GOPATH/src. If you are using modules, please open your editor to a directory in your module. If you believe this warning is incorrect, please file an issue: https://github.com/golang/go/issues/new.

I tried manually copying the Luno package from \Users\xxx\go*pkg*\github.com\luno\luno-go to \Users\xxx\go*src*\github.com\luno\luno-go and most of the problems are resolved.

However, I still have error message when I try to run the code in the terminal

main.go:8:2: no required module provides package github.com/luno/luno-go: go.mod file not found in current directory or any parent directory; see 'go help modules'

Recommended by go cli to use go install with @latest to download module.

go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

When I try this:

• go install github.com/luno/luno-go@latest

I receive the following error:

• go: downloading github.com/luno/luno-go v0.0.26
• package github.com/luno/luno-go is not a main package

Currently, it is impossible to tell how much of a limit order has actually filled. It will be great if a property filled_volme can be added to the type Order to hold this value.

Hi,

I've noticed an issue with ETH withdrawals lately. This has happened a few times on our corporate account. This is actually not a API wrapper issue, but I'm not sure what the right forum to raise this would be.

Above shows an ETH withdrawal from yesterday. However, this is still in this state. I have to login, click 'STOP' and re-submit our withdrawal. This initial ETH transfer seems to have never been submitted.

I expect that we could implement a workaround, and cancel the withdrawal after X period and then submit, but obviously I'd rather not have to go this route.

Hi.

Is there a way I can return the highest and the lowest prices of exchange pairs in the last 24 hours, or a week, or a year?
Thanks.

README hasn't been updated in over a year, and, hence, the example provided doesn't actually work since Client methods now require context.

Opening this issue because I intend to close it and will reference it in the PR.

Edit: Submitted a PR closing this issue.

Don't use it, they STOLE your money and don't let you withdraw with escuses after escuses, when they answer at all.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>luno/.github)

I keep getting a Market Unavailable error, anytime I place a limit or a market order.

client.GetTickers(ctx, nil) panics with panic: reflect: call of reflect.Value.Field on zero Value

Hi,

I'm currently receiving no trades when I request them. This previously has worked though :/
I definitely have trades on this account, so under what condition should I be expecting 'null' for the trades?

`
let auth = new Buffer(API_KEY + ':' + API_SECRET).toString('base64');
request({
url: 'https://api.mybitx.com/api/1/listtrades?pair=XBTZAR',
method: 'GET',
headers: {
Authorization: 'Basic ' + auth,
'Content-Type': 'application/json',
},
}, function (error, response, body) {

        if (error) {
            return reject('[getLunoTrades] ' + error);
        }

        if (!response) {
            return reject('[getLunoTrades] Response is ' + response);
        }

        if (response.statusCode >= 400) {
            return reject('[getLunoTrades] Error ' + response.error);
        }

        let jsonTrades = JSON.parse(response.body);
        console.log(jsonTrades);
        if (jsonTrades.trades != null) {
            return resolve(jsonTrades.trades);
        } else {
            return resolve([]);
        }
    });

`

Console output:
{ trades: null }

using the endpoint provided https://www.luno.com/en/developers/api#operation/GetCandles

1 day looks correct but using any of the other time frames the data returned is invalid.

cuurent XRPZAR price is around 8.90ZAR

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• renovate: Update module github.com/gorilla/websocket to v1.5.2

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I might be missing something obvious but I don't see a way of adding a callback to the Conn struct in the streaming package.

The two fields connectCallback and updateCallback on the struct are lowercase and therefore cannot be set from outside the package.

Would it be possible to create a way of adding callbacks to the Conn? Either by exporting the struct fields or creating a new factory function that accepts callbacks.

Hey there can you help point me in the direction to get in contact with someone that works with the Luno Websocket API.

Based on the sockets available and information they provide on the support page im unable to rebuild the order book. Would much appreciate any help.

If this issue should live in one of the other repos here at Luno, please point me in the right direction.

Thanks!

Both the documentation and the code here show OrderType (type) as "BID" or "ASK" for the GetOrder endpoint, however the response contains "SELL" or "BUY"

{
    "base": "1.0263",
    "completed_timestamp": 1621595283273,
    "counter": "3599.2341",
    "creation_timestamp": 1621595283238,
    "expiration_timestamp": 0,
    "fee_base": "0.0030789",
    "fee_counter": "0.00",
    "limit_price": "0.00",
    "limit_volume": "1.0263",
    "order_id": "SOMEID",
    "pair": "BCHMYR",
    "state": "COMPLETE",
    "trades": [
        {
            "is_buy": false,
            "price": "3507.00",
            "sequence": 135867,
            "timestamp": 1621595283273,
            "volume": "0.4555"
        },
        {
            "is_buy": false,
            "price": "3507.00",
            "sequence": 135868,
            "timestamp": 1621595283273,
            "volume": "0.5708"
        }
    ],
    "type": "SELL"
}

Hi, is there any way to return the combined order book entries where the volumes of asks/bids with the same price are summed together? Or does this have to be done by the calling app when an update is received?

Was able to finish but request didn't finish