lxqt / lxqt-openssh-askpass Goto Github PK

Expected Behavior

Unlike x11-ssh-askpass, lxqt-openssh-askpass should display using wayland.

Current Behavior

Despite being a Qt application, it needs X11/XWayland to display.

Possible Solution

¯\_(ツ)_/¯

Steps to Reproduce (for bugs)

1. Use a Wayland DE like Sway
2. Set SSH_ASKPASS=lxqt-openssh-askpass and restart ssh-agent
3. Trigger an askpass situation and notice that the dialog opens with XWayland
4. One could use xeyes to verify it

Context

I'm trying to use a pure Wayland environment, but there are some leftover programs that require XWayland to function.

System Information

• Distribution & Version: Archlinux
• Kernel: 6.0.2.zen1-1
• Qt Version: 5.15.6+kde+r180-2 / 6.4.0-2
• liblxqt Version: 1.1.0-3
• lxqt-build-tools Version: N/A
• Package version: 1.1.0-1

This hardcoded string is misleading:

In my workflow, askpass is triggered for a lot of things like asking for security key pin, for confirming host key,...

Usually, the message provided by ssh is sufficient. I think, this string can just be removed.

Hello,

I found instructions given here don't work re path to SSH agent socket: https://github.com/lxqt/lxqt-openssh-askpass/blob/master/README.md

The reason for this is that if the service is started by systemctl as root, only root can read or write to the socket. I found this works:

[Unit]
Description=LXQT ssh agent

[Service]
Type=forking
ExecStart=/bin/su - myusername -c '/usr/bin/ssh-agent -a /run/user/1005/ssh-agent'

[Install]
WantedBy=default.target

With version 2.0.0, lxqt-openssh-askpass does not focus the input text field automatically anymore. This is the place where one types the password. The OK button is focused instead. Now one has to press TAB twice to reach the text input field in order to type the password.

Tested in labwc-0.7.2 and in LXQt with Openbox.

Expected Behavior

When the lxqt-openssh-askpass application is launched and focused by the window manager, the text input field where one types the passwords should be focused.

Current Behavior

Instead, the OK button is focused.

Possible Solution

Maybe it is related to the migration to Qt6.

Steps to Reproduce (for bugs)

Launch lxqt-openssh-askpass from a terminal and see that the OK button is focused.

Context

I use the application for authentication for some applications, and I have to hit two more keystrokes (TAB) in order to reach the text input field prior to typing the password.

System Information

• Distribution & Version: NixOS unstable
• Kernel: Linux 6.8.9
• Qt Version: 6.7.0
• liblxqt Version: 2.0.0
• lxqt-build-tools Version: 2.0.0
• Package version: 2.0.0